From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com
 [IPv6:2a00:1450:4864:20::341])
 by sourceware.org (Postfix) with ESMTPS id 214B93898517;
 Thu, 30 Apr 2020 16:10:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 214B93898517
Received: by mail-wm1-x341.google.com with SMTP id x4so2521587wmj.1;
 Thu, 30 Apr 2020 09:10:39 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=H6OHpW4hJVny0yipU3oeStZL9G9f0VEtApZ9U6UYm8M=;
 b=s+ikaDqIgTu1kpcCbba+/u12xi4Y2TPbX8ox5AIgB1d+Uh33sDgJX2LTpna90WUU+a
 V9Z6MuSawFTm76no2wOhpaa8T/mHKB8KiVnvMMXZf+qIMD5VJkjGKL4o3qP5Q3XE0g2s
 /Ll130O05/YDLUz5RYuraz5Q7OL+yzQaexRy+7neGK/vHrVO10nN9aiwyryNTYsAjiHD
 KNsVGQNzCPwNYZrwiBY7jWIvPVvQpA1V09rDLCKNjbNafh4VRL9bPBkaJp8uwhJDtaBD
 9rdAjwPwbm5vLKNwtQ8hyuGM2SL+oKzBj6e9ae4BJq4V0vjkbea4X+H8aAHRtdMU05rn
 VF3w==
X-Gm-Message-State: AGi0PubMKlesd+1fIJwWdrd2ZD0m8il+Gi4aw82h8QpYsPlhbjtykPZs
 HLnm2N3UBgocYfw0hYRPILqVj6gjPghFAg4zTI2jQvEpEW8=
X-Google-Smtp-Source: APiQypKNsq8dfj3Z8RH5bdgcicieddqPmTshwI75fCBbUyCmuL4XBnq8fcrfqrydCJ54WurXsjvdZM0lpXMNSpe78ag=
X-Received: by 2002:a05:600c:2645:: with SMTP id
 5mr3731071wmy.168.1588263038082; 
 Thu, 30 Apr 2020 09:10:38 -0700 (PDT)
MIME-Version: 1.0
References: <1587208075-2462-1-git-send-email-nelson.chu@sifive.com>
In-Reply-To: <1587208075-2462-1-git-send-email-nelson.chu@sifive.com>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Fri, 1 May 2020 00:10:26 +0800
Message-ID: <CA+yXCZA09cjPhWtN8Q0UcZkEbSWG1z2yUF8r4ZCEMnq+P8r-qQ@mail.gmail.com>
Subject: Re: [PATCH 0/7] RISC-V: Support version controling for ISA standard
 extensions and CSR
To: Nelson Chu <nelson.chu@sifive.com>
Cc: Binutils <binutils@sourceware.org>, gdb-patches@sourceware.org, 
 Alex Bradbury <asb@lowrisc.org>, Kito Cheng <kito.cheng@sifive.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2020 16:10:40 -0000

>
> * -misa-spec =3D [2p0|2p1|2p2|20190608|20191213]
> You can simply choose the ISA spec by this option, and then assembler wil=
l set
> the version for the standard extensions if you don=E2=80=99t set in the E=
LF arch
> attributes or -march option.

Could you change this into 2.0|2.1|... instead of 2p0|2p1|... ?
Unlike arch string has specified by spec, it must use `p` instead of `.`.
so I think there is no necessary to use `p` here.

> * --with-isa-spec =3D [2p0|2p1|2p2|20190608|20191213]
> The syntax is same as -misa-spec option.  Assembler will check this if
> -misa-spec option isn=E2=80=99t set.

Same comment as -misa-spec.

> * -mpriv-spec=3D[1p9|1p9p1|1p10|1p11]
> This is used to set the privileged spec=E2=80=99s version, and we can dec=
ide whether
> the CSR is valid or not.

Change to 1.9 instead of 1p9.

>
> =3D=3D=3D New Default Configure Option =3D=3D=3D
>
> * --with-priv-spec =3D [1p9|1p9p1|1p10|1p11]

Same comment as -mpriv-spec=3D