From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14199 invoked by alias); 18 Sep 2013 06:50:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14189 invoked by uid 89); 18 Sep 2013 06:50:45 -0000 Received: from mail-vc0-f175.google.com (HELO mail-vc0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 18 Sep 2013 06:50:45 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.5 required=5.0 tests=AWL,BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,NO_RELAYS autolearn=no version=3.3.2 X-HELO: mail-vc0-f175.google.com Received: by mail-vc0-f175.google.com with SMTP id ia10so4810760vcb.20 for ; Tue, 17 Sep 2013 23:50:43 -0700 (PDT) X-Received: by 10.220.91.16 with SMTP id k16mr5668109vcm.21.1379487043251; Tue, 17 Sep 2013 23:50:43 -0700 (PDT) MIME-Version: 1.0 Reply-To: pat.pannuto@gmail.com Received: by 10.58.144.101 with HTTP; Tue, 17 Sep 2013 23:50:22 -0700 (PDT) From: Pat Pannuto Date: Wed, 18 Sep 2013 06:50:00 -0000 Message-ID: Subject: [PATCH] Print thread name when executing thread commands To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=047d7b343f1a2f71d104e6a2db0f X-SW-Source: 2013-09/txt/msg00563.txt.bz2 --047d7b343f1a2f71d104e6a2db0f Content-Type: text/plain; charset=ISO-8859-1 Content-length: 870 Currently the thread family of commands only prints the thread ID and PID. GDB also has access to the thread's name, which is often an easier way of quickly identifying a thread. This simple patch uses the same mechanism as `info threads' to get the name of a thread and add it to the thread identifier line when it's printed. I wrapped the name in []'s to offset it and make it visually distinct from the ()'s that wrap the other thread information. I'm not at all attached to this look, just looked best to me. Diff should be from current cvs. This is my first patch to GDB, if I messed something up don't hesitate to yell at me. Bonus: solves my old SO question: http://stackoverflow.com/questions/12679339/make-gdb-show-thread-names-on-apply-all-operations -Pat -- Pat Pannuto NSF/NDSEG/Qualcomm Fellow Computer Engineering University of Michigan 248.990.4548 --047d7b343f1a2f71d104e6a2db0f Content-Type: application/octet-stream; name="print_thread_names.ChangeLog" Content-Disposition: attachment; filename="print_thread_names.ChangeLog" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hlq6x9ct0 Content-length: 212 MjAxMy0wOS0xOCAgUGF0IFBhbm51dG8gPHBhdC5wYW5udXRvQGdtYWlsLmNv bT4KCgkqIHRocmVhZC5jOiBQcmludCB0aHJlYWQgbmFtZSBhcyB3ZWxsIGFz IElEIG51bWJlciBhbmQgUElEIHdoZW4KCWV4ZWN1dGluZyB0aGUgdGhyZWFk IGZhbWlseSBvZiBjb21tYW5kcwoK --047d7b343f1a2f71d104e6a2db0f Content-Type: application/octet-stream; name="print_thread_names.diff" Content-Disposition: attachment; filename="print_thread_names.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hlq6xf1h1 Content-length: 2054 SW5kZXg6IGdkYi90aHJlYWQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL3RocmVhZC5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjE1NwpkaWZmIC11IC1wIC1yMS4xNTcgdGhyZWFkLmMK LS0tIGdkYi90aHJlYWQuYwkxNyBTZXAgMjAxMyAxODoyNjozOSAtMDAwMAkx LjE1NworKysgZ2RiL3RocmVhZC5jCTE4IFNlcCAyMDEzIDA2OjMzOjI5IC0w MDAwCkBAIC0xMjU1LDEwICsxMjU1LDE0IEBAIHRocmVhZF9hcHBseV9hbGxf Y29tbWFuZCAoY2hhciAqY21kLCBpbnQKICAgICAgIGZvciAoayA9IDA7IGsg IT0gaTsgaysrKQogICAgICAgICBpZiAodGhyZWFkX2FsaXZlICh0cF9hcnJh eVtrXSkpCiAgICAgICAgICAgeworICAgICAgICAgICAgY2hhciogbmFtZTsK ICAgICAgICAgICAgIHN3aXRjaF90b190aHJlYWQgKHRwX2FycmF5W2tdLT5w dGlkKTsKLSAgICAgICAgICAgIHByaW50Zl9maWx0ZXJlZCAoXygiXG5UaHJl YWQgJWQgKCVzKTpcbiIpLCAKKyAgICAgICAgICAgIG5hbWUgPSB0cF9hcnJh eVtrXS0+bmFtZSA/IHRwX2FycmF5W2tdLT5uYW1lCisgICAgICAgICAgICAg ICAgICAgIDogdGFyZ2V0X3RocmVhZF9uYW1lICh0cF9hcnJheVtrXSk7Cisg ICAgICAgICAgICBwcmludGZfZmlsdGVyZWQgKF8oIlxuVGhyZWFkICVkICgl cykgWyVzXTpcbiIpLCAKIAkJCSAgICAgdHBfYXJyYXlba10tPm51bSwKLQkJ CSAgICAgdGFyZ2V0X3BpZF90b19zdHIgKGluZmVyaW9yX3B0aWQpKTsKKwkJ CSAgICAgdGFyZ2V0X3BpZF90b19zdHIgKGluZmVyaW9yX3B0aWQpLAorCQkJ ICAgICBuYW1lKTsKICAgICAgICAgICAgIGV4ZWN1dGVfY29tbWFuZCAoY21k LCBmcm9tX3R0eSk7CiAKICAgICAgICAgICAgIC8qIFJlc3RvcmUgZXhhY3Qg Y29tbWFuZCB1c2VkIHByZXZpb3VzbHkuICAqLwpAQCAtMTMwOCwxMCArMTMx MiwxMiBAQCB0aHJlYWRfYXBwbHlfY29tbWFuZCAoY2hhciAqdGlkbGlzdCwg aW50CiAJd2FybmluZyAoXygiVGhyZWFkICVkIGhhcyB0ZXJtaW5hdGVkLiIp LCBzdGFydCk7CiAgICAgICBlbHNlCiAJeworCSAgY2hhciAqbmFtZTsKIAkg IHN3aXRjaF90b190aHJlYWQgKHRwLT5wdGlkKTsKIAotCSAgcHJpbnRmX2Zp bHRlcmVkIChfKCJcblRocmVhZCAlZCAoJXMpOlxuIiksIHRwLT5udW0sCi0J CQkgICB0YXJnZXRfcGlkX3RvX3N0ciAoaW5mZXJpb3JfcHRpZCkpOworCSAg bmFtZSA9IHRwLT5uYW1lID8gdHAtPm5hbWUgOiB0YXJnZXRfdGhyZWFkX25h bWUgKHRwKTsKKwkgIHByaW50Zl9maWx0ZXJlZCAoXygiXG5UaHJlYWQgJWQg KCVzKSBbJXNdOlxuIiksIHRwLT5udW0sCisJCQkgICB0YXJnZXRfcGlkX3Rv X3N0ciAoaW5mZXJpb3JfcHRpZCksIG5hbWUpOwogCSAgZXhlY3V0ZV9jb21t YW5kIChjbWQsIGZyb21fdHR5KTsKIAogCSAgLyogUmVzdG9yZSBleGFjdCBj b21tYW5kIHVzZWQgcHJldmlvdXNseS4gICovCg== --047d7b343f1a2f71d104e6a2db0f--