From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hLceFsHyN2bWUAcAWB0awg (envelope-from ) for ; Sun, 05 May 2024 16:57:37 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=brasko-net.20230601.gappssmtp.com header.i=@brasko-net.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=0PJ3ym/I; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 45CF51E0C1; Sun, 5 May 2024 16:57:37 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F3B771E092 for ; Sun, 5 May 2024 16:57:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5545F3858D35 for ; Sun, 5 May 2024 20:57:34 +0000 (GMT) Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 3AA4B3858D28 for ; Sun, 5 May 2024 20:57:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3AA4B3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=brasko.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=brasko.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3AA4B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714942637; cv=none; b=m4XzaH2LGOk+8GspBXnb2T5ZeDz+oO1CclksU6aac5bxbrerVWVbtP9qkiJVQ1gyn8GYjvNjHoCi94RcWIXaPmlm/7zkWlIsLOtgbdvUysk7TgJvaHh9Qe1BXIBXC2nAO4FU19tUo5qaPRrHYUcl3AcMHj1NHettLUHyDjrm7o4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714942637; c=relaxed/simple; bh=uvlO0pUwmLlAQ2Os5ZanUDTJK5e4khQ5Na3KyuQYEgs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=tg4T7egn1E6zQ1R3Xw6flGt9zwtdnOjEsuXGscuxb2YF3MQn+t7oUOo+Wq3vBxGeG169x0OVY5XWC8r8TVLmx4VUu0fC2tQDbGXGivd/5Wx0VbW6wMXcyOPWEmN8n9WS8/wdl08H7Q4JZE1m0BiVBKSDg7FwO1vMsB2+7okszCs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-51ffff16400so1556588e87.2 for ; Sun, 05 May 2024 13:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasko-net.20230601.gappssmtp.com; s=20230601; t=1714942632; x=1715547432; darn=sourceware.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=8scIq7QCFI0TMsaM2MpJFzbB+REvtAptYM7rmFrjnz4=; b=0PJ3ym/IACjYhHD6IV1pCM2+ekaeIeJZafnzs+NvNt+NyK3gQ+nhK3MeU+rj0f+zK+ CVXDIqu4lx3TY7aGUGV7P0APdFfMB7BgD5PjKkQoLxEgCsxj7WU0Nhr1hypPFYDP2MED 4JEYlDw9K1JEOWkPuuoibjW2do2nwHe9qM4wCSdNhcD/zMc5Rcdz/0b2NE2iVUkl9/7Y HnJ6vpy/2jFXCULW/dIxuDBXL3p7cLYkclvE6E2vGCC3bYnO2WvVCr2UAwkaQkQHD8+l 5OJAq6A9xKLbb0mCdw7cMswZ+httc5ppDmipAMIxVBluVo/nbGIcy4U1wsXZEzrh+SCB Utyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714942632; x=1715547432; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8scIq7QCFI0TMsaM2MpJFzbB+REvtAptYM7rmFrjnz4=; b=e3oYsBbVOA+DJaD512OW6HTBhtAqmfI5osAQSXyzpTKQ0I6pOkIir7cQct8ShEHrVS 3kngk8UIqWRPHQU1w2A9FZ1m4bRT2mhPA1j0Nl24gLQlOuUPejQy8mcy4f2XDppHcGt6 RQweXDP+pO3bVgNLNbu0MCX/pa+gHvBBIotF90z8E4mNyLlCSjLx7hWYlePWCHK7yUf0 ivctVif33K/821ZqdPiIbelP9lXxx51bXPYEA94v/lT4TITidqXygqPZobODSGF+pZhY fzNQm4FFtAyl/CnQQbDGm/xfs3Gkl12Z4VDme6fhxvy6lhA16bEeFOOOr4CLbsYiZLe6 lwZg== X-Gm-Message-State: AOJu0YzBdbLBa+kahPZcSD2dFEq46Q1KFbb0FEG1sTEnEyfeOOtSSAHZ g7Jp+b6RRhOmld1BZ5KPfLAW021+fsPJ1eTx8PfmKtTcIOlJatF/ZNwNalf8LYzLHN1gv8NKv6o NMs9ok4EfAg5smTBjOIlQgOuB49x/T4rslErm+xIaflhhBxRHWvA= X-Google-Smtp-Source: AGHT+IG44lYMHhAzNDs8HNxkKiUAO+uH9B37ZCwgDPfsZPTUpkdqj8XjbgURvt49jqd2Zi2X8+DS7T3rUUFYML2iVAk= X-Received: by 2002:a05:6512:36cf:b0:51d:4c8a:bbdb with SMTP id e15-20020a05651236cf00b0051d4c8abbdbmr6212910lfs.3.1714942632049; Sun, 05 May 2024 13:57:12 -0700 (PDT) MIME-Version: 1.0 From: Robert Rossi Date: Sun, 5 May 2024 16:57:00 -0400 Message-ID: Subject: Optionally print source code to gdb console window To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="00000000000064f3580617bb3251" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --00000000000064f3580617bb3251 Content-Type: multipart/alternative; boundary="00000000000064f3570617bb324f" --00000000000064f3570617bb324f Content-Type: text/plain; charset="UTF-8" A little history. When using --annotations, gdb did not print the source code to the gdb console window. When using mi with new-ui it does. When I reported this in the past, several people said it was a feature that gdb printed the source code lines to the console. I've had several users of cgdb say they do not want gdb to print the source code to the gdb console window as they can see the code in the code view. I've created and attached a patch that I hope makes it optional to have gdb print the source code to the gdb console window. Could I have some feedback? I've added a new print source option to control printing source code to the gdb console. (gdb) show print source Printing of source code to gdb console is on. You can turn the printing of the source code off as follows. (gdb) set print source off (gdb) When the printing of source code is on, (gdb) r Starting program: /home/bob/rcs/git/gdb/gdb-build/main .... Breakpoint 1, main (argc=1, argv=0x7fffffffe0c8) at test_main.cpp:42 42 { (gdb) n 43 int i = 3; (gdb) n 44 int j = 4; (gdb) n 47 long_func(); When the printing of source code is off, (gdb) r Starting program: /home/bob/rcs/git/gdb/gdb-build/main ... Breakpoint 1, main (argc=1, argv=0x7fffffffe098) at test_main.cpp:42 (gdb) n (gdb) n (gdb) n (gdb) I don't know gdb code well enough to understand if i've disabled functionality beyond what i was hoping to. I'm not sure how to control this from cgdb when using old versions of gdb. I get the following error when i run --ex "set print source off" when starting gdb. Undefined set print command: "source off". Try "help set print". Thanks, Bob Rossi --00000000000064f3570617bb324f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
A little history. When using --annotations, gdb did n= ot print the source code to the gdb console window. When using mi with new-= ui it does. When I reported this in the past, several people said it was a = feature that gdb printed the source code lines to the console.
I've had several users of cgdb say they do not want gdb to= print the source code to the gdb console window as they can see the code i= n the code view.

I've created and attached= a patch that I hope makes it optional to have gdb print the source code to= the gdb console window. Could I have some feedback?

I've added a new print source option to control printing source code= to the gdb console.

(gdb) show print sourcePrinting of source code to gdb console is on.

Yo= u can turn the printing of the source code off as follows.
(g= db) set print source off
(gdb)

When the pr= inting of source code is on,
(gdb) r
Starting program= : /home/bob/rcs/git/gdb/gdb-build/main
....
Breakpo= int 1, main (argc=3D1, argv=3D0x7fffffffe0c8) at test_main.cpp:42
42 =C2= =A0 =C2=A0 =C2=A0{
(gdb) n
43 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0int i =3D 3;
(gdb) n
44 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0int j =3D 4;
(gdb) n
47 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0long_func();

When the printing of source= code is off,
(gdb) r
Starting program: /home/bob/rcs/git/gdb/= gdb-build/main
...
Breakpoint 1, main (argc=3D1, argv=3D0x7fffffffe0= 98) at test_main.cpp:42
(gdb) n
(gdb) n
(gdb) n
(gdb)

I don't know gdb code well enough to understand if= i've disabled functionality
beyond what i was hoping to.
=

I'm not sure how to control this from cgdb wh= en using old versions of gdb.
I get the following error when i ru= n --ex "set print source off" when starting gdb.
Un= defined set print command: "source off".=C2=A0 Try "help set= print".

Thanks,
Bob Rossi
--00000000000064f3570617bb324f-- --00000000000064f3580617bb3251 Content-Type: text/x-patch; charset="US-ASCII"; name="sourceprint.diff" Content-Disposition: attachment; filename="sourceprint.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvu0itk80 ZGlmZiAtdXJOcCBnZGItMTQuMi5vcmlnL2dkYi9zdGFjay5jIGdkYi0xNC4yL2dkYi9zdGFjay5j Ci0tLSBnZGItMTQuMi5vcmlnL2dkYi9zdGFjay5jCTIwMjQtMDMtMDMgMDA6NTU6MDAuMDAwMDAw MDAwIC0wNTAwCisrKyBnZGItMTQuMi9nZGIvc3RhY2suYwkyMDI0LTA1LTA1IDExOjI3OjA3Ljcz NTU3NjYyNCAtMDQwMApAQCAtMTE2MSw3ICsxMTYxLDkgQEAgcHJpbnRfZnJhbWVfaW5mbyAoY29u c3QgZnJhbWVfcHJpbnRfb3B0aQogCSAgICAgIHVpb3V0LT50ZXh0ICgiXHQiKTsKIAkgICAgfQog Ci0JICBwcmludF9zb3VyY2VfbGluZXMgKHNhbC5zeW10YWIsIHNhbC5saW5lLCBzYWwubGluZSAr IDEsIDApOworICAgICAgCisgICAgICAgICAgaWYgKG9wdHMuc291cmNlcHJpbnQpCisgICAgICAg ICAgICAgIHByaW50X3NvdXJjZV9saW5lcyAoc2FsLnN5bXRhYiwgc2FsLmxpbmUsIHNhbC5saW5l ICsgMSwgMCk7CiAJfQogCiAgICAgICAvKiBJZiBkaXNhc3NlbWJsZS1uZXh0LWxpbmUgaXMgc2V0 IHRvIG9uIGFuZCB0aGVyZSBpcyBsaW5lIGRlYnVnCmRpZmYgLXVyTnAgZ2RiLTE0LjIub3JpZy9n ZGIvdmFscHJpbnQuYyBnZGItMTQuMi9nZGIvdmFscHJpbnQuYwotLS0gZ2RiLTE0LjIub3JpZy9n ZGIvdmFscHJpbnQuYwkyMDI0LTAzLTAzIDAwOjU1OjAwLjAwMDAwMDAwMCAtMDUwMAorKysgZ2Ri LTE0LjIvZ2RiL3ZhbHByaW50LmMJMjAyNC0wNS0wNSAxMToyNDozMi40NDc1MTE4MzQgLTA0MDAK QEAgLTExMyw2ICsxMTMsNyBAQCBzdHJ1Y3QgdmFsdWVfcHJpbnRfb3B0aW9ucyB1c2VyX3ByaW50 X29wCiAgIHRydWUsCQkJCS8qIGFkZHJlc3NwcmludCAqLwogICBmYWxzZSwJCQkvKiBuaWJibGVz cHJpbnQgKi8KICAgZmFsc2UsCQkJLyogb2JqZWN0cHJpbnQgKi8KKyAgdHJ1ZSwJICAgIAkJLyog c291cmNlcHJpbnQgKi8KICAgUFJJTlRfTUFYX0RFRkFVTFQsCQkvKiBwcmludF9tYXggKi8KICAg UFJJTlRfTUFYX0NIQVJTX0RFRkFVTFQsCS8qIHByaW50X21heF9jaGFycyAqLwogICAxMCwJCQkJ LyogcmVwZWF0X2NvdW50X3RocmVzaG9sZCAqLwpAQCAtMjg3OCw2ICsyODc5LDE2IEBAIFByaW50 aW5nIG9mIEMrKyB2aXJ0dWFsIGZ1bmN0aW9uIHRhYmxlcwogCSAgICAgIHZhbHVlKTsKIH0KIAor LyogQ29udHJvbHMgcHJpbnRpbmcgb2Ygc291cmNlIGNvZGUuICAqLworc3RhdGljIHZvaWQKK3No b3dfc291cmNlcHJpbnQgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBpbnQgZnJvbV90dHksCisJCXN0 cnVjdCBjbWRfbGlzdF9lbGVtZW50ICpjLCBjb25zdCBjaGFyICp2YWx1ZSkKK3sKKyAgZ2RiX3By aW50ZiAoZmlsZSwgXygiXAorUHJpbnRpbmcgb2Ygc291cmNlIGNvZGUgdG8gZ2RiIGNvbnNvbGUg aXMgJXMuXG4iKSwKKwkgICAgICB2YWx1ZSk7Cit9CisKIC8qIENvbnRyb2xzIGxvb2tpbmcgdXAg YW4gb2JqZWN0J3MgZGVyaXZlZCB0eXBlIHVzaW5nIHdoYXQgd2UgZmluZCBpbgogICAgaXRzIHZ0 YWJsZXMuICAqLwogc3RhdGljIHZvaWQKQEAgLTMwODgsNiArMzA5OSwxNCBAQCBwcmV0dHktcHJp bnRlcnMgZm9yIHRoYXQgdmFsdWUuIikKICAgICBOXygiU2hvdyBwcmludGluZyBvZiBDKysgdmly dHVhbCBmdW5jdGlvbiB0YWJsZXMuIiksCiAgICAgTlVMTCwgLyogaGVscF9kb2MgKi8KICAgfSwK KyAgYm9vbGVhbl9vcHRpb25fZGVmIHsKKyAgICAic291cmNlIiwKKyAgICBbXSAodmFsdWVfcHJp bnRfb3B0aW9ucyAqb3B0KSB7IHJldHVybiAmb3B0LT5zb3VyY2VwcmludDsgfSwKKyAgICBzaG93 X3NvdXJjZXByaW50LCAvKiBzaG93X2NtZF9jYiAqLworICAgIE5fKCJTZXQgcHJpbnRpbmcgb2Yg c291cmNlIGNvZGUgdG8gZ2RiIGNvbnNvbGUuIiksCisgICAgTl8oIlNob3cgcHJpbnRpbmcgb2Yg c291cmNlIGNvZGUgdG8gZ2RiIGNvbnNvbGUuIiksCisgICAgTlVMTCwgLyogaGVscF9kb2MgKi8K KyAgfSwKIH07CiAKIC8qIFNlZSB2YWxwcmludC5oLiAgKi8KZGlmZiAtdXJOcCBnZGItMTQuMi5v cmlnL2dkYi92YWxwcmludC5oIGdkYi0xNC4yL2dkYi92YWxwcmludC5oCi0tLSBnZGItMTQuMi5v cmlnL2dkYi92YWxwcmludC5oCTIwMjQtMDMtMDMgMDA6NTU6MDAuMDAwMDAwMDAwIC0wNTAwCisr KyBnZGItMTQuMi9nZGIvdmFscHJpbnQuaAkyMDI0LTA1LTA1IDExOjE2OjIyLjQxODg1NjA4NyAt MDQwMApAQCAtNjIsNiArNjIsOSBAQCBzdHJ1Y3QgdmFsdWVfcHJpbnRfb3B0aW9ucwogICAgICBp biBpdHMgdnRhYmxlcy4gICovCiAgIGJvb2wgb2JqZWN0cHJpbnQ7CiAKKyAgLyogQ29udHJvbHMg cHJpbnRpbmcgb2Ygc291cmNlIHRvIGNvbnNvbGUuICAqLworICBib29sIHNvdXJjZXByaW50Owor CiAgIC8qIE1heGltdW0gbnVtYmVyIG9mIGVsZW1lbnRzIHRvIHByaW50IGZvciB2ZWN0b3IgY29u dGVudHMsIG9yIFVJTlRfTUFYCiAgICAgIGZvciBubyBsaW1pdC4gIE5vdGUgdGhhdCAic2V0IHBy aW50IGVsZW1lbnRzIDAiIHN0b3JlcyBVSU5UX01BWCBpbgogICAgICBwcmludF9tYXgsIHdoaWNo IGRpc3BsYXlzIGluIGEgc2hvdyBjb21tYW5kIGFzICJ1bmxpbWl0ZWQiLiAgKi8K --00000000000064f3580617bb3251--