From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OraBO3pXOWZX7QgAWB0awg (envelope-from ) for ; Mon, 06 May 2024 18:19:38 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=brasko-net.20230601.gappssmtp.com header.i=@brasko-net.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=fFNsODAk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E31F61E0C1; Mon, 6 May 2024 18:19:38 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A07DE1E092 for ; Mon, 6 May 2024 18:19:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7434D385829B for ; Mon, 6 May 2024 22:19:35 +0000 (GMT) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 0CDC03858D1E for ; Mon, 6 May 2024 22:19:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CDC03858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=brasko.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=brasko.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CDC03858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715033956; cv=none; b=q1nhDcoR2Km2yvzezwCrS55HUbGLMIhITf/a1JdL3WF1hTgRSLjP4Pv45c8D71XZhgzhjfGn3YDRYXhWnxar0DnhlDPDesbn/WgQB7NyHrSwXUvxlIJMLbkNlQElQyzXbSA2cIRwp0si/oxlAqVx4SHZXlxenPM5rR9HueKvWEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715033956; c=relaxed/simple; bh=L7uevSv1cv3z7EIRWepMpb5dnl8+27oNt8MGeHWfbPU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Q3ph8Ob2COA82Ttv32NvshlgZrjdU6x4E0O+d0wki8ThbXOBtAdTrnSxWFDNmCFvfANTfUn5eTlasS5/g/DKcrm5HJ3qRrH4M0kXh6hc0m4oW+VBdl9Zk/kfaAaqUEBSMLGqe6gBUTWjkRgV0rjkGwnJ/coK470c5ieV0yM6Kzg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-51f45104ef0so2652030e87.3 for ; Mon, 06 May 2024 15:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasko-net.20230601.gappssmtp.com; s=20230601; t=1715033951; x=1715638751; darn=sourceware.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=xP27P72VOBbAfQgakm+riyTVDRtWHRXXn9+QXvzSSRg=; b=fFNsODAkw+HQHxFAm8JZ6O/jk/CWKA7h9dZCxZ/+hII7I/PE7XGoABruLg3t/FTOu9 Sngzzt1j0JZRfYvC6F/mUeUgJ8gdRPJ6CWnRhYmT06gSlRhlztVRCNafLsLL4qnUrl9x CnVSsDgaM42+2AjQ8EEJx+bIxT1iPVuRY+AwfTpNKIt+86afN5HG3Y+P2VkdkPt79uKa 2LQUkXX2epJJXyC6genUA4be4k3bqzaksVM/ChR8uggUT96CMA/CEIZ9uHwOl//HF/CA DKbNR91USxwmjH0oC1DknCbSoS4bwkUF0+8cqlIl7GCozTNu2ThrLvqitt7ZXfeQWR2K AHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715033951; x=1715638751; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xP27P72VOBbAfQgakm+riyTVDRtWHRXXn9+QXvzSSRg=; b=I71siu7jOaAmvZiEKwzOFwM49oE2EDwswplXNOtUHi+bmb2m0vjIgi7ra13GuhVsYO hYrC+QGK9xfiecaud0/1uqFAmr+k8YugOH42dT/7m6O/yOJF9xUPJlPNr+jV0KJO+JTb DWI4Ay+bkI5K0BNbirfZ/apy70mey5PdvPO/hVQJ6mvd/8dQw/PSLFTHnApOwoET7B96 8Wl4vydDe9rWYmUeC2PIsqYvzDrngqpIB1eY1OkItI7DpeEqd1Y/b8/ePc3LvGSgG4s0 s8Qvu4cAgjw20CV0lhNyZ0JUrq2lE5SUueyQc3+6EjpIbPIDAO2BTeqD7vJq/fGePGs2 hjcA== X-Gm-Message-State: AOJu0Yz63qRAaw6GXRNMdF6xUhMnxy4NhBBCc000RYlOCQIw27vCeFbP hI+tJXU/2A3PIitWVSJ/eHAdcfpV+sT0OspHMjP3b96xArdwRzYBiREHrk8/ZCXe7rfpJChPo3s 3N0H72WxqNDT50B9XeaO7XKL+8c9F8GA5AgA3d8kFQ6hj2YIu X-Google-Smtp-Source: AGHT+IGIB7sPU84ztnwsg9pgql5WzgfeagPnc3EVxCO5Iy9lp9ipRSR4qlqtf/gkUyeW0Tb8RyaSrae/bswBJ6mHIjw= X-Received: by 2002:a05:6512:10c7:b0:51e:e703:c878 with SMTP id k7-20020a05651210c700b0051ee703c878mr4513777lfg.14.1715033951397; Mon, 06 May 2024 15:19:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Robert Rossi Date: Mon, 6 May 2024 18:18:59 -0400 Message-ID: Subject: Re: Optionally print source code to gdb console window To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="0000000000007421660617d075c8" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --0000000000007421660617d075c8 Content-Type: multipart/alternative; boundary="0000000000007421640617d075c6" --0000000000007421640617d075c6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I got an automated email saying I broke a test. This updated patch fixes the test and updates the code to the GNU standard, hopefully. Thanks, Bob Rossi On Sun, May 5, 2024 at 4:57=E2=80=AFPM Robert Rossi wrote: > A little history. When using --annotations, gdb did not print the source > code to the gdb console window. When using mi with new-ui it does. When I > reported this in the past, several people said it was a feature that gdb > printed the source code lines to the console. > > I've had several users of cgdb say they do not want gdb to print the > source code to the gdb console window as they can see the code in the cod= e > view. > > I've created and attached a patch that I hope makes it optional to have > gdb print the source code to the gdb console window. Could I have some > feedback? > > I've added a new print source option to control printing source code to > the gdb console. > > (gdb) show print source > Printing of source code to gdb console is on. > > You can turn the printing of the source code off as follows. > (gdb) set print source off > (gdb) > > When the printing of source code is on, > (gdb) r > Starting program: /home/bob/rcs/git/gdb/gdb-build/main > .... > Breakpoint 1, main (argc=3D1, argv=3D0x7fffffffe0c8) at test_main.cpp:42 > 42 { > (gdb) n > 43 int i =3D 3; > (gdb) n > 44 int j =3D 4; > (gdb) n > 47 long_func(); > > When the printing of source code is off, > (gdb) r > Starting program: /home/bob/rcs/git/gdb/gdb-build/main > ... > Breakpoint 1, main (argc=3D1, argv=3D0x7fffffffe098) at test_main.cpp:42 > (gdb) n > (gdb) n > (gdb) n > (gdb) > > I don't know gdb code well enough to understand if i've disabled > functionality > beyond what i was hoping to. > > I'm not sure how to control this from cgdb when using old versions of gdb= . > I get the following error when i run --ex "set print source off" when > starting gdb. > Undefined set print command: "source off". Try "help set print". > > Thanks, > Bob Rossi > --0000000000007421640617d075c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I got an automated email saying I broke a test.
=

This updated patch fixes the test and updates the code = to the GNU standard, hopefully.

Thanks,
= Bob Rossi


On Sun, May 5, 2024 at 4:57=E2=80=AFPM R= obert Rossi <bob@brasko.net> wr= ote:
A little history. When using --annotations, gdb did not print th= e source code to the gdb console window. When using mi with new-ui it does.= When I reported this in the past, several people said it was a feature tha= t gdb printed the source code lines to the console.

I've had several users of cgdb say they do not want gdb to print the = source code to the gdb console window as they can see the code in the code = view.

I've created and attached a patch th= at I hope makes it optional to have gdb print the source code to the gdb co= nsole window. Could I have some feedback?

I've= added a new print source option to control printing source code to the gdb= console.

(gdb) show print source
Printing = of source code to gdb console is on.

You can turn = the printing of the source code off as follows.
(gdb) set pri= nt source off
(gdb)

When the printing of s= ource code is on,
(gdb) r
Starting program: /home/bob= /rcs/git/gdb/gdb-build/main
....
Breakpoint 1, main= (argc=3D1, argv=3D0x7fffffffe0c8) at test_main.cpp:42
42 =C2=A0 =C2=A0 = =C2=A0{
(gdb) n
43 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int i =3D = 3;
(gdb) n
44 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int j =3D 4;(gdb) n
47 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0long_func();

When the printing of source code is off,
(gdb) r=
Starting program: /home/bob/rcs/git/gdb/gdb-build/main
...
Break= point 1, main (argc=3D1, argv=3D0x7fffffffe098) at test_main.cpp:42
(gdb= ) n
(gdb) n
(gdb) n
(gdb)

I don'= t know gdb code well enough to understand if i've disabled functionalit= y
beyond what i was hoping to.

I'= ;m not sure how to control this from cgdb when using old versions of gdb.
I get the following error when i run --ex "set print source o= ff" when starting gdb.
Undefined set print command: &quo= t;source off".=C2=A0 Try "help set print".
Thanks,
Bob Rossi
--0000000000007421640617d075c6-- --0000000000007421660617d075c8 Content-Type: text/x-patch; charset="US-ASCII"; name="sourceprint-round2.diff" Content-Disposition: attachment; filename="sourceprint-round2.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvviwzfj0 ZGlmZiAtLWdpdCBhL2dkYi9zdGFjay5jIGIvZ2RiL3N0YWNrLmMKaW5kZXggYzIzMjNlMTcyNmQu LmE5Zjk2NzExM2Y2IDEwMDY0NAotLS0gYS9nZGIvc3RhY2suYworKysgYi9nZGIvc3RhY2suYwpA QCAtMTE1NCw3ICsxMTU0LDggQEAgZG9fcHJpbnRfZnJhbWVfaW5mbyAoc3RydWN0IHVpX291dCAq dWlvdXQsIGNvbnN0IGZyYW1lX3ByaW50X29wdGlvbnMgJmZwX29wdHMsCiAJICAgICAgdWlvdXQt PnRleHQgKCJcdCIpOwogCSAgICB9CiAKLQkgIHByaW50X3NvdXJjZV9saW5lcyAoc2FsLnN5bXRh Yiwgc2FsLmxpbmUsIHNhbC5saW5lICsgMSwgMCk7CisJICBpZiAob3B0cy5zb3VyY2VwcmludCkK KwkgICAgcHJpbnRfc291cmNlX2xpbmVzIChzYWwuc3ltdGFiLCBzYWwubGluZSwgc2FsLmxpbmUg KyAxLCAwKTsKIAl9CiAKICAgICAgIC8qIElmIGRpc2Fzc2VtYmxlLW5leHQtbGluZSBpcyBzZXQg dG8gb24gYW5kIHRoZXJlIGlzIGxpbmUgZGVidWcKZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUv Z2RiLmJhc2Uvb3B0aW9ucy5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL29wdGlvbnMuZXhw CmluZGV4IDg0MWU2MDM3NjRjLi5hYzA5NDljZDA4NCAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0 ZS9nZGIuYmFzZS9vcHRpb25zLmV4cAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL29wdGlv bnMuZXhwCkBAIC0xODIsNiArMTgyLDcgQEAgcHJvY193aXRoX3ByZWZpeCB0ZXN0LXByaW50IHt7 cHJlZml4ICIifX0gewogCSItcHJldHR5IgogCSItcmF3LXZhbHVlcyIKIAkiLXJlcGVhdHMiCisJ Ii1zb3VyY2UiCiAJIi1zdGF0aWMtbWVtYmVycyIKIAkiLXN5bWJvbCIKIAkiLXVuaW9uIgpkaWZm IC0tZ2l0IGEvZ2RiL3ZhbHByaW50LmMgYi9nZGIvdmFscHJpbnQuYwppbmRleCBkYjhhZmZlYjQ3 YS4uNGIxNzgyODIwNTAgMTAwNjQ0Ci0tLSBhL2dkYi92YWxwcmludC5jCisrKyBiL2dkYi92YWxw cmludC5jCkBAIC0xMTQsNiArMTE0LDcgQEAgc3RydWN0IHZhbHVlX3ByaW50X29wdGlvbnMgdXNl cl9wcmludF9vcHRpb25zID0KICAgdHJ1ZSwJCQkJLyogYWRkcmVzc3ByaW50ICovCiAgIGZhbHNl LAkJCS8qIG5pYmJsZXNwcmludCAqLwogICBmYWxzZSwJCQkvKiBvYmplY3RwcmludCAqLworICB0 cnVlLAkJCQkvKiBzb3VyY2VwcmludCAqLwogICBQUklOVF9NQVhfREVGQVVMVCwJCS8qIHByaW50 X21heCAqLwogICBQUklOVF9NQVhfQ0hBUlNfREVGQVVMVCwJLyogcHJpbnRfbWF4X2NoYXJzICov CiAgIDEwLAkJCQkvKiByZXBlYXRfY291bnRfdGhyZXNob2xkICovCkBAIC0yODczLDYgKzI4NzQs MTYgQEAgUHJpbnRpbmcgb2YgQysrIHZpcnR1YWwgZnVuY3Rpb24gdGFibGVzIGlzICVzLlxuIiks CiAJICAgICAgdmFsdWUpOwogfQogCisvKiBDb250cm9scyBwcmludGluZyBvZiBzb3VyY2UgY29k ZS4gICovCitzdGF0aWMgdm9pZAorc2hvd19zb3VyY2VwcmludCAoc3RydWN0IHVpX2ZpbGUgKmZp bGUsIGludCBmcm9tX3R0eSwKKwkJc3RydWN0IGNtZF9saXN0X2VsZW1lbnQgKmMsIGNvbnN0IGNo YXIgKnZhbHVlKQoreworICBnZGJfcHJpbnRmIChmaWxlLCBfKCJcCitQcmludGluZyBvZiBzb3Vy Y2UgY29kZSB0byBnZGIgY29uc29sZSBpcyAlcy5cbiIpLAorCSAgICAgIHZhbHVlKTsKK30KKwog LyogQ29udHJvbHMgbG9va2luZyB1cCBhbiBvYmplY3QncyBkZXJpdmVkIHR5cGUgdXNpbmcgd2hh dCB3ZSBmaW5kIGluCiAgICBpdHMgdnRhYmxlcy4gICovCiBzdGF0aWMgdm9pZApAQCAtMzA4Myw2 ICszMDk0LDE0IEBAIHByZXR0eS1wcmludGVycyBmb3IgdGhhdCB2YWx1ZS4iKQogICAgIE5fKCJT aG93IHByaW50aW5nIG9mIEMrKyB2aXJ0dWFsIGZ1bmN0aW9uIHRhYmxlcy4iKSwKICAgICBOVUxM LCAvKiBoZWxwX2RvYyAqLwogICB9LAorICBib29sZWFuX29wdGlvbl9kZWYgeworICAgICJzb3Vy Y2UiLAorICAgIFtdICh2YWx1ZV9wcmludF9vcHRpb25zICpvcHQpIHsgcmV0dXJuICZvcHQtPnNv dXJjZXByaW50OyB9LAorICAgIHNob3dfc291cmNlcHJpbnQsIC8qIHNob3dfY21kX2NiICovCisg ICAgTl8oIlNldCBwcmludGluZyBvZiBzb3VyY2UgY29kZSB0byBnZGIgY29uc29sZS4iKSwKKyAg ICBOXygiU2hvdyBwcmludGluZyBvZiBzb3VyY2UgY29kZSB0byBnZGIgY29uc29sZS4iKSwKKyAg ICBOVUxMLCAvKiBoZWxwX2RvYyAqLworICB9LAogfTsKIAogLyogU2VlIHZhbHByaW50LmguICAq LwpkaWZmIC0tZ2l0IGEvZ2RiL3ZhbHByaW50LmggYi9nZGIvdmFscHJpbnQuaAppbmRleCA0ZjE5 NGI3NzAwOC4uYzQ2NzJjMDNhOWYgMTAwNjQ0Ci0tLSBhL2dkYi92YWxwcmludC5oCisrKyBiL2dk Yi92YWxwcmludC5oCkBAIC02Miw2ICs2Miw5IEBAIHN0cnVjdCB2YWx1ZV9wcmludF9vcHRpb25z CiAgICAgIGluIGl0cyB2dGFibGVzLiAgKi8KICAgYm9vbCBvYmplY3RwcmludDsKIAorICAvKiBD b250cm9scyBwcmludGluZyBvZiBzb3VyY2UgdG8gY29uc29sZS4gICovCisgIGJvb2wgc291cmNl cHJpbnQ7CisKICAgLyogTWF4aW11bSBudW1iZXIgb2YgZWxlbWVudHMgdG8gcHJpbnQgZm9yIHZl Y3RvciBjb250ZW50cywgb3IgVUlOVF9NQVgKICAgICAgZm9yIG5vIGxpbWl0LiAgTm90ZSB0aGF0 ICJzZXQgcHJpbnQgZWxlbWVudHMgMCIgc3RvcmVzIFVJTlRfTUFYIGluCiAgICAgIHByaW50X21h eCwgd2hpY2ggZGlzcGxheXMgaW4gYSBzaG93IGNvbW1hbmQgYXMgInVubGltaXRlZCIuICAqLwo= --0000000000007421660617d075c8--