Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Patrick Palka <patrick@parcs.ath.cx>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
Date: Tue, 23 Jun 2015 14:28:00 -0000	[thread overview]
Message-ID: <CA+C-WL_vwGBBnvRFoQW5CTVi3V5P8W3+0E-c04+UuFNSd33Ekg@mail.gmail.com> (raw)
In-Reply-To: <86zj3qr3at.fsf@gmail.com>

On Tue, Jun 23, 2015 at 8:56 AM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Patrick Palka <patrick@parcs.ath.cx> writes:
>
> Hi Patrick,
>
>> +# A huge number (hopefully larger than INT_MAX)
>> +test_histsize_history_setting "99999999999999999999999999999999999"
>> "unlimited"
>
> This test fails on some targets (32-bit?) as shown in buildbot,
> https://www.sourceware.org/ml/gdb-testers/2015-q2/msg06883.html
>
>  (gdb) show history size
>  The size of the command history is 2147483647.
>  (gdb) FAIL: gdb.base/gdbhistsize-history.exp: histsize=99999999999999999999999999999999999: show history size
>
> --
> Yao (齐尧)


Thanks for the heads up.  I failed to account for targets where
INT_MAX == LONG_MAX.  I have a patch to send.


  reply	other threads:[~2015-06-23 14:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 11:24 [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE Patrick Palka
2015-05-22 11:24 ` [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999] Patrick Palka
2015-05-22 11:57   ` Patrick Palka
2015-05-29  9:32   ` Pedro Alves
2015-06-17 19:18     ` Patrick Palka
2015-06-23 12:56   ` Yao Qi
2015-06-23 14:28     ` Patrick Palka [this message]
2015-05-22 12:30 ` [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE Eli Zaretskii
2015-06-04 15:30   ` Patrick Palka
2015-06-15 14:54     ` Pedro Alves
2015-05-29 11:05 ` Pedro Alves
2015-06-17 18:19 ` Patrick Palka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+C-WL_vwGBBnvRFoQW5CTVi3V5P8W3+0E-c04+UuFNSd33Ekg@mail.gmail.com \
    --to=patrick@parcs.ath.cx \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox