From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19534 invoked by alias); 28 Aug 2014 16:26:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19351 invoked by uid 89); 28 Aug 2014 16:26:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,COMPENSATION,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-pa0-f54.google.com Received: from mail-pa0-f54.google.com (HELO mail-pa0-f54.google.com) (209.85.220.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 28 Aug 2014 16:26:01 +0000 Received: by mail-pa0-f54.google.com with SMTP id fb1so3227234pad.13 for ; Thu, 28 Aug 2014 09:26:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/4LR7pXLHYmoTRYwf0m6JAehjhj+XQL48c0kunEkw8A=; b=G/voD8KPAKAte1GzGUKmZFJwlMO5P0EFrADCa0suZgIEYhk6vwDxB68bWkBygg8qZ7 neklqvFwpsz7qhPfY8aFiAhn013tKRJomixdvk3aTZHguRQheMC32qRbd2dHLctkvujT A6Xptm4HWcsxzwXRvq3gJqyh0ypVG0sm6lSUX2SSWPFw8pi1TLD2R1AFLiVskBpHSBk+ 3RWfxdl0lH+625bYajSWdy+sRU4qpXVEY+CcjRXUFhbrS/EOVY9LBOi0dyIMQsFQcFKf EKuA2lULBh7nSgZtu8QGhhbjPydu7Ewzxd3HK46dkJ3KTUXmZkk6aqVjY5EA6sKdplvd mqCA== X-Gm-Message-State: ALoCoQm0ATQCjVjt2jlrcz7k0NuzfHKG+3xZbp31JprEKANIqtxy0VmgS4zslFGZyjEIWXrhJ/m0 MIME-Version: 1.0 X-Received: by 10.68.233.68 with SMTP id tu4mr7493736pbc.65.1409243159984; Thu, 28 Aug 2014 09:25:59 -0700 (PDT) Received: by 10.70.5.229 with HTTP; Thu, 28 Aug 2014 09:25:59 -0700 (PDT) In-Reply-To: <53FF5534.3050209@redhat.com> References: <1408740286-29326-1-git-send-email-patrick@parcs.ath.cx> <53FF12FF.3020003@redhat.com> <53FF5534.3050209@redhat.com> Date: Thu, 28 Aug 2014 16:26:00 -0000 Message-ID: Subject: Re: [PATCH] Fix the processing of Meta-key commands in TUI From: Patrick Palka To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00624.txt.bz2 On Thu, Aug 28, 2014 at 12:13 PM, Pedro Alves wrote: > On 08/28/2014 03:18 PM, Patrick Palka wrote: >> On Thu, Aug 28, 2014 at 7:31 AM, Pedro Alves wrote: >>> On 08/22/2014 09:44 PM, Patrick Palka wrote: >>>> + >>>> + if (async_command_editing_p && key_is_start_sequence (ch)) >>> >>> I think the key_is_start_sequence check means that we'll >>> fail to compensate in case the sequence if longer than >>> 2 bytes? That is, we'll compensate for the second char, >>> but fail to compensate for the third, because by then, >>> ch will not be a start sequence key. >> >> Yes I think so. I only took into account common 2-byte sequences such >> as Alt_F. I suppose that the check could be removed to account for >> 3+-byte key sequences too, but I haven't thought out the consequences >> of such change. And I'm not sure that readline uses any of such >> sequences. > > It's fine with me to leave this as is, if we add a comment > mentioning this issue. I'll do that and send a revised patch later today. > > Thanks, > Pedro Alves >