From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13717 invoked by alias); 15 May 2015 21:22:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13708 invoked by uid 89); 15 May 2015 21:21:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f54.google.com Received: from mail-oi0-f54.google.com (HELO mail-oi0-f54.google.com) (209.85.218.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 15 May 2015 21:21:58 +0000 Received: by oica37 with SMTP id a37so92262413oic.0 for ; Fri, 15 May 2015 14:21:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=d6yMNAOlkyR3+ix6pEVTsOQia83JAJ+nDEsASWoMZTw=; b=ltyfaFEB3ouct80RcKEIZCcIAwVUixYgX2TFjMPcxvO2TMWwgpchqG8BmcsAC+wiB/ RyurauqQUJcXgltj2+55um/Jrl1RyV5/QqR98FSPFbU/DRaQ1T8C0t6FWsatXU9hf3rk JVlQyQKGrsnfGmXVxohTXPxC6rK45pvxjBuKKG0R2vmd5t8GwnEM/hULlQIiTuH1MU9R 1I4ZLK8tr+0eO3UYbibHTdRX0++IG+YvP/dn3nIb4ojL/s8+RnqrEWXty6IogB5UTcuH aKlfc1o81H1+giE0KVi+I5b3GxOY/nCnMJwX167LXliqsRzyptIn9WYpRRYOtMHeacky tZcQ== X-Gm-Message-State: ALoCoQmmjycpK9lVBSZbLJtDLvm368nTh5BPcyvPg57upLr2buZ74Emkwogvq1QbJPa80Na9tw8I X-Received: by 10.202.49.11 with SMTP id x11mr9473683oix.63.1431724916366; Fri, 15 May 2015 14:21:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.243.232 with HTTP; Fri, 15 May 2015 14:21:35 -0700 (PDT) In-Reply-To: <5556316F.2000808@redhat.com> References: <1431523782-20409-1-git-send-email-patrick@parcs.ath.cx> <55561958.2030105@redhat.com> <55562A28.9050503@redhat.com> <5556316F.2000808@redhat.com> From: Patrick Palka Date: Fri, 15 May 2015 21:22:00 -0000 Message-ID: Subject: Re: [PATCH] [COMMITTED] Fix PR gdb/17820 To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-05/txt/msg00417.txt.bz2 On Fri, May 15, 2015 at 1:48 PM, Pedro Alves wrote: > On 05/15/2015 06:26 PM, Patrick Palka wrote: >> On Fri, May 15, 2015 at 1:17 PM, Pedro Alves wrote: >>> On 05/15/2015 06:09 PM, Patrick Palka wrote: >>>> On Fri, May 15, 2015 at 12:05 PM, Pedro Alves wrote: >>>>> Hi Patrick, >>>>> >>>>> I noticed that the buildbots are showing that this new test is failing: >>>>> >>>>> https://sourceware.org/ml/gdb-testers/2015-q2/msg04164.html >>>>> >>>>> ~~~ >>>>> ============================ >>>>> new FAIL: gdb.base/gdbinit-history.exp: show commands <<2>> >>>>> new FAIL: gdb.base/gdbinit-history.exp: show history size >>>>> new FAIL: gdb.base/gdbinit-history.exp: show history size <<2>> >>>> >>>> Also the tests in this file have duplicate names.. That's undesirable >>>> right? If so I could make the names unique. >>> >>> Yes. I should have spotted that earlier. >>> >>>> Would such a change fall under the "obvious" rule? >>> >>> Not sure, depends on how you would fix it. :-) Apply the test >>> described in MAINTAINERS. :-) >> >> So it will probably not be obvious because of naming preferences. > > Sorry for the trigger-happy pun. I didn't mean to sound > rude or put you off. I certainly do not hate your work. :-) No problem, I had not inferred any rude intentions. > > I was just thinking that someone not familiar with the > testsuite's history might consider obvious to change the test > names one by one, while we avoid that nowadays in some cases > (like described below). Yeah, I was planning on exactly that! > >> >>> >>> There are a couple ways to address that. In cases like >>> this test, where we have a function that called multiple >>> times, the modern way is to use with_test_prefix to wrap the >>> function call or the function body, which then also covers >>> FAILs issued from within gdb_start, etc. >> >> Cool.. I will do something like that. > > Excellent, thanks. > > -- > Pedro Alves >