From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23929 invoked by alias); 14 Nov 2014 19:12:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23919 invoked by uid 89); 14 Nov 2014 19:12:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,COMPENSATION,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-pa0-f53.google.com Received: from mail-pa0-f53.google.com (HELO mail-pa0-f53.google.com) (209.85.220.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 14 Nov 2014 19:12:33 +0000 Received: by mail-pa0-f53.google.com with SMTP id kx10so17857226pab.26 for ; Fri, 14 Nov 2014 11:12:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=239U3o49V39NrS5JTbKxSlEwB6jjpqn/TbxOBz1/HJ4=; b=M4G9yO2wB0HLKGFYg6qRY8as5RQ7U7cE4KjznF1txM/hj273bKnROei+tVUpIDTm2g Zn6lbu3P+Q1nWnhG3geOc4XR943sI+3XLe+PNaJQIC9tFfHLKTtxz7gB/OFXicpFM8Ki PHMhsyWwgXW07ztDtEOjCFqQKOkT0XyV94dLrZYLvkw836C4z2qWndumcMHMNtkiKxjN JCfX2oZiy7DlCNS5Nf1KkEjGoiExQLZ/0S81Y3zBHpDO1AEa19q1E4PkaGxmbX+OS6S9 HP+4SmNViNVpbpNRXKCVuE+4nUplHqAQf0cTri8F03Bu2erfu1fZ6b2EUXCjPHXECnC/ v9rQ== X-Gm-Message-State: ALoCoQloLcCTeERerP6vlB5l810lRZleDnsy5pOHOA9dgirbVonisKLqQnsj2+OxSvVkpro1INLl X-Received: by 10.68.162.100 with SMTP id xz4mr12295087pbb.138.1415992351998; Fri, 14 Nov 2014 11:12:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.70.31.100 with HTTP; Fri, 14 Nov 2014 11:12:11 -0800 (PST) In-Reply-To: <53FF5534.3050209@redhat.com> References: <1408740286-29326-1-git-send-email-patrick@parcs.ath.cx> <53FF12FF.3020003@redhat.com> <53FF5534.3050209@redhat.com> From: Patrick Palka Date: Fri, 14 Nov 2014 19:12:00 -0000 Message-ID: Subject: Re: [PATCH] Fix the processing of Meta-key commands in TUI To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=047d7ba96d9c2590360507d669ae X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00338.txt.bz2 --047d7ba96d9c2590360507d669ae Content-Type: text/plain; charset=UTF-8 Content-length: 1195 On Thu, Aug 28, 2014 at 12:13 PM, Pedro Alves wrote: > On 08/28/2014 03:18 PM, Patrick Palka wrote: >> On Thu, Aug 28, 2014 at 7:31 AM, Pedro Alves wrote: >>> On 08/22/2014 09:44 PM, Patrick Palka wrote: >>>> + >>>> + if (async_command_editing_p && key_is_start_sequence (ch)) >>> >>> I think the key_is_start_sequence check means that we'll >>> fail to compensate in case the sequence if longer than >>> 2 bytes? That is, we'll compensate for the second char, >>> but fail to compensate for the third, because by then, >>> ch will not be a start sequence key. >> >> Yes I think so. I only took into account common 2-byte sequences such >> as Alt_F. I suppose that the check could be removed to account for >> 3+-byte key sequences too, but I haven't thought out the consequences >> of such change. And I'm not sure that readline uses any of such >> sequences. > > It's fine with me to leave this as is, if we add a comment > mentioning this issue. > > Thanks, > Pedro Alves > Attached is the patch that Pedro approved, augmented with a comment describing the potential problem with 3+ byte sequences. I wonder if someone could commit this for me? --047d7ba96d9c2590360507d669ae Content-Type: application/octet-stream; name="0001-Fix-the-processing-of-Meta-key-commands-in-TUI.patch" Content-Disposition: attachment; filename="0001-Fix-the-processing-of-Meta-key-commands-in-TUI.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i2hx9h0g0 Content-length: 6194 RnJvbSAwYTg4ZjllMDI3NzQ0MmQ1ODZkYzhkY2I5MzE2NGQwMmY5MjJmMDcx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXRyaWNrIFBhbGth IDxwYXRyaWNrQHBhcmNzLmF0aC5jeD4KRGF0ZTogRnJpLCAyMiBBdWcgMjAx NCAxNjoyNjo1MSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCB0aGUgcHJv Y2Vzc2luZyBvZiBNZXRhLWtleSBjb21tYW5kcyBpbiBUVUkKClRoaXMgcGF0 Y2ggZml4ZXMgdGhlIGFubm95aW5nIGJ1ZyB3aGVyZSBrZXkgc2VxdWVuY2Vz IHN1Y2ggYXMgQWx0X0Ygb3IKQWx0X0IgKGdvIGZvcndhcmQgb3IgYmFja3dh cmRzIGJ5IGEgd29yZCkgZG8gbm90IGJlaGF2ZSBwcm9tcHRseSBpbiBUVUku CllvdSBoYXZlIHRvIHByZXNzIGEgdGhpcmQga2V5IGluIG9yZGVyIGZvciB0 aGUga2V5IHNlcXVlbmNlIHRvIHJlZ2lzdGVyLgoKVGhpcyBpcyBtb3N0bHkg bmN1cnNlcycgZmF1bHQuICBDYWxsaW5nIHdnZXRjaCgpIG5vcm1hbGx5IGNh dXNlcyBuY3Vyc2VzCnRvIHJlYWQgb25seSBhIHNpbmdsZSBrZXkgZnJvbSBz dGRpbi4gIEhvd2V2ZXIgaWYgdGhlIGtleSByZWFkIGlzIHRoZQpzdGFydC1z ZXF1ZW5jZSBrZXkgKF5bIGEuay5hLiBFU0MpIHRoZW4gd2dldGNoKCkgcmVh ZHMgVFdPIGtleXMgZnJvbQpzdGRpbiwgc3RvcmluZyB0aGUgMm5kIGtleSBp bnRvIGFuIGludGVybmFsIEZJRk8gYnVmZmVyIGFuZCByZXR1cm5pbmcKdGhl IHN0YXJ0LXNlcXVlbmNlIGtleS4gIFRoZSBleHRyYW5lb3VzIHJlYWQgb2Yg dGhlIDJuZCBrZXkgbWFrZXMgdXMKbWlzcyBpdHMgY29ycmVzcG9uZGluZyBz dGRpbiBldmVudCwgc28gdGhlIGV2ZW50IGxvb3AgYmxvY2tzIHVudGlsIGEK dGhpcmQga2V5IGlzIHByZXNzZWQuICBUaGlzIGV4cGxhaW5zIHdoeSBzdWNo IGtleSBzZXF1ZW5jZXMgZG8gbm90CmJlaGF2ZSBwcm9tcHRseSBpbiBUVUku CgpUbyBmaXggdGhpcyBpc3N1ZSwgd2UgbXVzdCBzb21laG93IGNvbXBlbnNh dGUgZm9yIHRoZSBtaXNzZWQgc3RkaW4gZXZlbnQKY29ycmVzcG9uZGluZyB0 byB0aGUgMm5kIGJ5dGUgb2YgYSBrZXkgc2VxdWVuY2UuICBUaGlzIHBhdGNo IGFjaGlldmVzCnRoaXMgYnkgaGFja2luZyAgdXAgdGhlIHN0ZGluIGV2ZW50 IGhhbmRsZXIgdG8gY29uZGl0aW9uYWxseSBleGVjdXRlIHRoZQpyZWFkbGlu ZSBjYWxsYmFjayBtdWx0aXBsZSB0aW1lcyBpbiBhIHJvdy4gIFRoaXMgaXMg ZG9uZSB2aWEgYSBuZXcKZ2xvYmFsIHZhcmlhYmxlLCBjYWxsX3N0ZGluX2V2 ZW50X2hhbmRsZXJfYWdhaW5fcCwgd2hpY2ggaXMgc2V0IGZyb20KdHVpX2dl dGMoKSB3aGVuIHdlIHJlY2VpdmUgYSBzdGFydC1zZXF1ZW5jZSBrZXkgYW5k IG5vdGljZSBleHRyYSBwZW5kaW5nCmlucHV0IGluIHRoZSBuY3Vyc2VzIGJ1 ZmZlci4KClRlc3RlZCBvbiB4ODZfNjQtdW5rbm93bi1saW51eC1nbnUuCgpn ZGIvQ2hhbmdlTG9nOgoKCSogZXZlbnQtdG9wLmggKGNhbGxfc3RkaW5fZXZl bnRfaGFuZGxlcl9hZ2Fpbl9wKTogRGVjbGFyZS4KCSogZXZlbnQtdG9wLmMg KGNhbGxfc3RkaW5fZXZlbnRfaGFuZGxlcl9hZ2Fpbl9wKTogRGVmaW5lLgoJ KHN0ZGluX2V2ZW50X2hhbmRsZXIpOiBVc2UgaXQuCgkqIHR1aS90dWktaW8u YyAodHVpX2dldGMpOiBQcmVwYXJlIHRvIGNhbGwgdGhlIHN0ZGluIGV2ZW50 CgloYW5kbGVyIGFnYWluIGlmIHRoZXJlIGlzIHBlbmRpbmcgaW5wdXQgZm9s bG93aW5nIGEKCXN0YXJ0IHNlcXVlbmNlLgotLS0KIGdkYi9ldmVudC10b3Au YyAgfCAxMyArKysrKysrKysrKystCiBnZGIvZXZlbnQtdG9wLmggIHwgIDEg KwogZ2RiL3R1aS90dWktaW8uYyB8IDI4ICsrKysrKysrKysrKysrKysrKysr KysrKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nZGIvZXZlbnQtdG9wLmMg Yi9nZGIvZXZlbnQtdG9wLmMKaW5kZXggM2Y5ZGVlYy4uOTY1NGEwZiAxMDA2 NDQKLS0tIGEvZ2RiL2V2ZW50LXRvcC5jCisrKyBiL2dkYi9ldmVudC10b3Au YwpAQCAtMTE5LDYgKzExOSwxMSBAQCBpbnQgZXhlY19kb25lX2Rpc3BsYXlf cCA9IDA7CiAgICByZWFkIGNvbW1hbmRzIGZyb20uICAqLwogaW50IGlucHV0 X2ZkOwogCisvKiBVc2VkIGJ5IHRoZSBzdGRpbiBldmVudCBoYW5kbGVyIHRv IGNvbXBlbnNhdGUgZm9yIG1pc3NlZCBzdGRpbiBldmVudHMuCisgICBTZXR0 aW5nIHRoaXMgdG8gYSBub24temVybyB2YWx1ZSBpbnNpZGUgYW4gc3RkaW4g Y2FsbGJhY2sgbWFrZXMgdGhlIGNhbGxiYWNrCisgICBydW4gYWdhaW4uICAq LworaW50IGNhbGxfc3RkaW5fZXZlbnRfaGFuZGxlcl9hZ2Fpbl9wOworCiAv KiBTaWduYWwgaGFuZGxpbmcgdmFyaWFibGVzLiAgKi8KIC8qIEVhY2ggb2Yg dGhlc2UgaXMgYSBwb2ludGVyIHRvIGEgZnVuY3Rpb24gdGhhdCB0aGUgZXZl bnQgbG9vcCB3aWxsCiAgICBpbnZva2UgaWYgdGhlIGNvcnJlc3BvbmRpbmcg c2lnbmFsIGhhcyByZWNlaXZlZC4gIFRoZSByZWFsIHNpZ25hbApAQCAtMzY5 LDcgKzM3NCwxMyBAQCBzdGRpbl9ldmVudF9oYW5kbGVyIChpbnQgZXJyb3Is IGdkYl9jbGllbnRfZGF0YSBjbGllbnRfZGF0YSkKICAgICAgIHF1aXRfY29t bWFuZCAoKGNoYXIgKikgMCwgc3RkaW4gPT0gaW5zdHJlYW0pOwogICAgIH0K ICAgZWxzZQotICAgICgqY2FsbF9yZWFkbGluZSkgKGNsaWVudF9kYXRhKTsK KyAgICB7CisgICAgICBkbworCXsKKwkgIGNhbGxfc3RkaW5fZXZlbnRfaGFu ZGxlcl9hZ2Fpbl9wID0gMDsKKwkgICgqY2FsbF9yZWFkbGluZSkgKGNsaWVu dF9kYXRhKTsKKwl9IHdoaWxlIChjYWxsX3N0ZGluX2V2ZW50X2hhbmRsZXJf YWdhaW5fcCAhPSAwKTsKKyAgICB9CiB9CiAKIC8qIFJlLWVuYWJsZSBzdGRp biBhZnRlciB0aGUgZW5kIG9mIGFuIGV4ZWN1dGlvbiBjb21tYW5kIGluCmRp ZmYgLS1naXQgYS9nZGIvZXZlbnQtdG9wLmggYi9nZGIvZXZlbnQtdG9wLmgK aW5kZXggMmQwNWQ0NS4uYzdiMTIyNCAxMDA2NDQKLS0tIGEvZ2RiL2V2ZW50 LXRvcC5oCisrKyBiL2dkYi9ldmVudC10b3AuaApAQCAtNjEsNiArNjEsNyBA QCBleHRlcm4gdm9pZCAoKmNhbGxfcmVhZGxpbmUpICh2b2lkICopOwogZXh0 ZXJuIHZvaWQgKCppbnB1dF9oYW5kbGVyKSAoY2hhciAqKTsKIGV4dGVybiBp bnQgaW5wdXRfZmQ7CiBleHRlcm4gdm9pZCAoKmFmdGVyX2NoYXJfcHJvY2Vz c2luZ19ob29rKSAodm9pZCk7CitleHRlcm4gaW50IGNhbGxfc3RkaW5fZXZl bnRfaGFuZGxlcl9hZ2Fpbl9wOwogCiBleHRlcm4gdm9pZCBjbGlfY29tbWFu ZF9sb29wICh2b2lkICopOwogCmRpZmYgLS1naXQgYS9nZGIvdHVpL3R1aS1p by5jIGIvZ2RiL3R1aS90dWktaW8uYwppbmRleCA2MDFkMjc4Li5hYTFkMWM3 IDEwMDY0NAotLS0gYS9nZGIvdHVpL3R1aS1pby5jCisrKyBiL2dkYi90dWkv dHVpLWlvLmMKQEAgLTY5MSw3ICs2OTEsMzMgQEAgdHVpX2dldGMgKEZJTEUg KmZwKQogICAgIFRVSV9DTURfV0lOLT5kZXRhaWwuY29tbWFuZF9pbmZvLmN1 cmNoID0gMDsKICAgaWYgKGNoID09IEtFWV9CQUNLU1BBQ0UpCiAgICAgcmV0 dXJuICdcYic7Ci0gIAorCisgIGlmIChhc3luY19jb21tYW5kX2VkaXRpbmdf cCAmJiBrZXlfaXNfc3RhcnRfc2VxdWVuY2UgKGNoKSkKKyAgICB7CisgICAg ICBpbnQgY2hfcGVuZGluZzsKKworICAgICAgbm9kZWxheSAodywgVFJVRSk7 CisgICAgICBjaF9wZW5kaW5nID0gd2dldGNoICh3KTsKKyAgICAgIG5vZGVs YXkgKHcsIEZBTFNFKTsKKworICAgICAgLyogSWYgd2UgaGF2ZSBwZW5kaW5n IGlucHV0IGZvbGxvd2luZyBhIHN0YXJ0IHNlcXVlbmNlLCBjYWxsIHRoZSBz dGRpbgorCSBldmVudCBoYW5kbGVyIGFnYWluIGJlY2F1c2UgbmN1cnNlcyBt YXkgaGF2ZSBhbHJlYWR5IHJlYWQgYW5kIHN0b3JlZAorCSB0aGUgaW5wdXQg aW50byBpdHMgaW50ZXJuYWwgYnVmZmVyLCBtZWFuaW5nIHRoYXQgd2Ugd29u J3QgZ2V0IGFuIHN0ZGluCisJIGV2ZW50IGZvciBpdC4gIElmIHdlIGRvbid0 IGNvbXBlbnNhdGUgZm9yIHRoaXMgbWlzc2VkIHN0ZGluIGV2ZW50LCBrZXkK Kwkgc2VxdWVuY2VzIGFzIEFsdF9GICheW2YpIHdpbGwgbm90IGJlaGF2ZSBw cm9tcHRseS4KKworCSAoV2Ugb25seSBjb21wZW5zYXRlcyBmb3IgdGhlIG1p c3NlZCAybmQgYnl0ZSBvZiBhIGtleSBzZXF1ZW5jZSBiZWNhdXNlCisJIDIt Ynl0ZSBzZXF1ZW5jZXMgYXJlIGJ5IGZhciB0aGUgbW9zdCBjb21tb25seSB1 c2VkLiBuY3Vyc2VzIG1heSBoYXZlCisJIGJ1ZmZlcmVkIGEgbGFyZ2VyLCAz Ky1ieXRlIGtleSBzZXF1ZW5jZSB0aG91Z2ggaXQgcmVtYWlucyB0byBiZSBz ZWVuCisJIHdoZXRoZXIgaXQgaXMgdXNlZnVsIHRvIGNvbXBlbnNhdGUgZm9y IGFsbCB0aGUgYnl0ZXMgb2Ygc3VjaAorCSBzZXF1ZW5jZXMuKSAgKi8KKyAg ICAgIGlmIChjaF9wZW5kaW5nICE9IEVSUikKKwl7CisJICB1bmdldGNoIChj aF9wZW5kaW5nKTsKKwkgIGNhbGxfc3RkaW5fZXZlbnRfaGFuZGxlcl9hZ2Fp bl9wID0gMTsKKwl9CisgICAgfQorCiAgIHJldHVybiBjaDsKIH0KIAotLSAK Mi4yLjAucmMxLjIzLmdmNTcwOTQzCgo= --047d7ba96d9c2590360507d669ae--