Re: [PATCH] [RFC] Sync readline to version 6.3 patchlevel 8

Patrick Palka
2015-05-14T01:40:49Z

On Wed, May 13, 2015 at 8:12 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> This patch syncs our upstream copy of readline to version 6.3
> patchlevel 8.
>
> I basically copied what was done when Jan updated to readline 6.2 in
> 2011: http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html
>
> Specifically, I:
>
> 1. Extracted the readline 6.3 tarball on top of readline/
> 2. Applied patches 1-8 from ftp://ftp.cwru.edu/pub/bash/readline-6.3-patches/
> 3. Omitted all the files in doc/ that were intentionally omitted before.
> 4. Regenerated readline/configure and readline/examples/rlfe/configure
> using autoconf 2.64. No other configure files needed regenerating.
> 5. Reapplied the only local patch since the update to readline 6.2 that
> has not already been applied to readline 6.3, 05942d8a1 ("Fix
> executable indicator in file name completeion on Windows."). This
> particular patch has been applied upstream but readline 6.3 does not
> have it. Whether or not a local patch has already been applied to
> readline 6.3 was determined via manual inspection. (Wasn't too bad
> really.)
>
> The new files to make it into the tree are:
>
> colors.{c,h}
> configure.ac
> parse-colors.{c,h}
> examples/hist_erasedups.c
> examples/hist_purgecmd.c
>
> Deleted files:
>
> configure.in
>
> I've been using this patch locally for a few months now and I've
> experienced only a single regression which has already been preemptively
> fixed by 8900d71e3 ("Explicitly call rl_resize_terminal() in TUI's
> SIGWINCH handler"). Other than that, no issues in either the CLI or the
> TUI, or changes in the testsuite. Though I have only been able to test
> this patch on Linux.

On second inspection it seems I am getting a few anomalous testsuite
failures. I will take a deeper look.