From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96993 invoked by alias); 14 May 2015 01:40:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96984 invoked by uid 89); 14 May 2015 01:40:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f50.google.com Received: from mail-oi0-f50.google.com (HELO mail-oi0-f50.google.com) (209.85.218.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 14 May 2015 01:40:46 +0000 Received: by oica37 with SMTP id a37so45508778oic.0 for ; Wed, 13 May 2015 18:40:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=V76xcE/fakLa0YOc5kj/s3CXtphItSb/pN4qbkK56ZI=; b=bk4kMWqKqM96QJmQgOEUWXoVqh6spNfgZ1ergp3fN+drfu9eqU7Z+QkaJL/wmlfv2h zpiiY9r+oxcvgVZYMHaO6eFimqUfdMrJ4k+s5NLapdJzqjzA42j34zhXCW09Wizp0mcI NGMq9Wl2l8eQIBn7P0HcDLsIjEmquE3mkcAwxNj262w5/8DmynC5jbF71h8NaYsXgIye 4Mt+omaIrB25uC3CkVa06/FXti7yTrrpWx4dGEGErLKT69+4DzZhLrS51c9qrAjrYSWj k76LR/CzTJkn0dyuyaL/WA8+Boj7Dehgu3uB2TrjGSJmBn9WdgxCsv2CFEyLFMuTVTiR KweQ== X-Gm-Message-State: ALoCoQnFBavSvR2awUwrCcc4+8QmNpQgWW3n3SeGhQJkLA5dpctbWqslVaLwzhm5puXdzD0Nz7jD X-Received: by 10.60.148.225 with SMTP id tv1mr1448176oeb.14.1431567644176; Wed, 13 May 2015 18:40:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.243.232 with HTTP; Wed, 13 May 2015 18:40:23 -0700 (PDT) In-Reply-To: <1431562331-20448-1-git-send-email-patrick@parcs.ath.cx> References: <1431562331-20448-1-git-send-email-patrick@parcs.ath.cx> From: Patrick Palka Date: Thu, 14 May 2015 01:40:00 -0000 Message-ID: Subject: Re: [PATCH] [RFC] Sync readline to version 6.3 patchlevel 8 To: "gdb-patches@sourceware.org" Cc: Jan Kratochvil , Patrick Palka Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-05/txt/msg00353.txt.bz2 On Wed, May 13, 2015 at 8:12 PM, Patrick Palka wrote: > This patch syncs our upstream copy of readline to version 6.3 > patchlevel 8. > > I basically copied what was done when Jan updated to readline 6.2 in > 2011: http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html > > Specifically, I: > > 1. Extracted the readline 6.3 tarball on top of readline/ > 2. Applied patches 1-8 from ftp://ftp.cwru.edu/pub/bash/readline-6.3-patches/ > 3. Omitted all the files in doc/ that were intentionally omitted before. > 4. Regenerated readline/configure and readline/examples/rlfe/configure > using autoconf 2.64. No other configure files needed regenerating. > 5. Reapplied the only local patch since the update to readline 6.2 that > has not already been applied to readline 6.3, 05942d8a1 ("Fix > executable indicator in file name completeion on Windows."). This > particular patch has been applied upstream but readline 6.3 does not > have it. Whether or not a local patch has already been applied to > readline 6.3 was determined via manual inspection. (Wasn't too bad > really.) > > The new files to make it into the tree are: > > colors.{c,h} > configure.ac > parse-colors.{c,h} > examples/hist_erasedups.c > examples/hist_purgecmd.c > > Deleted files: > > configure.in > > I've been using this patch locally for a few months now and I've > experienced only a single regression which has already been preemptively > fixed by 8900d71e3 ("Explicitly call rl_resize_terminal() in TUI's > SIGWINCH handler"). Other than that, no issues in either the CLI or the > TUI, or changes in the testsuite. Though I have only been able to test > this patch on Linux. On second inspection it seems I am getting a few anomalous testsuite failures. I will take a deeper look.