From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124732-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 121477 invoked by alias); 27 Jul 2015 18:49:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 121459 invoked by uid 89); 27 Jul 2015 18:49:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2
X-HELO: mail-ob0-f174.google.com
Received: from mail-ob0-f174.google.com (HELO mail-ob0-f174.google.com) (209.85.214.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 27 Jul 2015 18:49:32 +0000
Received: by obbop1 with SMTP id op1so66504134obb.2        for <gdb-patches@sourceware.org>; Mon, 27 Jul 2015 11:49:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc:content-type;        bh=iZaUzA+QQwnnnPnJSOOzDSG9IspfX+k4+XjAWd7ImCE=;        b=Da+dEbAc1piRgAK/I39xkzXvFgmWeW89RVwS9sTRalV3ztWzga/wt46zGeGFxvN0Ye         +fuenvBdZYWFUBLVOH/91nW3SWe/f9iq39DQWevYyD6nP8MtetcwQUepOUPuI0uHR2mX         pHOowYvl7l5WWmn05KNexVq94NG3qzExnmn89rVT3I1uC3n4VlLk91ODKdjhZcrhSKZN         xbeYeK1di2EOLhG0n3utxUx2JJfhhB0pK1soeUNw2ACmPHGBueqS83iDy48qv3sPaGf9         rFr90vNuEXEM0IDDaQQcnUPbalPbCo8xSL+psjzQMhvRtRG2ky7j85bvmct09t1KvKYt         x0BQ==
X-Gm-Message-State: ALoCoQkQFfFSIIXvTOWm7MVjpDYSWn3t+yCYn1FIKMzqtY89B1puF6DlUttkZd7RLDT8fP5+Kc7J
X-Received: by 10.60.47.106 with SMTP id c10mr29002128oen.64.1438022970356; Mon, 27 Jul 2015 11:49:30 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.182.56.202 with HTTP; Mon, 27 Jul 2015 11:49:11 -0700 (PDT)
In-Reply-To: <55B65EAE.5090000@redhat.com>
References: <1438013299-1449-1-git-send-email-patrick@parcs.ath.cx> <CA+C-WL-wNHbKxg95yLtN6V9myY5iqXSWcwOkTmO5ZOjS=x3jnQ@mail.gmail.com> <55B65EAE.5090000@redhat.com>
From: Patrick Palka <patrick@parcs.ath.cx>
Date: Mon, 27 Jul 2015 18:49:00 -0000
Message-ID: <CA+C-WL9z2dTcGEf=P4z0YVyQkWhx3V=qmbkORe+zcwg27Fshkw@mail.gmail.com>
Subject: Re: [PATCH] Call target_terminal_ours in quit_force
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2015-07/txt/msg00803.txt.bz2

On Mon, Jul 27, 2015 at 12:39 PM, Pedro Alves <palves@redhat.com> wrote:
> On 07/27/2015 05:11 PM, Patrick Palka wrote:
>> On Mon, Jul 27, 2015 at 12:08 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>>> We should make sure our terminal settings are in effect before finally
>>> quitting GDB.  Our terminal settings may not be in effect at this point
>>> if we are e.g. quitting due to a SIGTERM.
>>
>> I should add, "quitting due to a SIGTERM while an inferior an inferior
>> is running in the foreground."
>
> Looks OK, though I notice that the settings are broken even if we
> we're not debugging anything:
>
> $ stty
> speed 38400 baud; line = 0;
> iutf8
>
> $ ./gdb
> GNU gdb (GDB) 7.10.50.20150726-cvs
> (gdb)
> *sent SIGTERM from another terminal, gdb exits*
> $
> $ stty (echo is off)
> speed 38400 baud; line = 0;
> lnext = <undef>; min = 1; time = 0;
> -icrnl iutf8
> -icanon -echo
> $
>
> Do you also see this?

Yeah, even with this patch...

$ stty
speed 38400 baud; line = 0;
-brkint -imaxbel iutf8
$ gdb -q
(gdb) *SIGTERM*
$ stty
speed 38400 baud; line = 0;
lnext = <undef>;
-brkint -icrnl -imaxbel iutf8

Quitting via the "quit" command is OK though... strange.