From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52421 invoked by alias); 30 Jun 2015 17:11:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52407 invoked by uid 89); 30 Jun 2015 17:11:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f177.google.com Received: from mail-ob0-f177.google.com (HELO mail-ob0-f177.google.com) (209.85.214.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 17:11:08 +0000 Received: by obbkm3 with SMTP id km3so11001644obb.1 for ; Tue, 30 Jun 2015 10:11:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=mYMk99Rs4fxzbdMmRyfBVbs6yR7xPToyE7mIhDrIAs4=; b=OysF/6E8IcIOB2dDtTWLGHrsIoWS4xq7fNPZgGUJTZhjY4ugMgWXDFniWivGThrdcb zjekjA8es3mpLHePVtY2xXpCJQM5AlqPEkb1XgnfTFLQsKCSbOVrbOLw8gh7Gg5a/f8z 6y4piGCjOxv9Cs6Hgip7Znrw+cq/z+JeEKJLbmjCy7IfIo4e09UYIgoiHrO9mgu0fkN8 dL5UTVHrLQNemZl5PdqzsEVgm/U9OZVV5hIvb5DtMnTG+rXkWaYBrXqrYo0yJ8H3zvfR zQY6KfGscl+dye9+8lIszTx3aXooIp8muFPO4Qj/4Jtu5BOSne6E4TQk6dqrIObUXkch OrGA== X-Gm-Message-State: ALoCoQm2fSZigyIkVzjm7XuY16jmh29Ty4FWSnrXMabYFUmwhlC6Km4NvAvi3cPNjVlNsc7i4ti7 X-Received: by 10.202.49.135 with SMTP id x129mr19813996oix.63.1435684266916; Tue, 30 Jun 2015 10:11:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Tue, 30 Jun 2015 10:10:47 -0700 (PDT) In-Reply-To: <5592CCC7.5080101@redhat.com> References: <5592B9F9.2090208@redhat.com> <1435682400-7595-1-git-send-email-patrick@parcs.ath.cx> <5592CCC7.5080101@redhat.com> From: Patrick Palka Date: Tue, 30 Jun 2015 17:11:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00656.txt.bz2 On Tue, Jun 30, 2015 at 1:07 PM, Pedro Alves wrote: > On 06/30/2015 05:40 PM, Patrick Palka wrote: >> [ I elected to go with making the print_frame_info_listing hook a no-op, since >> it does not seem to regress anything. >> >> I noticed that "layout regs" was somewhat broken now that >> tui_refresh_frame_and_register_information is called twice following a normal >> stop: once in tui_normal_stop and then in tui_before_prompt. The second call >> removes any highlights done to the individual registers during the first >> call, because the function notices that the current snapshot of register >> values is the same as the one taken during the first call. So effectively >> register changes are no longer highlighted in "layout regs" since the >> highlights immediately get removed. >> >> I don't think we should refresh register information at all in >> tui_before_prompt since this observer is intended to only update frame >> information following a call to "up", "down", "frame", etc. Only after the >> inferior has run for a bit could registers have changed. So this patch adds >> the parameter registers_too_p to tui_refresh_frame_and_register_information >> to indicate wheher we should update registers too, and updates >> tui_before_prompt and tui_normal_stop accordingly. ] > > Hmm, what about when the user changes registers with "print $rax = 1" etc.? > Do we end up with stale contents? Apparently not, thanks to our deprecated_register_changed_hook called from value_assign. So many hooks!