From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127677 invoked by alias); 4 Jun 2015 15:30:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127609 invoked by uid 89); 4 Jun 2015 15:30:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f171.google.com Received: from mail-ob0-f171.google.com (HELO mail-ob0-f171.google.com) (209.85.214.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 04 Jun 2015 15:30:41 +0000 Received: by obbqz1 with SMTP id qz1so16786798obb.3 for ; Thu, 04 Jun 2015 08:30:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=C3MF3/ARTpenQeHSx5idtFTIOBlHRpg217ZX0LeBWHk=; b=iHZD3WBX1tKP11JKvg7OScWrF9xLCD+dh+a2JbJy6Bm0u5v4dik/Q2Rln52YgbjiBH EvBp7dLGSoQlurtFVzgj2p0WOzGTAY6dUn+ei4KDodryD+P4BVlk4VshYmjSKADXq/hE eT1+e6YQXLMbnuGPzBOfRhKbIJQYGx+g92KHJ+JbIeSIvUaOkSDFMgUd3Cvq7PeFZOax rAdxcc06FTQWnndVQMYI9aeg6hFN0ZYDC3Sk3Z3gxLt34xAq+MpT7SYR2Lw/oN35Vv8d uEy2fD+/EEG9qxevkYiL0njCqXwYbX0EsYQdM3YrKuKJShw85Dxv0FfQjAYw8OHakZAz 1SPQ== X-Gm-Message-State: ALoCoQk4PnahNr0ttiWDhsxX9/bWQmeWAhWkWHt5oiT+u6qBOsSSoZkKIu4ipWU60hq8UUAeWzSB X-Received: by 10.60.125.169 with SMTP id mr9mr32487836oeb.14.1433431839623; Thu, 04 Jun 2015 08:30:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Thu, 4 Jun 2015 08:30:18 -0700 (PDT) In-Reply-To: <83vbfk4wxi.fsf@gnu.org> References: <1432293831-23599-1-git-send-email-patrick@parcs.ath.cx> <83vbfk4wxi.fsf@gnu.org> From: Patrick Palka Date: Thu, 04 Jun 2015 15:30:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE To: Eli Zaretskii Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00068.txt.bz2 On Fri, May 22, 2015 at 8:30 AM, Eli Zaretskii wrote: >> From: Patrick Palka >> Cc: Patrick Palka >> Date: Fri, 22 May 2015 07:23:50 -0400 >> >> The HISTSIZE environment variable is generally expected to be read by >> shells, not by applications. Some distros for example globally export >> HISTSIZE in /etc/profile -- with the intention that it only affects >> shells -- and by doing so it renders useless GDB's own mechanism for >> setting the history size via .gdbinit. Also, annoyances may arise when >> HISTSIZE is not interpreted the same way by the shell and by GDB, e.g. >> PR gdb/16999. That can always be fixed on a shell-by-shell basis but it >> may be impossible to be consistent with the behavior of all shells at >> once. Finally it just makes sense to not confound shell environment >> variables with application environment variables. >> >> gdb/ChangeLog: >> >> * NEWS: Add entry. >> * top.c (init_history): Read from GDBHISTSIZE instead of >> HISTSIZE. >> (init_main): Refer to GDBHISTSIZE instead of HISTSIZE. >> >> gdb/doc/ChangeLog: >> >> * gdb.texinfo (Command History): Replace occurrences of HISTSIZE >> with GDBHISTSIZE. > > Thanks. > > I think we should explain in the manual why we don't use HISTSIZE. > And I wonder why we cannot use HISTSIZE if neither GDBHISTSIZE nor > .gdbinit specify the size, but you probably already discussed that. Hmm, reading HISTSIZE as a last resort would reduce the inter-version breakage a little, at least for users who today rely solely on HISTSIZE (not ~/.gdbinit) to set their history size. This can be done, I guess. > > Otherwise, the documentation part is OK.