From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110974 invoked by alias); 15 May 2015 17:27:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110879 invoked by uid 89); 15 May 2015 17:27:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 15 May 2015 17:27:00 +0000 Received: by oiko83 with SMTP id o83so87546165oik.1 for ; Fri, 15 May 2015 10:26:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=RGZ5befHrMjtYCURaMBN/0GZHVUeQKiVFKo6iSKR5rs=; b=PLFdwCiUTzqr4HHdJEMIub0BMldemKWNC+IgBClBowiwvn5aKaJNjEJaEvX4PsHccF /WEjup8TETvEyWV9hooQWP7juBSOXm9SOuVNtmqswRVzl/QbSsSYzQm5Mta3rNqzg1oH DakeMrfBF9GxWzJazJOlXRRp+fWIb5XNyKZKlJFPvveBLGUsALvRFzih7NZMLsbI3Y+q nZD3CSoML4Nt/e7o8dLRrjg++v4Fn+UDX41UjGc6wg6pswQJfYl7DoPDmYS1hLDIJK8M pogD/uRgLTGZMDkoRAXQAP29ksDzj6TNH3D5bbwr5U+Bd3I7I70N/tDyRuwg4KaUzbvL vagQ== X-Gm-Message-State: ALoCoQnwjiMIniMXKZOZ6nQgfVYL48NDZiFHsfEellMD7RVZC/vwM/BsKHvZNS128p8DlN4CGF6c X-Received: by 10.182.102.129 with SMTP id fo1mr9446818obb.24.1431710818344; Fri, 15 May 2015 10:26:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.243.232 with HTTP; Fri, 15 May 2015 10:26:37 -0700 (PDT) In-Reply-To: <55562A28.9050503@redhat.com> References: <1431523782-20409-1-git-send-email-patrick@parcs.ath.cx> <55561958.2030105@redhat.com> <55562A28.9050503@redhat.com> From: Patrick Palka Date: Fri, 15 May 2015 17:27:00 -0000 Message-ID: Subject: Re: [PATCH] [COMMITTED] Fix PR gdb/17820 To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-05/txt/msg00405.txt.bz2 On Fri, May 15, 2015 at 1:17 PM, Pedro Alves wrote: > On 05/15/2015 06:09 PM, Patrick Palka wrote: >> On Fri, May 15, 2015 at 12:05 PM, Pedro Alves wrote: >>> Hi Patrick, >>> >>> I noticed that the buildbots are showing that this new test is failing: >>> >>> https://sourceware.org/ml/gdb-testers/2015-q2/msg04164.html >>> >>> ~~~ >>> ============================ >>> new FAIL: gdb.base/gdbinit-history.exp: show commands <<2>> >>> new FAIL: gdb.base/gdbinit-history.exp: show history size >>> new FAIL: gdb.base/gdbinit-history.exp: show history size <<2>> >> >> Also the tests in this file have duplicate names.. That's undesirable >> right? If so I could make the names unique. > > Yes. I should have spotted that earlier. > >> Would such a change fall under the "obvious" rule? > > Not sure, depends on how you would fix it. :-) Apply the test > described in MAINTAINERS. :-) So it will probably not be obvious because of naming preferences. > > There are a couple ways to address that. In cases like > this test, where we have a function that called multiple > times, the modern way is to use with_test_prefix to wrap the > function call or the function body, which then also covers > FAILs issued from within gdb_start, etc. Cool.. I will do something like that.