From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94286 invoked by alias); 15 Jun 2015 16:01:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94276 invoked by uid 89); 15 Jun 2015 16:01:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 15 Jun 2015 16:01:12 +0000 Received: by oiha141 with SMTP id a141so62159073oih.0 for ; Mon, 15 Jun 2015 09:01:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=aMsTfCXqbi4Znqera2hnUyRc+wvlUjPZwAUc2UilTNA=; b=CqIa/aRNwUKmDONJFwcZHN2oyahH+NmVUYL0ZcOJ6t8pPrlrTnoaSXXzMuF+5cTygZ nUe/BJbZQz3GMSKmhiGouT1MR5/j/FdK6kcmrWVl/4KHF80v36Di2udk+e3I9fGFw8fW ADaCwJELatY4FWhSOWWPAkfAhuE0NGhZnULjJkU+cDYJZ5aac6g0osMoKPem/rNgVrYU 9yjkupDcwWvvbx1H9Ga/wQNpXtn+IsaV8FDIuEQDU0cidrgo0OkXUMAC8amX83zSAYZp ZWN/2DKYEUKblJcaZxRhZARcm5RBNACjDTxNf8G7DmC5qbn7agObgHNPXWmRFPRz+0Wy cPOQ== X-Gm-Message-State: ALoCoQlUuOmlqEs0L2qKYXkbPdLkgXG0MLAXhi+0Rsbxro0rFsfYU13NGkyU5ceVQaYJiuP4V1m0 X-Received: by 10.182.102.129 with SMTP id fo1mr24767647obb.24.1434384070335; Mon, 15 Jun 2015 09:01:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Mon, 15 Jun 2015 09:00:49 -0700 (PDT) In-Reply-To: <557EEE7E.90802@redhat.com> References: <1433878062-23560-1-git-send-email-patrick@parcs.ath.cx> <557EEE7E.90802@redhat.com> From: Patrick Palka Date: Mon, 15 Jun 2015 16:01:00 -0000 Message-ID: Subject: Re: [PATCH] Don't truncate the history file when history size is unlimited To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00317.txt.bz2 On Mon, Jun 15, 2015 at 11:25 AM, Pedro Alves wrote: > On 06/09/2015 08:27 PM, Patrick Palka wrote: >> We still do not handle "set history size unlimited" correctly. In >> particular, after writing to the history file, we truncate the history >> even if it is unlimited. > > Whoops. > >> >> This patch makes sure that we do not call history_truncate_file() if the >> history is not stifled (i.e. if it's unlimited). This bug causes the >> history file to be truncated to zero on exit when one has "set history >> size unlimited" in their gdbinit file. Although this code exists in GDB >> 7.8 it is masked by a pre-existing bug that's been only fixed in GDB 7.9 >> (PR gdb/17820). >> >> I tried to make a test to check that the history does not get truncated >> on exit when the history size is unlimited, but I could not get the test >> to work properly. > > How so? I could not observe that the history file gets truncated with this patch reverted. Maybe I simply have forgotten to revert the patch or something stupid like that. I'll take another stab at it. > >> Also I could not figure out a good way to create a >> temporary file (to act as the history file) in tcl versions earlier than >> 8.6. I am not sure if it's worth the effort to add a test. > > Not sure I follow. Why do you need a temporary file? > You can leave the file in the build/test dir. In fact, that's > encouraged, to make it easier to debug the test on failures. > You can instead delete a stale file from a previous run at the > start of the (new) run. Good point... What's the right way to refer to the $buildroot/gdb/testsuite/gdb.base directory? > >> (Apparently I did not test my changes to history file handling >> extensively enough. Sorry..) > > Don't stress about it. But, it does show out that having a test > would be useful. So I think it's worth the effort. > > The code changes look OK to me. > > Thanks, > Pedro Alves >