From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42481 invoked by alias); 23 Jul 2015 00:28:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42472 invoked by uid 89); 23 Jul 2015 00:28:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f50.google.com Received: from mail-oi0-f50.google.com (HELO mail-oi0-f50.google.com) (209.85.218.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 23 Jul 2015 00:28:23 +0000 Received: by oigd21 with SMTP id d21so112796553oig.1 for ; Wed, 22 Jul 2015 17:28:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=wvYNWPId2P38dH8uYWZI07Iq3zSSOypvWN9qELAcsn4=; b=buTCPFC7YXmXpv8ZTUoYy+dCWrgoeEB2kp58Xs4ZMSRu+zzkydO0DEsFhMQSeqcWsv y+tfOfsRVhL87BIuPEj3AWcWAnmUy1S0k1NjBLcas4/Rpm5/1X5mF6SpJ1kPTi4wCnTx Xeglo0ftQBdXXJz9pkL4+3dSfP1QmGZ+EOsZKTXPq1Vrf48AlloiZJ7qcHyquRSIzvvO Qn0bzJDzKo2NYn4PIL5qvWvciBPDxO5sVu87JcCO2JmcFS11PLMVu6JRwNSah4aDFOTv wW7U7EhOjoWaF1A3wY2FcNxCCQGuCkqLhiGKd7chZyLD659CK3TsUeRvISAsm5JTnH+E 3vDQ== X-Gm-Message-State: ALoCoQmmC6C6GpJYQ5l5mZ4cjXUMTGBVdynz9fDrpacVzdnZ9Rif/6ly63n+3O/N0xkLBaAATQKq X-Received: by 10.182.210.194 with SMTP id mw2mr795219obc.59.1437611301805; Wed, 22 Jul 2015 17:28:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.56.202 with HTTP; Wed, 22 Jul 2015 17:28:02 -0700 (PDT) In-Reply-To: <1436927724-4059-1-git-send-email-patrick@parcs.ath.cx> References: <1436927724-4059-1-git-send-email-patrick@parcs.ath.cx> From: Patrick Palka Date: Thu, 23 Jul 2015 00:28:00 -0000 Message-ID: Subject: Re: [PATCH] Sync readline/ to version 7.0 alpha To: "gdb-patches@sourceware.org" Cc: Eli Zaretskii , Patrick Palka Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00617.txt.bz2 On Tue, Jul 14, 2015 at 10:35 PM, Patrick Palka wrote: > This patch syncs our upstream copy of readline from version 6.2 to the > latest version, 7.0 alpha (released July 10 2015). > > I essentially copied what was done the last time readline was synced, > when Jan updated to readline 6.2 in 2011: > http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html > > Procedure: > > 1. I extracted the readline-7.0-alpha tarball on top of readline/. > 2. I deleted all the new files under doc/ that were deliberately omitted > before. > 3. I regenerated readline/configure and readline/examples/rlfe/configure > using autoconf 2.64. No other configure files need regenerating. > 4. I updated the function gdb_printable_part in completer.c with a > trivial change made to the readline function it is based off of, > printable_part in readline/complete.c. There is more work to be done in > completer.c to sync it with readline/complete.c, but it is non-trivial > and should probably be done separately anyway. > > Local patches that had to be reapplied: > > None. readline 7.0 alpha contains all of our local readline > patches. [This is especially convenient because it allows us forego > a consensus on how to manage local patches across readline syncs :)] > > New files in readline/: > > colors.{c,h} > examples/{hist_erasedups,hist_purgecmd,rl-callbacktest,rlbasic}.c > parse-colors.{c,h} > readline.pc.in > configure.ac > > Deleted files in readline/: > > configure.in > > Regressions: > > After the sync there is one testsuite regression, the test > "signal SIGINT" in gdb.gdb/selftest.exp which now FAILs. Previously, > the readline 6.2 SIGINT handler would temporarily reinstall the > underlying application's SIGINT handler and immediately re-raise SIGINT > so that the orginal handler gets invoked. But now (since readline 6.3) > its SIGINT handler does not re-raise SIGINT or directly invoke the > original handler; it now sets a flag marking that SIGINT was raised, and > waits until readline explicitly has control to call the application's > SIGINT handler. Anyway, because SIGINT is no longer re-raised from > within readline's SIGINT handler, doing "signal SIGINT" with a stopped > inferior gdb process will no longer resume and then immediately stop the > process (since there is no 2nd SIGINT to immediately catch). Instead, > the inferior gdb process will now just print "Quit" and continue to run. > So with this commit, this particular test case is adjusted to reflect > this change in behavior (we now have to send a 2nd SIGINT manually to > stop it). > > Aside from this one testsuite regression, I personally noticed no > regression in user-visible behavior. Though I only tested on x86_64 > and on i686 Debian Stretch. > > Getting this kind of change in at the start of the GDB 7.11 development > cycle will allow us to get a lot of passive testing from developers and > from bleeding-edge users. [And as new versions of readline 7.0 are > released, I will try to sync our local copy promptly.] > > Since the patch is too big to send inline, I pushed it to > users/ppalka/readline-7.0-update. Hopefully that is more convenient that > sending it as a compressed attachment. > > readline/ChangeLog.gdb: > > Import readline 7.0 alpha > * configure: Regenerate. > * examples/rlfe/configure: Regenerate. > > gdb/ChangeLog: > > * completer.c (gdb_printable_part): Sync with readline function > it is based off of. > > gdb/testsuite/ChangeLog: > > * gdb.gdb/selftest.exp (test_with_self): Update test to now > expect the GDB inferior to no longer immediately stop after > being resumed with "signal SIGINT". Ping!