Re: [PATCH] Append to input history file instead of overwriting it

Eli Zaretskii
2015-01-10T16:03:22Z

> From: Patrick Palka <patrick@parcs.ath.cx>
> Date: Sat, 10 Jan 2015 10:48:03 -0500
> Cc: gdb-patches@sourceware.org
>
> > On Windows, a call to 'rename' fails if the destination already
> > exists. Does the logic here cope with that?
>
> Hmm, the logic does not really cope with Windows' behavior here,
> because the above warning should only get emitted for unexpected
> failures. So I suppose we should only emit the above warning if errno
> != EBUSY (perhaps only on Windows systems)?

Why EBUSY?

We could also explicitly remove the target before the rename call (and
ignore any errors from that), which will make it work like on Posix
systems.