From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15412 invoked by alias); 25 Jul 2015 19:29:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15402 invoked by uid 89); 25 Jul 2015 19:29:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,URIBL_BLACK autolearn=no version=3.3.2 X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 25 Jul 2015 19:29:01 +0000 Received: by oigd21 with SMTP id d21so34661691oig.1 for ; Sat, 25 Jul 2015 12:29:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=xG3EDrW+NWNVetwuyuXisYS43D7yZPlpCdaXpB6KmQA=; b=XVlED5k0vRLsZNgyLoUd6TT0rWN0ZSNsA4kJ85gUxguM96XsVB0yKJKGBTUYO/Cv/l Z1v24P/tSrDI6EPlqJ096cafvZeF7/ub6rSs7pIXDmzGLwjOUyFOo8zRX1sksneF0nJ3 dMyZCg3/fEEuEFOrGIvsR0Ertc8ZvV3WidiA0DnrIpA7DxdDph+XcpHmQ1cSkhzS6LBg EfXY3ufr8GivQuLLBLbMJXkBydOr2WxmmETseqwsPbix+G4rx9b7IN9lNhxZtJKbU20M 3pcurKJZ1OSGCGcGAdAxp5yXR/xZg9/yj3kOycjogfHlezlZdjytbFtagFRmNQv/Sgnv T/sg== X-Gm-Message-State: ALoCoQmMGOdGYfe0RKwG8Gf0V1ukuCH3NxeNMbwSBw7CQ4hzJVTzl/SDiI4ftEfolw+pg0azlkNu X-Received: by 10.202.225.65 with SMTP id y62mr19734790oig.78.1437852539936; Sat, 25 Jul 2015 12:28:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.56.202 with HTTP; Sat, 25 Jul 2015 12:28:40 -0700 (PDT) In-Reply-To: References: <1436927724-4059-1-git-send-email-patrick@parcs.ath.cx> <55B1FB46.5000106@redhat.com> From: Patrick Palka Date: Sat, 25 Jul 2015 19:29:00 -0000 Message-ID: Subject: Re: [PATCH] Sync readline/ to version 7.0 alpha To: Doug Evans Cc: Pedro Alves , "gdb-patches@sourceware.org" , Eli Zaretskii , Sergio Durigan Junior Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-07/txt/msg00759.txt.bz2 On Sat, Jul 25, 2015 at 3:15 PM, Doug Evans wrote: > On Sat, Jul 25, 2015 at 8:33 AM, Patrick Palka wro= te: >> On Fri, Jul 24, 2015 at 4:45 AM, Pedro Alves wrote: >>> On 07/15/2015 03:35 AM, Patrick Palka wrote: >>>> This patch syncs our upstream copy of readline from version 6.2 to the >>>> latest version, 7.0 alpha (released July 10 2015). >>>> >>>> I essentially copied what was done the last time readline was synced, >>>> when Jan updated to readline 6.2 in 2011: >>>> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html >>> >>> >>>> Getting this kind of change in at the start of the GDB 7.11 development >>>> cycle will allow us to get a lot of passive testing from developers and >>>> from bleeding-edge users. >>> >>> I agree; if this helps find readline issues that affect GDB before >>> readline is released, it'll be a win, because distros tend to use the >>> system readline instead of the one we bundle. >>> >>>> [And as new versions of readline 7.0 are >>>> released, I will try to sync our local copy promptly.] >>>> >>> >>> Thanks. >>> >>>> Since the patch is too big to send inline, I pushed it to >>>> users/ppalka/readline-7.0-update. Hopefully that is more convenient t= hat >>>> sending it as a compressed attachment. >>> >>> Indeed it is. Thanks. >>> >>>> >>>> readline/ChangeLog.gdb: >>>> >>>> Import readline 7.0 alpha >>>> * configure: Regenerate. >>>> * examples/rlfe/configure: Regenerate. >>>> >>>> gdb/ChangeLog: >>>> >>>> * completer.c (gdb_printable_part): Sync with readline function >>>> it is based off of. >>>> >>>> gdb/testsuite/ChangeLog: >>>> >>>> * gdb.gdb/selftest.exp (test_with_self): Update test to now >>>> expect the GDB inferior to no longer immediately stop after >>>> being resumed with "signal SIGINT". >>> >>> Looks good to me. >> >> Thanks for reviewing. I pushed this patch earlier today and not >> surprisingly the buildbot caught some build failures. The ultimate >> cause of these failures is that readline now builds shared libraries >> by default alongside static libraries. I pushed a patch that disables >> the building of readline's shared libraries by default. > > Another build failure: > > ../../testsuite-random/readline/display.c: In function =E2=80=98rl_redisp= lay=E2=80=99: > ../../testsuite-random/readline/display.c:1032:12: error: =E2=80=98mb_cur= _max=E2=80=99 > undeclared (first use in this function) > if (mb_cur_max > 1 && rl_byte_oriented =3D=3D 0) > ^ > ../../testsuite-random/readline/display.c:1032:12: note: each > undeclared identifier is reported only once for each function it > appears in > > A lot of uses of mb_cur_max are no longer protected with > #ifdef HANDLE_MULTIBYTE > yet its definition (in rl_redisplay) still is. > > I don't know what the right fix is, but we need to get this > fixed asap. Hmm, I'll just revert this patch for now since I also noticed that I failed to reapply some local changes to readline's configure.in that were hid by the rename to configure.ac. Also, the buildbots are showing new regressions for e.g. AIX. I won't have enough time over the next few days to manage the fallout of this change.