From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22431 invoked by alias); 25 Jul 2015 15:34:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22421 invoked by uid 89); 25 Jul 2015 15:34:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f181.google.com Received: from mail-ob0-f181.google.com (HELO mail-ob0-f181.google.com) (209.85.214.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 25 Jul 2015 15:34:16 +0000 Received: by obnw1 with SMTP id w1so33294946obn.3 for ; Sat, 25 Jul 2015 08:34:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=+tBxF4eWXI1UZglAk8TwAXPRHxW2Fu9sRezqZHSTPnA=; b=g4AeyD2LOQ/S8rgFTGWiRHHPzVmYUjcPHIphSWbshEE+IfzUv+kBP5Kk2TcIXed2cL /WEdaBDZotdERDfpbQdZ/a2tn893Poq9UTukx2L1W/Mqo9lj5wV01sEeNwfiotksK3na awPd16whH99IgVEcI9MCDvHIISG+dZ6bBP2+pijL87/BWdLKkFkZlRXC3VeAXegkW6o6 JN2k1KNsauAOxDA0eXM4rQOwN8b4O/Y0bBfgVps4qKHxdv7s2IbPBHKat0DykVJsJUpM W3PBIvLWj4z2WfZTeEk4VWGYNeEzheQ9pDdcPTSvKSZ4jjx4U56M3/ckAbIiChEqOp2p TJUg== X-Gm-Message-State: ALoCoQn43n9HVYQGO9sD8lTjKtR7G2Ma0bkP4HxTxZEJQSMU0rCI6TpLrhsK2jq+iC+I8Y/D4Jzo X-Received: by 10.182.129.19 with SMTP id ns19mr19784502obb.3.1437838455131; Sat, 25 Jul 2015 08:34:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.56.202 with HTTP; Sat, 25 Jul 2015 08:33:55 -0700 (PDT) In-Reply-To: <55B1FB46.5000106@redhat.com> References: <1436927724-4059-1-git-send-email-patrick@parcs.ath.cx> <55B1FB46.5000106@redhat.com> From: Patrick Palka Date: Sat, 25 Jul 2015 15:34:00 -0000 Message-ID: Subject: Re: [PATCH] Sync readline/ to version 7.0 alpha To: Pedro Alves Cc: "gdb-patches@sourceware.org" , Eli Zaretskii , Sergio Durigan Junior Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00745.txt.bz2 On Fri, Jul 24, 2015 at 4:45 AM, Pedro Alves wrote: > On 07/15/2015 03:35 AM, Patrick Palka wrote: >> This patch syncs our upstream copy of readline from version 6.2 to the >> latest version, 7.0 alpha (released July 10 2015). >> >> I essentially copied what was done the last time readline was synced, >> when Jan updated to readline 6.2 in 2011: >> http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html > > >> Getting this kind of change in at the start of the GDB 7.11 development >> cycle will allow us to get a lot of passive testing from developers and >> from bleeding-edge users. > > I agree; if this helps find readline issues that affect GDB before > readline is released, it'll be a win, because distros tend to use the > system readline instead of the one we bundle. > >> [And as new versions of readline 7.0 are >> released, I will try to sync our local copy promptly.] >> > > Thanks. > >> Since the patch is too big to send inline, I pushed it to >> users/ppalka/readline-7.0-update. Hopefully that is more convenient that >> sending it as a compressed attachment. > > Indeed it is. Thanks. > >> >> readline/ChangeLog.gdb: >> >> Import readline 7.0 alpha >> * configure: Regenerate. >> * examples/rlfe/configure: Regenerate. >> >> gdb/ChangeLog: >> >> * completer.c (gdb_printable_part): Sync with readline function >> it is based off of. >> >> gdb/testsuite/ChangeLog: >> >> * gdb.gdb/selftest.exp (test_with_self): Update test to now >> expect the GDB inferior to no longer immediately stop after >> being resumed with "signal SIGINT". > > Looks good to me. Thanks for reviewing. I pushed this patch earlier today and not surprisingly the buildbot caught some build failures. The ultimate cause of these failures is that readline now builds shared libraries by default alongside static libraries. I pushed a patch that disables the building of readline's shared libraries by default. > > Thanks, > Pedro Alves >