From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57066 invoked by alias); 30 Jun 2015 20:05:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57054 invoked by uid 89); 30 Jun 2015 20:05:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 20:05:11 +0000 Received: by oigx81 with SMTP id x81so16142398oig.1 for ; Tue, 30 Jun 2015 13:05:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=N6kxhJA9I9icasRYMYkROW/2RTdzilxTBVIaRfHoe14=; b=CRoVGKhWp/6aDpUwUo4W4UKLkQ8PB3fB8cBplUhy6yjitrMeM8HhcYTnTGDM3mGWqX OsGMSxnH2fe1zhjwkA+k59Yk44RUwb0cz8cXjRXuR34Crn6cBy9zRP38pA2Iab2f02qh +ztulA/TJWqyii0fV2EwI2hhUtA914P+egjUn81+wZZIdyVEeF9PuJeGs4p/0BmXNNVF C19dAxU9MLZ/obyhqxVtNztkJZODd7+8NIvVWHkPv6Q/xgt7rlkShib9KsGuTSo7Qu1M CR4UFKcivvsKCgGmJ+XNDT2hh9YN/554BtSVImh2bc4iV6kA5yTE8BdfdUiTZkAbItvJ xTmA== X-Gm-Message-State: ALoCoQl4hvJs/rISqio/PcfZ0YB+PDYFFfODeeOpIw8N0TDgYSpB82DsxMnsfOmphIO/CzITKuc4 X-Received: by 10.182.153.197 with SMTP id vi5mr21245211obb.28.1435694709713; Tue, 30 Jun 2015 13:05:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Tue, 30 Jun 2015 13:04:50 -0700 (PDT) In-Reply-To: <5592631D.4020108@redhat.com> References: <1435631281-31970-1-git-send-email-patrick@parcs.ath.cx> <1435631281-31970-2-git-send-email-patrick@parcs.ath.cx> <5592631D.4020108@redhat.com> From: Patrick Palka Date: Tue, 30 Jun 2015 20:05:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00662.txt.bz2 On Tue, Jun 30, 2015 at 5:36 AM, Pedro Alves wrote: > On 06/30/2015 03:28 AM, Patrick Palka wrote: >> Since the type whose name is being set is now being allocated on the >> gdbarch obstack, we should allocate its TYPE_NAME on the obstack too. >> This reduces the number of individual valgrind warnings for the command >> "gdb gdb" from ~300 to ~150. >> >> Tested on x86_64-unknown-linux-gnu. >> >> [ I have a few more patches on top of these that together bring the total >> number of valgrind warnings for the command "gdb gdb" down to ~30 >> but they are more controversial than these two, and if these aren't OK >> then the rest definitely aren't OK. ] > > Both patches look fine to me. If this blows up for some reason, I guess > we'll take the opportunity to add a comment explaining why these must go > on the heap. :-) Heh, sounds good. I will hold off committing these patches at least until 7.10 gets released to avoid unnecessary breakage.