From: Patrick Palka <patrick@parcs.ath.cx>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix truncation of TUI command history
Date: Thu, 04 Sep 2014 12:17:00 -0000 [thread overview]
Message-ID: <CA+C-WL80sL8qGOvpdXSZXO6gQ0cm5O2NW+78obb=OhHPZNDJTQ@mail.gmail.com> (raw)
In-Reply-To: <54083483.6080502@redhat.com>
On Thu, Sep 4, 2014 at 5:44 AM, Pedro Alves <palves@redhat.com> wrote:
> Hi Patrick,
>
> On 08/30/2014 07:11 PM, Patrick Palka wrote:
>> index aa14790..eee5f1ac6 100644
>> --- a/gdb/tui/tui-io.c
>> +++ b/gdb/tui/tui-io.c
>> @@ -678,8 +678,9 @@ tui_getc (FILE *fp)
>> }
>> else
>> {
>> + /* Move cursor to the end of the command line. */
>> wmove (w, TUI_CMD_WIN->detail.command_info.cur_line,
>> - TUI_CMD_WIN->detail.command_info.curch);
>> + strlen (tui_rl_saved_prompt) + rl_end);
>> waddch (w, ch);
>
> Does this still do the right thing with secondary prompts?
>
> E.g., if you do "quit" while a program is running, and then
> press enter a few times just to have the query repeat (and
> then pagination kick in, for extra stress).
>
> Thanks,
> Pedro Alves
>
Good point. It doesn't work correctly in this case. I'll try to find
a better solution.
next prev parent reply other threads:[~2014-09-04 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 18:11 Patrick Palka
2014-09-04 9:44 ` Pedro Alves
2014-09-04 12:17 ` Patrick Palka [this message]
2015-01-10 3:49 [PATCH] Fix a pair of screen-resizing issues in TUI Patrick Palka
2015-01-10 3:49 ` [PATCH] Fix truncation of TUI command history Patrick Palka
2015-01-10 3:59 ` Patrick Palka
2015-01-27 2:13 ` Patrick Palka
2015-02-04 14:50 ` Patrick Palka
2015-02-10 17:30 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+C-WL80sL8qGOvpdXSZXO6gQ0cm5O2NW+78obb=OhHPZNDJTQ@mail.gmail.com' \
--to=patrick@parcs.ath.cx \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox