From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92263 invoked by alias); 1 Jul 2015 12:40:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92254 invoked by uid 89); 1 Jul 2015 12:40:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f49.google.com Received: from mail-oi0-f49.google.com (HELO mail-oi0-f49.google.com) (209.85.218.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 01 Jul 2015 12:40:02 +0000 Received: by oift81 with SMTP id t81so30676638oif.3 for ; Wed, 01 Jul 2015 05:40:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=hI7GBktKSS+FeXRx6lLGQO/6WDMGAAu+f+FES52JoIU=; b=aysYbgy7QcY0VjuMDiKD+RIEln7nnTlxeGNS+rPQtKkS9PoSsJJO1pzGCwB8HM9Gde EWzlI/K1WCX35ZWhpj+gp6il3arptR3B52+9JaTNKK8N8wAxNRswM75B+WUe78Xn70Ah 5gamikNkNh5CDVO5MyBJq5HDDqN3UrVsEgjNesRPyZOp2IVWosHpvso8ifXwdONum1RZ ljJ83ulIRJ98D+S/XOEHNygCRbJFxM4MxAjuc92o7+Nzvti1u50P9u1ZhuYgqyvfq+sO 9YfXjgGSyacOPKzWF59HfbeqRJ7Ds51Tn1wsQVjqc+Vdwfxw+QBzTvG1O1xhY00skX95 04zQ== X-Gm-Message-State: ALoCoQmjJvKTDNZoZ0YRQMFXnoMXYacZHnZ69YWoG1TWdk3qLwrwz497QYaPjqt1AQAQANITV2Fe X-Received: by 10.182.211.66 with SMTP id na2mr23238330obc.43.1435754400028; Wed, 01 Jul 2015 05:40:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Wed, 1 Jul 2015 05:39:40 -0700 (PDT) In-Reply-To: <5592CCC7.5080101@redhat.com> References: <5592B9F9.2090208@redhat.com> <1435682400-7595-1-git-send-email-patrick@parcs.ath.cx> <5592CCC7.5080101@redhat.com> From: Patrick Palka Date: Wed, 01 Jul 2015 12:40:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00018.txt.bz2 On Tue, Jun 30, 2015 at 1:07 PM, Pedro Alves wrote: > On 06/30/2015 05:40 PM, Patrick Palka wrote: >> [ I elected to go with making the print_frame_info_listing hook a no-op, since >> it does not seem to regress anything. >> >> I noticed that "layout regs" was somewhat broken now that >> tui_refresh_frame_and_register_information is called twice following a normal >> stop: once in tui_normal_stop and then in tui_before_prompt. The second call >> removes any highlights done to the individual registers during the first >> call, because the function notices that the current snapshot of register >> values is the same as the one taken during the first call. So effectively >> register changes are no longer highlighted in "layout regs" since the >> highlights immediately get removed. >> >> I don't think we should refresh register information at all in >> tui_before_prompt since this observer is intended to only update frame >> information following a call to "up", "down", "frame", etc. Only after the >> inferior has run for a bit could registers have changed. So this patch adds >> the parameter registers_too_p to tui_refresh_frame_and_register_information >> to indicate wheher we should update registers too, and updates >> tui_before_prompt and tui_normal_stop accordingly. ] > > Hmm, what about when the user changes registers with "print $rax = 1" etc.? > Do we end up with stale contents? Unfortunately registers _do_ change following a call to "up", "down" or "frame", because the snapshot of register values is per-frame. So this patch introduced a regression -- it made it so that TUI does not update register information following such a call even though earlier versions do. I sent a patch to fix this.