Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378)

Pedro Alves
2015-06-30T13:23:12Z

On 06/30/2015 01:16 PM, Patrick Palka wrote:

>>> And as a result of this change and of the previous change to
>>> tui_show_frame_info, the TUI is much more disciplined about updating the
>>> screen, and so the flicker as described in the PR is totally gone.
>>
>> I think we should sort out patch 3 before patch 2. AFAICS, the
>> important one is this one, right?
>
> This one is more important, but by itself it causes source/asm-window
> scrolling to be reset after each command (due to the before_prompt
> observer) even if the frame information hasn't been changed in the
> meantime. Other than that they are mostly unrelated.

OK, I see.

I think I missed that because it only happens if you scroll enough to
make the highlighted source line _not_ visible. Just scrolling a bit
and entering a command is not enough to trigger it.

Thanks,
Pedro Alves