From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127118 invoked by alias); 30 Jun 2015 14:54:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127109 invoked by uid 89); 30 Jun 2015 14:54:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f49.google.com Received: from mail-oi0-f49.google.com (HELO mail-oi0-f49.google.com) (209.85.218.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 14:54:52 +0000 Received: by oift81 with SMTP id t81so9197240oif.3 for ; Tue, 30 Jun 2015 07:54:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=IrwNU5+XDpmxWZYHSxHt9VGf+pn656+1wkQSZIh0nfI=; b=BMjc1LHPnxJ7Y30ufRkx/x7QF3CORMfqdhLnnQnhwg9IGxoT6bQUYMa2GaC1sg2QL7 scfARGgZGtNWzoZOw8A61wyj1PP9zD0JJVyxdd/egFSUJPxqo8Nicuw4o8Vci+aQ+Xcv WsKw4OuEYv6lXtCYbPk/hxtzxtOkJef+YxPy8cbm3cXjnVUrgEVpFrV/5UOzZYb4KTP/ 1Xo8R4eSPV+gwBdwm9ZK0CUMODT5YRWyDVpHKY1FGix6GWa+e0VZFIxqHvxE5KHHh6MY SQ1hYDZcG5Gkcy4xseKEooZ2l2IqXea+esdZh8JjN2bFebxA7HVjmfuD7+RqxEekm5Xo 4/6g== X-Gm-Message-State: ALoCoQlNQbb4NOO3JKVn9Yfs4vuafv19K6iHF0jpJ15qvxfKZTE2dWS3N9bcwCyK+Vsu/KzDI5t1 X-Received: by 10.60.47.113 with SMTP id c17mr19723079oen.64.1435676090166; Tue, 30 Jun 2015 07:54:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Tue, 30 Jun 2015 07:54:30 -0700 (PDT) In-Reply-To: <5592A2EE.40900@redhat.com> References: <1435667837-16337-1-git-send-email-patrick@parcs.ath.cx> <5592A2EE.40900@redhat.com> From: Patrick Palka Date: Tue, 30 Jun 2015 14:54:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00639.txt.bz2 On Tue, Jun 30, 2015 at 10:08 AM, Pedro Alves wrote: > On 06/30/2015 01:37 PM, Patrick Palka wrote: >> This version adds a tui_normal_stop observer in place of augmenting the >> tui_on_sync_execution_done observer. And tui_refresh_frame_and_register_information >> can now be made a static function. >> >> The observer takes a print_frame parameter that is supposed to inform us >> whether the frame should be printed. This boolean seems to only be true for > > s/only be true/only be false/ > >> when the inferior has exited. Since tui_refresh_frame_and_register_information >> already handles this case by checking has_stack_frames() this patch elects to >> ignore this parameter in the observer. > > This is OK. I'll take a look at patch 2 soon. > > Did you find that we still need deprecated_print_frame_info_listing_hook? It still seems to be "necessary" -- at least, I can't outright remove it. The only caller of deprecated_print_frame_info_listing_hook is in print_frame_info and its use looks like this: if (deprecated_print_frame_info_listing_hook) (*deprecated_print_frame_info_listing_hook) (...); else { ... other code ... } If I remove the hook by replacing the above code with { ... other code ... } Then a regression occurs: the TUI decides to make sure that the currently executing line always sits at the top of the window instead of only scrolling the screen when the currently executing line is not invisible. But if I disable the hook by replacing the body of code in print_frame_info with if (deprecated_print_frame_info_listing_hook) ; else { ... other code ... } Then everything seems to be OK. So the code in the else branch is interfering with TUI somehow. I will investigate further. > > Thanks, > Pedro Alves >