From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59034 invoked by alias); 30 Jun 2015 14:03:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59024 invoked by uid 89); 30 Jun 2015 14:03:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f179.google.com Received: from mail-ob0-f179.google.com (HELO mail-ob0-f179.google.com) (209.85.214.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 14:03:09 +0000 Received: by obbkm3 with SMTP id km3so7040506obb.1 for ; Tue, 30 Jun 2015 07:03:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=qtWfmNiNdK22Tlr4dlhtjRZ3XwztF63h1aJHwEhMSKo=; b=FCpiybRtWYu/iVlVqEASFVE4wAbJDUcgiedoUj413CWTEqGQD+vmA5AJ5ktCdbYJlT c6eOZ1UKwhQQyn2EJ+rgOzb6Ieod5v4N4f1MSFJ60jUX24Fxeq/E+ZEiJoBCP9zqWCLV StD+uFfpey5fVhfJbq5ahJd5wr8PUZOeV1uOGnyBMSt5K9KEKRijMn7zLJgI/XLPv1zm pP0QOQ254knrhE1FJOdBL0vYkEZGZyFJSGII6Dq0xZ2qEQRBwn0x4MFpkm82mGPcPuEP ENjFc6pxof9ScXTNeUqi8UbCnHkCj7H+bmEZDiP9ISAnLy61qWX4brQ++PvgY9gnkpri IRgw== X-Gm-Message-State: ALoCoQnJ3rlEWEM0EeAzXU0HKFkEJww/npa1qK6p5TYU9OCEWVUs2d7UBrGzlFb7TayWENeGfTIc X-Received: by 10.60.99.66 with SMTP id eo2mr19604031oeb.65.1435672987455; Tue, 30 Jun 2015 07:03:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Tue, 30 Jun 2015 07:02:47 -0700 (PDT) In-Reply-To: <55929838.5030703@redhat.com> References: <1435372525-1374-3-git-send-email-patrick@parcs.ath.cx> <1435373402-5164-1-git-send-email-patrick@parcs.ath.cx> <5592622D.40305@redhat.com> <55929838.5030703@redhat.com> From: Patrick Palka Date: Tue, 30 Jun 2015 14:03:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00634.txt.bz2 On Tue, Jun 30, 2015 at 9:23 AM, Pedro Alves wrote: > On 06/30/2015 01:16 PM, Patrick Palka wrote: > >>>> And as a result of this change and of the previous change to >>>> tui_show_frame_info, the TUI is much more disciplined about updating the >>>> screen, and so the flicker as described in the PR is totally gone. >>> >>> I think we should sort out patch 3 before patch 2. AFAICS, the >>> important one is this one, right? >> >> This one is more important, but by itself it causes source/asm-window >> scrolling to be reset after each command (due to the before_prompt >> observer) even if the frame information hasn't been changed in the >> meantime. Other than that they are mostly unrelated. > > OK, I see. > > I think I missed that because it only happens if you scroll enough to > make the highlighted source line _not_ visible. Just scrolling a bit > and entering a command is not enough to trigger it. Yep -- sorry, should've mentioned that bit. > > Thanks, > Pedro Alves >