From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24737 invoked by alias); 30 Jun 2015 17:49:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24727 invoked by uid 89); 30 Jun 2015 17:49:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-ob0-f171.google.com Received: from mail-ob0-f171.google.com (HELO mail-ob0-f171.google.com) (209.85.214.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 17:49:42 +0000 Received: by obbkm3 with SMTP id km3so11726074obb.1 for ; Tue, 30 Jun 2015 10:49:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=EcB8O6x69B4DzTZCSvmZfwRM86XDlB+0dZCSJ8Z2QSY=; b=AP56/9bpHktkAuPB0UVy5ZsyR0TIl+8eGnQesmC6QPXl6Zj5qM68+Mq6DRAdE8zkIZ kyF2A59TfCGpkITtBplxMnfWcLUT/aOBBxkJVLJWP7YU+twi8WNy3C2TUQ3zQk/yCg7A 0/arDQ7EZMoZ8QU5opVpIUFTQxK6jsoGXxFDVsLLt3KLcWCCaJCTVALG2MHtG34s/uLC Gr1ZMP6f/tazbfJOxyorpAJeujaf9pSECc32YBhE9RfRr44h3liuQN87o/mFNIVGPN1V pWFZLChIVNKL6jmWgR/HVBBL6cYtDMiWD/UNGtZ6ZwXIvJUPXP/WVPCXCsqmXmJ0THZq NcVQ== X-Gm-Message-State: ALoCoQkVXTfBy/UAvFvhfOHGKLMMItxlX2sqCRZuFcgB8Xxfyu77DeK064pxpqsoJBX2+2a6UWZk X-Received: by 10.182.102.129 with SMTP id fo1mr20842377obb.24.1435686580696; Tue, 30 Jun 2015 10:49:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Tue, 30 Jun 2015 10:49:20 -0700 (PDT) In-Reply-To: <5592D298.6090804@redhat.com> References: <5592B9F9.2090208@redhat.com> <1435682400-7595-1-git-send-email-patrick@parcs.ath.cx> <5592CCC7.5080101@redhat.com> <5592D298.6090804@redhat.com> From: Patrick Palka Date: Tue, 30 Jun 2015 17:49:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00659.txt.bz2 On Tue, Jun 30, 2015 at 1:32 PM, Pedro Alves wrote: > On 06/30/2015 06:10 PM, Patrick Palka wrote: > >>> Hmm, what about when the user changes registers with "print $rax = 1" etc.? >>> Do we end up with stale contents? >> >> Apparently not, thanks to our deprecated_register_changed_hook called >> from value_assign. So many hooks! > > Phew! And luckily there's an equivalent registers_changed observer > we could use instead too. How convenient. > > Patch is OK, just please mention tui_register_changed_hook ... > >> +/* Observer for the before_prompt notification. */ >> + >> +static void >> +tui_before_prompt (const char *current_gdb_prompt) >> +{ >> + /* This refresh is intended to catch changes to the selected frame following >> + a call to "up", "down" or "frame". As such we don't necessarily want to >> + refresh registers here as they could not have changed. Registers will be >> + refreshed after a normal stop. */ > > ... here too. > > Awesome. Glad that this is finally fixed. Me too. The results are quite nice. TUI is silky smooth. > > Thanks, > Pedro Alves >