Re: [PATCH 5/8] gen-pert-test: parallel build support

Patrick Palka
2015-07-25T16:44:29Z

On Tue, Jul 21, 2015 at 9:44 AM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch adds parallel build support for perf testcases.
> To use the existing machinery, GDB_PARALLEL now contains
> the subdirectory in which to put the parallel builds.
>
> 2015-07-20 Doug Evans <dje@google.com>
>
> * Makefile.in (check/%.exp): Pass directory for GDB_PARALLEL.
> (workers/%.worker, build-perf): New rule.
> (GDB_PERFTEST_MODE): New variable.
> (check-perf): Use it.
> (clean): Clean up gdb.perf parallel build subdirs.
> * lib/build-piece.exp: New file.
> * lib/cache.exp (gdb_do_cache): Include $GDB_PARALLEL in path name.
> * lib/gdb.exp (standard_output_file): Include $GDB_PARALLEL in path
> name.
> (standard_temp_file): Ditto.
> (GDB_PARALLEL handling): Make outputs,temp,cache directories as
> subdirs
> of $GDB_PARALLEL.

This patch seems to have caused a number of regressions:

http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/1502
http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/1501
http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/1510

(possibly among others)

Reverting this patch locally makes the regressions disappear for me,
at least on x86_64-m64.