From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48634 invoked by alias); 13 Aug 2015 15:18:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48615 invoked by uid 89); 13 Aug 2015 15:18:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_40,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f48.google.com Received: from mail-oi0-f48.google.com (HELO mail-oi0-f48.google.com) (209.85.218.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 13 Aug 2015 15:18:28 +0000 Received: by oip136 with SMTP id 136so28181810oip.1 for ; Thu, 13 Aug 2015 08:18:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=QMfiJrN08Xi9XVYUmY1M8F+bnZiyWeEZY9lXKzrQtNs=; b=ZtxX3nPYaMA7CO6ErgUpdf/y9YFNkIUthw0i59hl62D/hB/7xq+daAZLbqHRL8L7wM LxSH1uUMHoLffJqvNiuylqXCPA33HZ1trRfvbFPv8QRLjdn1EfEtRJDZMRO8/fNUbOeP m/Vnf3sJFRgbDfM+0mZSjhbqbLRKESGLRIoxNEn+V762hsn4dvXxeyVhu0gih3/KFLe2 XnnBmrAep26bmsFMV3LOUMXVEVaRg9wxwbnj/Tf405L8GJjIVAlvgsUmP2vQOGI9xZaz 2x8hfup+gf50AJAs31O39OjoBZP3VZW+uk1k0l+WKbmD5vKgjiXN5Sil/mxtDtOXOZdE GOvA== X-Gm-Message-State: ALoCoQlWDg3VcmBJohoN5wc3exgw98nO1o6HcOdzFOXX8GO6+62VPFaqnG06wLtFx2ZRMLjhmvcM X-Received: by 10.202.62.11 with SMTP id l11mr31025175oia.103.1439479106679; Thu, 13 Aug 2015 08:18:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.56.202 with HTTP; Thu, 13 Aug 2015 08:18:07 -0700 (PDT) In-Reply-To: <87mvym67i5.fsf_-_@redhat.com> References: <1433878062-23560-1-git-send-email-patrick@parcs.ath.cx> <1434466413-28892-1-git-send-email-patrick@parcs.ath.cx> <87mvym67i5.fsf_-_@redhat.com> From: Patrick Palka Date: Thu, 13 Aug 2015 15:18:00 -0000 Message-ID: Subject: Re: Racy failures on gdb.base/gdbinit-history.exp (native-extended-gdbserver/-m64) (was: Re: [PATCH] Don't truncate the history file when history size is unlimited) To: Sergio Durigan Junior Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-08/txt/msg00355.txt.bz2 On Thu, Jul 23, 2015 at 2:42 PM, Sergio Durigan Junior wrote: > On Tuesday, June 16 2015, Patrick Palka wrote: > >> We still do not handle "set history size unlimited" correctly. In >> particular, after writing to the history file, we truncate the history >> even if it is unlimited. >> >> This patch makes sure that we do not call history_truncate_file() if the >> history is not stifled (i.e. if it's unlimited). This bug causes the >> history file to be truncated to zero on exit when one has "set history >> size unlimited" in their gdbinit file. Although this code exists in GDB >> 7.8, the bug is masked by a pre-existing bug that's been only fixed in >> GDB 7.9 (PR gdb/17820). > > Hey Patrick, > > Looking at the BuildBot logs today, I found that this new test is > failing occasionally on native-extended-gdbserver testing. Take a look > at the following build: > > > > You can see that gdb.base/gdbinit-history.exp failed: > > PASS -> FAIL: gdb.base/gdbinit-history.exp: truncation: appending: server show commands > PASS -> FAIL: gdb.base/gdbinit-history.exp: truncation: creating: server show commands > > The gdb.log is here: > > > > I haven't really investigated to determine what's going on here, but let > me know if you need any help with this. Hi Sergio, Have you seen these spurious FAILs pop up recently? I wonder if the fixes to SIGTERM handling I made a few weeks ago may have fixed this as well.