From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129443 invoked by alias); 30 Jun 2015 14:56:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129434 invoked by uid 89); 30 Jun 2015 14:56:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f53.google.com Received: from mail-oi0-f53.google.com (HELO mail-oi0-f53.google.com) (209.85.218.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 30 Jun 2015 14:56:22 +0000 Received: by oiyy130 with SMTP id y130so9287975oiy.0 for ; Tue, 30 Jun 2015 07:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=3jSaaV/xiTNhCGot4QxyTMlR1vU1wvaTrMzBCN86XSM=; b=L67Bru+6VBSg+dfqGSJ99812uQMfOanXvMZ36kvh7am/04AB+KDKoT/La5gJ2PvbIw J7q/YKTqf6r2BQde8NCJYHA8Lot/1F/ic6n8ypxCyXREJUZ8SFdqfMBcZmDSw4iWGPgx nGS3ApwR52UPEr5FyC4lB23SC1IyjIjjoqdE5JBNDVeAM25lbf7hGyKJCBJ9FL/7isOt MoV0EEsHzpWV91G9nB1wsjJW5YgrPyJxTpJeb5GlvqfUPld4XMEXrAY4yMHAGuAq4wmV JJgJcGvGVF6kCMiPi8ZHZJzFl0HRi6IMm9Oj2hFCx/aujv+bANEAz2waOMryG8U2ZlnP qjJA== X-Gm-Message-State: ALoCoQlNUX6UYq3Ra+AvTTvJ82VmnWscTn+z3U0FNvzFuQbl3PuyYp1a3HkPW6Z9PKcCNszt4zey X-Received: by 10.202.58.215 with SMTP id h206mr5821261oia.23.1435676180445; Tue, 30 Jun 2015 07:56:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.96.167 with HTTP; Tue, 30 Jun 2015 07:56:00 -0700 (PDT) In-Reply-To: References: <1435667837-16337-1-git-send-email-patrick@parcs.ath.cx> <5592A2EE.40900@redhat.com> From: Patrick Palka Date: Tue, 30 Jun 2015 14:56:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-06/txt/msg00641.txt.bz2 On Tue, Jun 30, 2015 at 10:54 AM, Patrick Palka wrote: > On Tue, Jun 30, 2015 at 10:08 AM, Pedro Alves wrote: >> On 06/30/2015 01:37 PM, Patrick Palka wrote: >>> This version adds a tui_normal_stop observer in place of augmenting the >>> tui_on_sync_execution_done observer. And tui_refresh_frame_and_register_information >>> can now be made a static function. >>> >>> The observer takes a print_frame parameter that is supposed to inform us >>> whether the frame should be printed. This boolean seems to only be true for >> >> s/only be true/only be false/ >> >>> when the inferior has exited. Since tui_refresh_frame_and_register_information >>> already handles this case by checking has_stack_frames() this patch elects to >>> ignore this parameter in the observer. >> >> This is OK. I'll take a look at patch 2 soon. >> >> Did you find that we still need deprecated_print_frame_info_listing_hook? > > It still seems to be "necessary" -- at least, I can't outright remove it. > > The only caller of deprecated_print_frame_info_listing_hook is in > print_frame_info and its use looks like this: > > if (deprecated_print_frame_info_listing_hook) > (*deprecated_print_frame_info_listing_hook) (...); > else > { ... other code ... } > > If I remove the hook by replacing the above code with > > { ... other code ... } > > Then a regression occurs: the TUI decides to make sure that the > currently executing line always sits at the top of the window instead > of only scrolling the screen when the currently executing line is not > invisible. I meant to say not _visible_.