From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112232-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7950 invoked by alias); 7 May 2014 16:41:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7941 invoked by uid 89); 7 May 2014 16:41:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-ve0-f175.google.com
Received: from mail-ve0-f175.google.com (HELO mail-ve0-f175.google.com) (209.85.128.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 07 May 2014 16:41:27 +0000
Received: by mail-ve0-f175.google.com with SMTP id jw12so1618325veb.6        for <gdb-patches@sourceware.org>; Wed, 07 May 2014 09:41:24 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.58.211.69 with SMTP id na5mr8041989vec.30.1399480884711; Wed, 07 May 2014 09:41:24 -0700 (PDT)
Received: by 10.58.243.98 with HTTP; Wed, 7 May 2014 09:41:24 -0700 (PDT)
In-Reply-To: <20140507151022.GQ674@redacted.bos.redhat.com>
References: <20140424183510.GI7588@redacted.bos.redhat.com>	<20140430160450.GE2148@redacted.bos.redhat.com>	<20140507135217.GC4063@adacore.com>	<20140507151022.GQ674@redacted.bos.redhat.com>
Date: Wed, 07 May 2014 16:41:00 -0000
Message-ID: <CA+=Sn1meR6moAB5GuXdxHWuaUp1azqsnLqPcp+-OxVrQ4mE3PQ@mail.gmail.com>
Subject: Re: [PATCHv5] aarch64: detect atomic sequences like other ll/sc architectures
From: Andrew Pinski <pinskia@gmail.com>
To: Kyle McMartin <kmcmarti@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-05/txt/msg00070.txt.bz2

On Wed, May 7, 2014 at 8:10 AM, Kyle McMartin <kmcmarti@redhat.com> wrote:
> On Wed, May 07, 2014 at 06:52:17AM -0700, Joel Brobecker wrote:
>> > +  struct gdbarch *gdbarch = get_frame_arch (frame);
>> > +  struct address_space *aspace = get_frame_address_space (frame);
>> > +  enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch);
>>
>> AndrewP said that the code is always LE, so why not just use
>> BFD_ENDIAN_LITTLE in this case, rather than go through
>> byte_order_for_code?
>>
>
> Seemed sensible to do what aarch64_analyze_prologue did, rather than
> hard code it... I'm happy one way or another though.


I think it is clearer if we used byte_order_for_code rather than hard
coding it to little-endian.

Thanks,
Andrew Pinski

>
> regards, Kyle