From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3297 invoked by alias); 9 Dec 2011 03:50:11 -0000 Received: (qmail 3288 invoked by uid 22791); 9 Dec 2011 03:50:10 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-vx0-f169.google.com (HELO mail-vx0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Dec 2011 03:49:57 +0000 Received: by vcbfk26 with SMTP id fk26so2372802vcb.0 for ; Thu, 08 Dec 2011 19:49:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.147.135 with SMTP id l7mr702774vcv.132.1323402596582; Thu, 08 Dec 2011 19:49:56 -0800 (PST) Received: by 10.220.229.66 with HTTP; Thu, 8 Dec 2011 19:49:56 -0800 (PST) Date: Fri, 09 Dec 2011 05:40:00 -0000 Message-ID: Subject: [PATCH] Fix linespec.c vs padding on 32bit targets From: Andrew Pinski To: gdb-patches@sourceware.org, Tom Tromey Content-Type: multipart/mixed; boundary=bcaec54ee644aa068304b3a0ad3e Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00277.txt.bz2 --bcaec54ee644aa068304b3a0ad3e Content-Type: text/plain; charset=UTF-8 Content-length: 428 Hi, The problem here is there is padding in address_entry so iterative_hash_object on the full object cannot be done as the padding would be some junk. This causes lots of gdb failures on mips64-linux-gnu. OK? Tested on mips64-linux-gnu. Thanks, Andrew Pinski PS I don't have write access for gdb. gdb/ChangeLog: * linespec.c (hash_address_entry): Use iterative_hash_object on each field rather than the struct itself. --bcaec54ee644aa068304b3a0ad3e Content-Type: text/plain; charset=US-ASCII; name="fixhash.diff.txt" Content-Disposition: attachment; filename="fixhash.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gvynq3hb0 Content-length: 842 PyAuZWxmcmVhZC5jLnN3cApJbmRleDogbGluZXNwZWMuYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2xpbmVz cGVjLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTMzCmRpZmYgLXUgLXAg LXIxLjEzMyBsaW5lc3BlYy5jCi0tLSBsaW5lc3BlYy5jCTYgRGVjIDIwMTEg MTk6NTc6NDcgLTAwMDAJMS4xMzMKKysrIGxpbmVzcGVjLmMJOSBEZWMgMjAx MSAwMzo0OTowNyAtMDAwMApAQCAtMjUzLDggKzI1Myw5IEBAIHN0YXRpYyBo YXNodmFsX3QKIGhhc2hfYWRkcmVzc19lbnRyeSAoY29uc3Qgdm9pZCAqcCkK IHsKICAgY29uc3Qgc3RydWN0IGFkZHJlc3NfZW50cnkgKmFlcCA9IHA7Ci0K LSAgcmV0dXJuIGl0ZXJhdGl2ZV9oYXNoX29iamVjdCAoKmFlcCwgMCk7Cisg IGhhc2h2YWxfdCBoYXNoOworICBoYXNoID0gaXRlcmF0aXZlX2hhc2hfb2Jq ZWN0IChhZXAtPnBzcGFjZSwgMCk7CisgIHJldHVybiBpdGVyYXRpdmVfaGFz aF9vYmplY3QgKGFlcC0+YWRkciwgaGFzaCk7CiB9CiAKIC8qIEFuIGVxdWFs aXR5IGZ1bmN0aW9uIGZvciBhZGRyZXNzX2VudHJ5LiAgKi8K --bcaec54ee644aa068304b3a0ad3e--