Re: [PATCH 0/3 v3] [AArch64] Support tagged pointer

Pedro Alves
2017-12-08T12:24:45Z

On 12/08/2017 10:04 AM, Yao Qi wrote:
> ARMv8 supports tagged address, that is, the top one byte in address
> is ignored. It is always enabled on aarch64-linux. See
> https://www.kernel.org/doc/Documentation/arm64/tagged-pointers.txt
>
> Some parts of GDB related to address are updated in this patch series,
>
> - Memory access, like command 'x',
> - Setting hw breakpoint on some address,
> - Setting watchpoint on some address,
>
> Address tag is treated as non-significant bits of address, so this patch
> series add a new gdbarch significant_addr_bit, and use it in gdbarch to
> get rid of non-significant bits. This was the suggestion in the v2 review.
> (https://sourceware.org/ml/gdb-patches/2017-10/msg00792.html)

Thanks much for the update. I like this version a lot better.

>
> When I test this patch series, and I find a regression in linespec. I
> posted the fix https://sourceware.org/ml/gdb-patches/2017-12/msg00158.html
> Without this fix, this series causes a regression.

Thanks again for that fix.

Pedro Alves