Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources

Andrew Pinski
2015-01-03T22:55:29Z

On Mon, Nov 24, 2014 at 1:32 PM, Jeff Law <law@redhat.com> wrote:
> On 11/22/14 21:20, Andrew Pinski wrote:
>>
>> Hi,
>> The problem here is here is that OBJCOPY is not being set to the
>> newly built objcopy when compiling libgo. This patch adds
>> OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when
>> libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET.
>>
>> I noticed this issue when building an aarch64 cross compile on an
>> older system where objcopy did not understand aarch64.
>>
>> OK? Bootstrapped and tested on x86_64 with no regressions. Also
>> tested with a combined build for a cross compiler to
>> aarch64-linux-gnu.
>>
>> Thanks,
>> Andrew Pinski
>>
>>
>> * Makefile.def (flags_to_pass): Pass OBJCOPY_FOR_TARGET also.
>> * Makefile.tpl (HOST_EXPORTS): Add OBJCOPY_FOR_TARGET.
>> (BASE_TARGET_EXPORTS): Add OBJCOPY.
>> (OBJCOPY_FOR_TARGET): New variable.
>> (EXTRA_TARGET_FLAGS): Add OBJCOPY.
>> * Makefile.in: Regenerate.
>> * configure.ac: Check for already installed target objcopy.
>> Also GCC_TARGET_TOOL on objcopy.
>> * configure: Regenerate.
>
> OK

Committed to GCC and gdb/binutils repos now.

Thanks,
Andrew

> Jeff
>
>