Re: [PATCH 5/5] Add ATTRIBUTE_PRINTF to trace_start_error

Sergio Durigan Junior
2017-06-14T19:49:20Z

On Saturday, June 10 2017, Simon Marchi wrote:

> clang complains that the fmt passed to vwarning in trace_start_error is
> not a literal. This looks like a fair warning, which can be removed by
> adding ATTRIBUTE_PRINTF to the declaration of trace_start_error.
>
> gdb/ChangeLog:
>
> * nat/fork-inferior.h (trace_start_error): Add ATTRIBUTE_PRINTF.
> ---
> gdb/nat/fork-inferior.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/nat/fork-inferior.h b/gdb/nat/fork-inferior.h
> index 10e3832..d369cff 100644
> --- a/gdb/nat/fork-inferior.h
> +++ b/gdb/nat/fork-inferior.h
> @@ -95,7 +95,7 @@ extern void gdb_flush_out_err ();
> (i.e., when the "traceme_fun" callback is called on fork_inferior)
> and bail out. This function does not return. */
> extern void trace_start_error (const char *fmt, ...)
> - ATTRIBUTE_NORETURN;
> + ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF (1, 2);
>
> /* Like "trace_start_error", but the error message is constructed by
> combining STRING with the system error message for errno. This
> --
> 2.7.4

Thanks, this looks good to me.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible