From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18315 invoked by alias); 21 Aug 2014 06:56:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18306 invoked by uid 89); 21 Aug 2014 06:56:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f175.google.com Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 21 Aug 2014 06:56:39 +0000 Received: by mail-lb0-f175.google.com with SMTP id 10so7595300lbg.6 for ; Wed, 20 Aug 2014 23:56:35 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.152.245.171 with SMTP id xp11mr47703018lac.61.1408604195444; Wed, 20 Aug 2014 23:56:35 -0700 (PDT) Received: by 10.25.23.204 with HTTP; Wed, 20 Aug 2014 23:56:35 -0700 (PDT) In-Reply-To: <85303e79d83947958b01132bc0613e72@BY2PR03MB175.namprd03.prod.outlook.com> References: <1407835166-827-1-git-send-email-catalin.udma@freescale.com> <53E9E1C2.6010707@arm.com> <53E9EB9A.7000304@codesourcery.com> <1407932734.2182.67.camel@soleil> <53EB5C86.4030307@codesourcery.com> <53EB7965.8070208@arm.com> <53F4DC74.8080807@redhat.com> <85303e79d83947958b01132bc0613e72@BY2PR03MB175.namprd03.prod.outlook.com> Date: Thu, 21 Aug 2014 06:56:00 -0000 Message-ID: Subject: Re: [PATCH] aarch64/gdbserver: fix floating point registers display From: Andrew Pinski To: "catalin.udma@freescale.com" Cc: Pedro Alves , Richard Earnshaw , Yao Qi , Philippe Waroquiers , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00463.txt.bz2 On Wed, Aug 20, 2014 at 11:54 PM, catalin.udma@freescale.com wrote: > Thank you all for your comments. > As a follow-up, should I re-submit my patch without changing > cpsr size in regformats/aarch64.dat? ... While the current cpsr > size de-synchronization would be fixed by reverting the patch > we are discussing about? If we revert the patch is someone going to fix big-endian support then since that is the original why it was requested. Thanks, Andrew > > Regards, > Catalin > >> -----Original Message----- >> From: Pedro Alves [mailto:palves@redhat.com] >> Sent: Wednesday, August 20, 2014 8:36 PM >> To: Richard Earnshaw; Yao Qi >> Cc: Philippe Waroquiers; Udma Catalin-Dan-B32721; gdb- >> patches@sourceware.org >> Subject: Re: [PATCH] aarch64/gdbserver: fix floating point registers >> display >> >> On 08/13/2014 03:42 PM, Richard Earnshaw wrote: >> > On 13/08/14 13:39, Yao Qi wrote: >> >> On 08/13/2014 08:25 PM, Philippe Waroquiers wrote: >> >>> The 'it' in 'fix it' is ambiguous to me. >> >>> Does the 'it' mean: >> >>> fix aarch64-core.xml to change cpsr to 32 bits ? >> >> >> >> That was what I meant, however .... >> >> >> >>> or does that confirm the initial proposal i.e. >> >>> fix e.g. aarch64.dat to change cpsr to 64 bits ? >> >> >> >> ... I find a patch changed cpsr to 64 bit in last Dec. >> >> >> >> [PATCH] AARCH64: Change cpsr type to be 64bit. >> >> https://sourceware.org/ml/gdb-patches/2013-12/msg00720.html >> >> >> >> and looks aarch64.dat was not updated together in this patch. >> >> >> >> I am sure that aarch64.dat and aarch64-core.xml are not in sync, >> >> but I don't know which way to go, sorry. >> >> >> > >> > Changing the XML doesn't sound like the right way forward, the XML can >> > be embedded into other components as part of the register description >> > interface. >> > >> > Hmm, I can't see where anyone ever formally approved that change. In >> > fact, Mark K commented at the time: >> > >> > "Basing GDB's fundamentals on a particular OS's ptrace(2) >> > implementation is a bad idea." >> > >> > So it seems to me that that change was indeed incorrect and should >> > probably be reverted (at least in its current incarnation). >> >> I agree, and I'm surprised to learn the patch went in. :-/ >> >> Thanks, >> Pedro Alves >