From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12425 invoked by alias); 5 Jun 2014 20:36:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12413 invoked by uid 89); 5 Jun 2014 20:36:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ve0-f176.google.com Received: from mail-ve0-f176.google.com (HELO mail-ve0-f176.google.com) (209.85.128.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 05 Jun 2014 20:35:57 +0000 Received: by mail-ve0-f176.google.com with SMTP id jz11so1911458veb.35 for ; Thu, 05 Jun 2014 13:35:54 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.220.99.73 with SMTP id t9mr72891vcn.76.1402000554673; Thu, 05 Jun 2014 13:35:54 -0700 (PDT) Received: by 10.58.243.98 with HTTP; Thu, 5 Jun 2014 13:35:54 -0700 (PDT) In-Reply-To: <20140605200621.GN15355@redacted.bos.redhat.com> References: <20140603050011.GA15355@redacted.bos.redhat.com> <20140603050314.GC15355@redacted.bos.redhat.com> <20140603145108.GF15355@redacted.bos.redhat.com> <20140605200621.GN15355@redacted.bos.redhat.com> Date: Thu, 05 Jun 2014 20:36:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] aarch64: implement walking over the stack protector From: Andrew Pinski To: Kyle McMartin Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00284.txt.bz2 On Thu, Jun 5, 2014 at 1:06 PM, Kyle McMartin wrote: > On Tue, Jun 03, 2014 at 10:51:08AM -0400, Kyle McMartin wrote: >> On Mon, Jun 02, 2014 at 10:42:32PM -0700, Andrew Pinski wrote: >> > > + adrp x0, __stack_chk_guard >> > > + add x0, x0, #:lo12:__stack_chk_guard >> > > + ldr x0, [x0] >> > > + str x0, [x29, #end-of-stack] >> > >> > Can you expand this for ILP32? The sequence is the same except to use >> > w0 instead of x0. Otherwise I can put it on my todo list to after I >> > submit the gdb support for ILP32. >> > >> >> I'll look into it. Thanks Andrew. >> > > Finally got a toolchain built that supports ilp32... looks like the > existing code should work for it. The only difference (not sure if it's > because of gcc HEAD or what) is using w1 instead of x0 repeated for the > ldr/str, which looks to be satisfied by the rt/rt2 tests and size=10 > included in the decode_masked_match. I'll try to build a static ilp32 > binary to test it meanwhile, but I've had some other issues with gcc > HEAD. Glibc support is not there yet though. I will take over the issue with ILP32 then. When this goes in, can you file a bug and assign it to me (pinskia@gcc.gnu.org I think is my email for sourceware bugzilla)? Thanks, Andrew Pinski > > regards, Kyle