From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-115259-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9716 invoked by alias); 25 Aug 2014 21:39:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9705 invoked by uid 89); 25 Aug 2014 21:39:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-la0-f46.google.com
Received: from mail-la0-f46.google.com (HELO mail-la0-f46.google.com) (209.85.215.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 25 Aug 2014 21:39:50 +0000
Received: by mail-la0-f46.google.com with SMTP id b8so14178803lan.33        for <gdb-patches@sourceware.org>; Mon, 25 Aug 2014 14:39:46 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.152.42.175 with SMTP id p15mr10682416lal.73.1409002786519; Mon, 25 Aug 2014 14:39:46 -0700 (PDT)
Received: by 10.25.23.204 with HTTP; Mon, 25 Aug 2014 14:39:46 -0700 (PDT)
In-Reply-To: <yjt2sikkqrqf.fsf@ruffy.mtv.corp.google.com>
References: <yjt2sikkqrqf.fsf@ruffy.mtv.corp.google.com>
Date: Mon, 25 Aug 2014 21:39:00 -0000
Message-ID: <CA+=Sn1=5iyT0d_8BWfVkh-nCMGcFABDe3vQ7QfuMdsBHyd=oDQ@mail.gmail.com>
Subject: Re: [COMMITTED PATCH] Fix clang compilation errors in gdb.mi/basics.c
From: Andrew Pinski <pinskia@gmail.com>
To: Doug Evans <dje@google.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-08/txt/msg00524.txt.bz2

On Mon, Aug 25, 2014 at 12:44 PM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> This patch gets a few more tests working with clang.


Seems like maybe we should be compiling with -w for clang instead of
trying to change the testcase itself.  Because now we don't know if
the change to the testcase changed the behavior it was testing or not.

Thanks,
Andrew

>
> gdb compile failed, ../../../binutils-gdb/gdb/testsuite/gdb.mi/basics.c:32:1: warning: type
>       specifier missing, defaults to 'int' [-Wimplicit-int]
> callee3 (char *strarg)
> ^
> ../../../binutils-gdb/gdb/testsuite/gdb.mi/basics.c:35:1: warning: control
>       reaches end of non-void function [-Wreturn-type]
> }
> ^
> ...
>
> 2014-08-25  Doug Evans  <dje@google.com>
>
>         * gdb.mi/basics.c (callee3, callee2, callee1): Specify result type.
>         (main): Ditto.
>
> diff --git a/gdb/testsuite/gdb.mi/basics.c b/gdb/testsuite/gdb.mi/basics.c
> index 0a4f9de..0eabcd1 100644
> --- a/gdb/testsuite/gdb.mi/basics.c
> +++ b/gdb/testsuite/gdb.mi/basics.c
> @@ -29,17 +29,17 @@ int callee4 (void)
>    C = A + B;
>    return 0;
>  }
> -callee3 (char *strarg)
> +void callee3 (char *strarg)
>  {
>    callee4 ();
>  }
>
> -callee2 (int intarg, char *strarg)
> +void callee2 (int intarg, char *strarg)
>  {
>    callee3 (strarg);
>  }
>
> -callee1 (int intarg, char *strarg, double fltarg)
> +void callee1 (int intarg, char *strarg, double fltarg)
>  {
>    callee2 (intarg, strarg);
>  }
> @@ -57,7 +57,7 @@ void do_nothing (void)
>  {
>  }
>
> -main ()
> +int main ()
>  {
>    callee1 (2, "A string argument.", 3.5);
>    callee1 (2, "A string argument.", 3.5);