From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27611 invoked by alias); 19 Nov 2012 15:34:41 -0000 Received: (qmail 27467 invoked by uid 22791); 19 Nov 2012 15:34:39 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from ausxipps301.us.dell.com (HELO ausxipps301.us.dell.com) (143.166.148.223) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Nov 2012 15:34:04 +0000 X-Loopcount0: from 10.175.216.250 From: To: CC: Subject: Re: [PATCH] Python 3 support, part 2 (testsuite part) Date: Mon, 19 Nov 2012 15:34:00 -0000 Message-ID: References: <87vcd5tkc0.fsf@fleche.redhat.com> In-Reply-To: <87vcd5tkc0.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" Content-ID: <284EC5F1AB131849AD31FA65E976D070@dell.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00507.txt.bz2 On Nov 16, 2012, at 2:32 PM, Tom Tromey wrote: >>>>>> "Paul" =3D=3D writes: >=20 > Paul> Most of the changes are for turning "print" from a statement into > Paul> a function call. There are also some changes to handle the fact > Paul> that "str" is now Unicode and the separate "unicode" type is gone, > Paul> similarly "int" is now long integer and "long" is gone. >=20 > In the future, please split up patches like this. > The patch in its present form is difficult to read. > For example, all the "print" changes are obvious -- as a separate patch > those could get a simple "ok" without much fuss. Thanks for the helpful comment. I don't have experience with changes of th= is size so I'm learning the best way to handle them. >=20 > Paul> Ok to commit? >=20 > Yes, thanks. >=20 > Tom Great. What about the other half?=20=20 paul