Re: [RFA] New port: CR16: BFD Changes required by the gdb port

Tom Tromey
2013-01-02T14:19:21Z

>>>>> "Kaushik" == Kaushik Phatak <Kaushik.Phatak@kpitcummins.com> writes:

Pedro> It'd be nice if all these exported symbols were prefixed, to avoid
Pedro> namespace collisions.

Kaushik> I have added 'cr16_' as a prefix to all these exported symbols.

Kaushik> (make_instruction,match_opcode): Added function prototypes.

What about these?

Kaushik> /* Current opcode table entry we're disassembling. */
Kaushik> const inst *instruction;

I don't know opcodes, but it seems to me that it is best if a library
either makes symbols static or gives them a name prefix.
Otherwise you are going to run into clashes at link time.

Tom