From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15145 invoked by alias); 9 Oct 2012 13:20:34 -0000 Received: (qmail 15023 invoked by uid 22791); 9 Oct 2012 13:20:30 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from am1ehsobe004.messaging.microsoft.com (HELO am1outboundpool.messaging.microsoft.com) (213.199.154.207) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Oct 2012 13:20:25 +0000 Received: from mail79-am1-R.bigfish.com (10.3.201.250) by AM1EHSOBE004.bigfish.com (10.3.204.24) with Microsoft SMTP Server id 14.1.225.23; Tue, 9 Oct 2012 13:20:23 +0000 Received: from mail79-am1 (localhost [127.0.0.1]) by mail79-am1-R.bigfish.com (Postfix) with ESMTP id 6FF148022C; Tue, 9 Oct 2012 13:20:23 +0000 (UTC) X-Forefront-Antispam-Report: CIP:59.163.77.45;KIP:(null);UIP:(null);IPV:NLI;H:KCHJEXHC01.kpit.com;RD:59.163.77.45.static.vsnl.net.in;EFVD:NLI X-SpamScore: -1 X-BigFish: VPS-1(zz1418Izz1202h1d1ah1d2ahzzz2dh2a8h668h839h944hd25hf0ah107ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1155h) Received: from mail79-am1 (localhost.localdomain [127.0.0.1]) by mail79-am1 (MessageSwitch) id 1349788816957141_27552; Tue, 9 Oct 2012 13:20:16 +0000 (UTC) Received: from AM1EHSMHS007.bigfish.com (unknown [10.3.201.241]) by mail79-am1.bigfish.com (Postfix) with ESMTP id E395F30009B; Tue, 9 Oct 2012 13:20:16 +0000 (UTC) Received: from KCHJEXHC01.kpit.com (59.163.77.45) by AM1EHSMHS007.bigfish.com (10.3.207.107) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 9 Oct 2012 13:20:14 +0000 Received: from KCHJEXMB02.kpit.com ([169.254.2.237]) by KCHJEXHC01.kpit.com ([172.10.15.73]) with mapi id 14.01.0289.001; Tue, 9 Oct 2012 18:50:14 +0530 From: Kaushik Phatak To: Joel Brobecker CC: "gdb-patches@sourceware.org" , Yao Qi Subject: RE: [RFA 3/5] New port: CR16: gdb port Date: Tue, 09 Oct 2012 13:20:00 -0000 Message-ID: References: <20121004144806.GO3028@adacore.com> <20121005122044.GS3028@adacore.com> In-Reply-To: <20121005122044.GS3028@adacore.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: kpitcummins.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00149.txt.bz2 Hi Joel, > I think that there is a log of stuff in cr16-tdep that is actually > linux-specific, and that you should move to cr16-linux-tdep.c I have moved register initializations into the cr16-linux-tdep.c. This=20 was also recommended by Yao.=20 > Take a look at how sparc is organized, or maybe amd64. The other targets like amd64 have plenty on stuff in this file, however it = is unrelated to this port. I feel the updated cr16-linux-tdep.c file should al= low it to build on top of the bareboard one.=20 > Needs a comment. For global variables and constants Added comments at appropriate location in the code. > have an empty line between the documentation/comment and the function. Added empty lines between comment and functions >> +extern ins currInsn; > This looks strange. Why extern, and where would they come from? I have added comments for this and removed the unnecessary externs here. > Don't these functions have declarations in opcode? This is really ugly These prototypes were added recently and are part of a bfd patch. I forgot to remove these in the last version. > +extern const gdb_byte breakpoint_linux[]; I have removed this as it is not used in the later versions of the patch. > The last line isn't aligned properly. > So this paragraph needs to be reformatted. > requires that 2 spaces be used after periods. > Please also move the closing "*/" to the end of the last line > The '{' needs to be on the next line. > Trailing space at the end of the second line > move the closing */ to the second line as well. > And empty line between comment > moved the last comment to just above the field I have made another pass over the code and have taken care of the above=20 mentioned points and other formatting nits which I could find. Thanks. I have not attached my updated patch here. I am working on Yao's comments and will attach it in that reply. Regards, Kaushik