From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32479 invoked by alias); 30 Aug 2012 05:23:29 -0000 Received: (qmail 32469 invoked by uid 22791); 30 Aug 2012 05:23:28 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from tx2ehsobe001.messaging.microsoft.com (HELO tx2outboundpool.messaging.microsoft.com) (65.55.88.11) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 30 Aug 2012 05:23:05 +0000 Received: from mail52-tx2-R.bigfish.com (10.9.14.254) by TX2EHSOBE011.bigfish.com (10.9.40.31) with Microsoft SMTP Server id 14.1.225.23; Thu, 30 Aug 2012 05:23:04 +0000 Received: from mail52-tx2 (localhost [127.0.0.1]) by mail52-tx2-R.bigfish.com (Postfix) with ESMTP id 1EF8434009A; Thu, 30 Aug 2012 05:23:04 +0000 (UTC) X-Forefront-Antispam-Report: CIP:59.163.77.45;KIP:(null);UIP:(null);IPV:NLI;H:KCHJEXHC01.kpit.com;RD:59.163.77.45.static.vsnl.net.in;EFVD:NLI X-SpamScore: 0 X-BigFish: VPS0(zzc85fhzz1202hzz8275bhz2dh2a8h668h839hd25hf0ah107ah34h1155h) Received: from mail52-tx2 (localhost.localdomain [127.0.0.1]) by mail52-tx2 (MessageSwitch) id 1346304182344800_30046; Thu, 30 Aug 2012 05:23:02 +0000 (UTC) Received: from TX2EHSMHS012.bigfish.com (unknown [10.9.14.236]) by mail52-tx2.bigfish.com (Postfix) with ESMTP id 50954240043; Thu, 30 Aug 2012 05:23:02 +0000 (UTC) Received: from KCHJEXHC01.kpit.com (59.163.77.45) by TX2EHSMHS012.bigfish.com (10.9.99.112) with Microsoft SMTP Server (TLS) id 14.1.225.23; Thu, 30 Aug 2012 05:23:02 +0000 Received: from KCHJEXMB03.kpit.com ([169.254.4.166]) by KCHJEXHC01.kpit.com ([172.10.15.73]) with mapi id 14.01.0289.001; Thu, 30 Aug 2012 10:53:00 +0530 From: Kaushik Phatak To: Mike Frysinger CC: "gdb-patches@sourceware.org" , Yao Qi Subject: RE: [RFC] New GDB Port CR16 Date: Thu, 30 Aug 2012 05:23:00 -0000 Message-ID: References: <503B9E59.6050502@codesourcery.com> In-Reply-To: Content-Type: multipart/mixed; boundary="_002_C6CA53A2A46BA7469348BDBD663AB65845B2866DKCHJEXMB03kpitc_" MIME-Version: 1.0 X-OriginatorOrg: kpitcummins.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00862.txt.bz2 --_002_C6CA53A2A46BA7469348BDBD663AB65845B2866DKCHJEXMB03kpitc_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 484 Hi Mike, Thanks for detailed review. > needs a space there: > + switch(a) > just one space after "case" > also, the comment should have two spaces before the */: I have fixed the above three issues in the attached patch. If everything else looks OK, could you please check these in for me as I do not have write privileges to the repository? I will create a separate thread for cr16 gdb related patches. Best Regards, Kaushik KPIT Cummins Infosystems Ltd www.kpitcummins.com --_002_C6CA53A2A46BA7469348BDBD663AB65845B2866DKCHJEXMB03kpitc_ Content-Type: application/octet-stream; name="cr16_sim.diff" Content-Description: cr16_sim.diff Content-Disposition: attachment; filename="cr16_sim.diff"; size=4001; creation-date="Tue, 28 Aug 2012 13:26:21 GMT"; modification-date="Thu, 30 Aug 2012 05:00:39 GMT" Content-Transfer-Encoding: base64 Content-length: 5425 LS0tIGdkYl9zcmMub3JpZy9zaW0vY29tbW9uL2dlbm5sdHZhbHMuc2gJMjAx Mi0wMy0xOSAxMDoyNDo0OC4wMDAwMDAwMDAgKzA1MzAKKysrIC4vZ2RiX3Ny Yy9zaW0vY29tbW9uL2dlbm5sdHZhbHMuc2gJMjAxMi0wOC0xNyAxNTozNTox NS4wMDAwMDAwMDAgKzA1MzAKQEAgLTQxLDcgKzQxLDcgQEAgJHNoZWxsICR7 c3JjY29tfS9nZW50dmFscy5zaCAkdGFyZ2V0IHN5cwogIyBPQlNPTEVURSAk c2hlbGwgJHtzcmNjb219L2dlbnR2YWxzLnNoICR0YXJnZXQgc3lzICR7c3Jj cm9vdH0vJGRpciBcCiAjIE9CU09MRVRFIAkic3lzY2FsbC5oIiAnU1lTX1tf WzphbG51bTpdXSonICIke2NwcH0iCiAKLWRpcj1saWJnbG9zcyB0YXJnZXQ9 Y3IxNgorZGlyPWxpYmdsb3NzL2NyMTYvc3lzIHRhcmdldD1jcjE2CiAkc2hl bGwgJHtzcmNjb219L2dlbnR2YWxzLnNoICR0YXJnZXQgc3lzICR7c3Jjcm9v dH0vJGRpciBcCiAJInN5c2NhbGwuaCIgJ1NZU19bX1s6YWxudW06XV0qJyAi JHtjcHB9IgogCi0tLSBnZGJfc3JjLm9yaWcvc2ltL2NvbW1vbi9ubHR2YWxz LmRlZgkyMDExLTA1LTI2IDIzOjUwOjEzLjAwMDAwMDAwMCArMDUzMAorKysg Li9nZGJfc3JjL3NpbS9jb21tb24vbmx0dmFscy5kZWYJMjAxMi0wOC0xNyAx NTozNjozOS4wMDAwMDAwMDAgKzA1MzAKQEAgLTIxOCwzMCArMjE4LDM0IEBA CiAjaWZkZWYgc3lzX2RlZnMKIC8qIGZyb20gc3lzY2FsbC5oICovCiAvKiBi ZWdpbiBjcjE2IHN5cyB0YXJnZXQgbWFjcm9zICovCi0geyAiU1lTX2FyZ2Mi LCAyMiB9LAotIHsgIlNZU19hcmduIiwgMjQgfSwKLSB7ICJTWVNfYXJnbmxl biIsIDIzIH0sCi0geyAiU1lTX2FyZ3YiLCAxMyB9LAotIHsgIlNZU19hcmd2 bGVuIiwgMTIgfSwKLSB7ICJTWVNfY2hkaXIiLCAxNCB9LAotIHsgIlNZU19j aG1vZCIsIDE2IH0sCi0geyAiU1lTX2Nsb3NlIiwgMyB9LAotIHsgIlNZU19l eGl0IiwgMSB9LAotIHsgIlNZU19mc3RhdCIsIDEwIH0sCi0geyAiU1lTX2dl dHBpZCIsIDggfSwKLSB7ICJTWVNfZ2V0dGltZW9mZGF5IiwgMTkgfSwKLSB7 ICJTWVNfa2lsbCIsIDkgfSwKLSB7ICJTWVNfbGluayIsIDIxIH0sCi0geyAi U1lTX2xzZWVrIiwgNiB9LAotIHsgIlNZU19vcGVuIiwgMiB9LAotIHsgIlNZ U19yZWFkIiwgNCB9LAotIHsgIlNZU19yZWNvbmZpZyIsIDI1IH0sCi0geyAi U1lTX3N0YXQiLCAxNSB9LAotIHsgIlNZU190aW1lIiwgMTggfSwKLSB7ICJT WVNfdGltZXMiLCAyMCB9LAotIHsgIlNZU191bmxpbmsiLCA3IH0sCi0geyAi U1lTX3V0aW1lIiwgMTcgfSwKLSB7ICJTWVNfd3JpdGUiLCA1IH0sCisgeyAi U1lTX0FSRyIsIDI0IH0sCisgeyAiU1lTX2NoZGlyIiwgMTIgfSwKKyB7ICJT WVNfY2htb2QiLCAxNSB9LAorIHsgIlNZU19jaG93biIsIDE2IH0sCisgeyAi U1lTX2Nsb3NlIiwgMHg0MDIgfSwKKyB7ICJTWVNfY3JlYXRlIiwgOCB9LAor IHsgIlNZU19leGVjdiIsIDExIH0sCisgeyAiU1lTX2V4ZWN2ZSIsIDU5IH0s CisgeyAiU1lTX2V4aXQiLCAweDQxMCB9LAorIHsgIlNZU19mb3JrIiwgMiB9 LAorIHsgIlNZU19mc3RhdCIsIDIyIH0sCisgeyAiU1lTX2dldHBpZCIsIDIw IH0sCisgeyAiU1lTX2lzYXR0eSIsIDIxIH0sCisgeyAiU1lTX2tpbGwiLCA2 MCB9LAorIHsgIlNZU19saW5rIiwgOSB9LAorIHsgIlNZU19sc2VlayIsIDB4 NDA1IH0sCisgeyAiU1lTX21rbm9kIiwgMTQgfSwKKyB7ICJTWVNfb3BlbiIs IDB4NDAxIH0sCisgeyAiU1lTX3BpcGUiLCA0MiB9LAorIHsgIlNZU19yZWFk IiwgMHg0MDMgfSwKKyB7ICJTWVNfcmVuYW1lIiwgMHg0MDYgfSwKKyB7ICJT WVNfc3RhdCIsIDM4IH0sCisgeyAiU1lTX3RpbWUiLCAweDMwMCB9LAorIHsg IlNZU191bmxpbmsiLCAweDQwNyB9LAorIHsgIlNZU191dGltZSIsIDIwMSB9 LAorIHsgIlNZU193YWl0IiwgMjAyIH0sCisgeyAiU1lTX3dhaXQ0IiwgNyB9 LAorIHsgIlNZU193cml0ZSIsIDB4NDA0IH0sCiAvKiBlbmQgY3IxNiBzeXMg dGFyZ2V0IG1hY3JvcyAqLwogI2VuZGlmCiAjZW5kaWYKLS0tIGdkYl9zcmMu b3JpZy9zaW0vY3IxNi9jcjE2X3NpbS5oCTIwMTItMDEtMDQgMTM6NTg6MDcu MDAwMDAwMDAwICswNTMwCisrKyAuL2dkYl9zcmMvc2ltL2NyMTYvY3IxNl9z aW0uaAkyMDEyLTA4LTI0IDE3OjIyOjI0LjAwMDAwMDAwMCArMDUzMApAQCAt NDcyLDMgKzQ3Miw5IEBAIGV4dGVybiB2b2lkIHdyaXRlX2xvbmdsb25nIFBB UkFNUyAoKHVpbnQKICAgIFBTUiBpcyBtYXNrZWQgZm9yIHplcm8gYml0cy4g Ki8KIAogZXh0ZXJuIGNyZWdfdCBtb3ZlX3RvX2NyIChpbnQgY3IsIGNyZWdf dCBtYXNrLCBjcmVnX3QgdmFsLCBpbnQgcHN3X2h3X3ApOworCisjaWZuZGVm IFNJR1RSQVAKKyNkZWZpbmUgU0lHVFJBUCA1CisjZW5kaWYKKy8qIFNwZWNp YWwgcHVycG9zZSB0cmFwICAqLworI2RlZmluZSBUUkFQX0JSRUFLUE9JTlQg OAotLS0gZ2RiX3NyYy5vcmlnL3NpbS9jcjE2L2ludGVycC5jCTIwMTItMDYt MTggMDU6MDQ6MTcuMDAwMDAwMDAwICswNTMwCisrKyAuL2dkYl9zcmMvc2lt L2NyMTYvaW50ZXJwLmMJMjAxMi0wOC0xNyAxNTo0MTozNS4wMDAwMDAwMDAg KzA1MzAKQEAgLTExOTIsNyArMTE5MiwxMSBAQCBzaW1fcmVzdW1lIChTSU1f REVTQyBzZCwgaW50IHN0ZXAsIGludCBzCiAgICAgICBpYWRkciA9IGltZW1f YWRkciAoKHVpbnQzMilQQyk7CiAgICAgICBpZiAoaWFkZHIgPT0gU3RhdGUu bWVtLmZhdWx0KQogICAgICAgICB7CisjaWZkZWYgU0lHQlVTCiAgICAgICAg ICAgU3RhdGUuZXhjZXB0aW9uID0gU0lHQlVTOworI2Vsc2UKKyAgICAgICAg ICBTdGF0ZS5leGNlcHRpb24gPSBTSUdTRUdWOworI2VuZGlmCiAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIH0KICAKQEAgLTE1NDgsNiArMTU1MiwxMSBA QCBzaW1fc3RvcmVfcmVnaXN0ZXIgKHNkLCBybiwgbWVtb3J5LCBsZW5nCiAg IHJldHVybiBzaXplOwogfQogCitjaGFyICoqCitzaW1fY29tcGxldGVfY29t bWFuZCAoU0lNX0RFU0Mgc2QsIGNoYXIgKnRleHQsIGNoYXIgKndvcmQpCit7 CisgIHJldHVybiBOVUxMOworfQogCiB2b2lkCiBzaW1fZG9fY29tbWFuZCAo c2QsIGNtZCkKLS0tIGdkYl9zcmMub3JpZy9zaW0vY3IxNi9zaW1vcHMuYwky MDEyLTAxLTA0IDEzOjU4OjA3LjAwMDAwMDAwMCArMDUzMAorKysgLi9nZGJf c3JjL3NpbS9jcjE2L3NpbW9wcy5jCTIwMTItMDgtMzAgMTA6Mjk6MjguMDAw MDAwMDAwICswNTMwCkBAIC01MDU5LDYgKzUwNTksOCBAQCBPUF8xNENfMTQg KCkKIHZvaWQKIE9QX0NfQyAoKQogeworICB1aW50MzIgdG1wOworICB1aW50 MTYgYTsKICAgdHJhY2VfaW5wdXQgKCJleGNwIiwgT1BfQ09OU1RBTlQ0LCBP UF9WT0lELCBPUF9WT0lEKTsKICAgc3dpdGNoIChPUFswXSkKICAgICB7CkBA IC01NDY1LDkgKzU0NjcsMjQgQEAgT1BfQ19DICgpCiAjZW5kaWYKIAkgICAg CiAJICBkZWZhdWx0OgotCSAgICBjcjE2X2NhbGxiYWNrLT5lcnJvciAoY3Ix Nl9jYWxsYmFjaywgIlVua25vd24gc3lzY2FsbCAlZCIsIEZVTkMpOworCSAg ICBhID0gT1BbMF07CisJICAgIHN3aXRjaCAoYSkKKwkgICAgeworCSAgICAg IGNhc2UgVFJBUF9CUkVBS1BPSU5UOgorCQlTdGF0ZS5leGNlcHRpb24gPSBT SUdUUkFQOworCQl0bXAgPSAoUEMpOworCQlKTVAodG1wKTsKKwkJdHJhY2Vf b3V0cHV0X3ZvaWQgKCk7CisJCWJyZWFrOworCSAgICAgIGNhc2UgU0lHVFJB UDogIC8qIHN1cGVydmlzb3IgY2FsbCA/ICAqLworCQlTdGF0ZS5leGNlcHRp b24gPSBTSUdfQ1IxNl9FWElUOworCQl0cmFjZV9vdXRwdXRfdm9pZCAoKTsK KwkJYnJlYWs7CisJICAgICAgZGVmYXVsdDoKKwkJY3IxNl9jYWxsYmFjay0+ ZXJyb3IgKGNyMTZfY2FsbGJhY2ssICJVbmtub3duIHN5c2NhbGwgJWQiLCBG VU5DKTsKKwkJYnJlYWs7CisJICAgIH0KIAkgIH0KLQogCWlmICgodWludDE2 KSByZXN1bHQgPT0gKHVpbnQxNikgLTEpCiAJICBSRVRFUlIgKGNyMTZfY2Fs bGJhY2stPmdldF9lcnJubyhjcjE2X2NhbGxiYWNrKSk7CiAJZWxzZQo= --_002_C6CA53A2A46BA7469348BDBD663AB65845B2866DKCHJEXMB03kpitc_--