Hi Mike, Thanks for detailed review. > needs a space there: > + switch(a) > just one space after "case" > also, the comment should have two spaces before the */: I have fixed the above three issues in the attached patch. If everything else looks OK, could you please check these in for me as I do not have write privileges to the repository? I will create a separate thread for cr16 gdb related patches. Best Regards, Kaushik KPIT Cummins Infosystems Ltd www.kpitcummins.com