From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31973 invoked by alias); 28 Aug 2012 14:47:14 -0000 Received: (qmail 31962 invoked by uid 22791); 28 Aug 2012 14:47:13 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from co1ehsobe006.messaging.microsoft.com (HELO co1outboundpool.messaging.microsoft.com) (216.32.180.189) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Aug 2012 14:46:59 +0000 Received: from mail12-co1-R.bigfish.com (10.243.78.234) by CO1EHSOBE013.bigfish.com (10.243.66.76) with Microsoft SMTP Server id 14.1.225.23; Tue, 28 Aug 2012 14:46:58 +0000 Received: from mail12-co1 (localhost [127.0.0.1]) by mail12-co1-R.bigfish.com (Postfix) with ESMTP id B6B4C4009F; Tue, 28 Aug 2012 14:46:58 +0000 (UTC) X-Forefront-Antispam-Report: CIP:59.163.77.45;KIP:(null);UIP:(null);IPV:NLI;H:KCHJEXHC01.kpit.com;RD:59.163.77.45.static.vsnl.net.in;EFVD:NLI X-SpamScore: -10 X-BigFish: VPS-10(zz1b0aL936eIc85fh154dMzz1202hzz8275bhz2dh2a8h668h839hd25hf0ah107ah34h1155h) Received: from mail12-co1 (localhost.localdomain [127.0.0.1]) by mail12-co1 (MessageSwitch) id 1346165216353307_4835; Tue, 28 Aug 2012 14:46:56 +0000 (UTC) Received: from CO1EHSMHS025.bigfish.com (unknown [10.243.78.243]) by mail12-co1.bigfish.com (Postfix) with ESMTP id 4E8A68009B; Tue, 28 Aug 2012 14:46:56 +0000 (UTC) Received: from KCHJEXHC01.kpit.com (59.163.77.45) by CO1EHSMHS025.bigfish.com (10.243.66.35) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 28 Aug 2012 14:46:55 +0000 Received: from KCHJEXMB03.kpit.com ([169.254.4.166]) by KCHJEXHC01.kpit.com ([172.10.15.73]) with mapi id 14.01.0289.001; Tue, 28 Aug 2012 20:15:51 +0530 From: Kaushik Phatak To: "gdb-patches@sourceware.org" CC: Yao Qi , Mike Frysinger Subject: RE: [RFC] New GDB Port CR16 Date: Tue, 28 Aug 2012 14:47:00 -0000 Message-ID: References: <503B9E59.6050502@codesourcery.com> In-Reply-To: <503B9E59.6050502@codesourcery.com> Content-Type: multipart/mixed; boundary="_002_C6CA53A2A46BA7469348BDBD663AB65845B28084KCHJEXMB03kpitc_" MIME-Version: 1.0 X-OriginatorOrg: kpitcummins.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00833.txt.bz2 --_002_C6CA53A2A46BA7469348BDBD663AB65845B28084KCHJEXMB03kpitc_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 1593 Hi Mike,Yao, Thanks for all your comments.=20 > might be nice if you were to split them up and commit them separately I have attached an updated patch with purely sim port related changes. The patch changes the following files in gdb-sim /sim/common/gennltvals.sh /sim/common/nltvals.def /sim/cr16/cr16_sim.h /sim/cr16/interp.c /sim/cr16/simops.c I have tried to address the other points as follows, > but that should be "(void)". i imagine this sim port probably has=20 > a bunch of those bugs lurking though. Yes, but I have not tinkered with this as yet. > pretty sure the indentation here is incorrect.=20 My mistake. This was a switch inside a switch and my case statements were aligned with the first level case statements. This is now fixed. > please do not use C++ style comments This is now fixed. > this new local prototype makes no sense. just delete it. OK. I will create separate binutils patch with these changes and submit it to binutils at sourceware dot org as per Yao Qi's suggestion. > The changes for top-level configure stuff should be submitted to=20 > gcc-patches with changelog entry. Thanks Yao for these patch submission tips.=20 2012-08-28 Kaushik Phatak sim/common/ * gennltvals.sh: Use libgloss/syscall.h for cr16. * nltvals.def: Regenerate. sim/cr16/ChangeLog: * interp.c (sim_complete_command): New stub function. * cr16_sim.h : Add defines for TRAP handling. * simops.c: Breakpoint handling code. Thanks & Best Regards, Kaushik kaushik.phatak@kpitcummins.com KPIT Cummins Infosystems Ltd www.kpitcummins.com --_002_C6CA53A2A46BA7469348BDBD663AB65845B28084KCHJEXMB03kpitc_ Content-Type: application/octet-stream; name="cr16_sim.diff" Content-Description: cr16_sim.diff Content-Disposition: attachment; filename="cr16_sim.diff"; size=4001; creation-date="Tue, 28 Aug 2012 13:26:21 GMT"; modification-date="Tue, 28 Aug 2012 13:30:01 GMT" Content-Transfer-Encoding: base64 Content-length: 5425 LS0tIGdkYl9zcmMub3JpZy9zaW0vY29tbW9uL2dlbm5sdHZhbHMuc2gJMjAx Mi0wMy0xOSAxMDoyNDo0OC4wMDAwMDAwMDAgKzA1MzAKKysrIC4vZ2RiX3Ny Yy9zaW0vY29tbW9uL2dlbm5sdHZhbHMuc2gJMjAxMi0wOC0xNyAxNTozNTox NS4wMDAwMDAwMDAgKzA1MzAKQEAgLTQxLDcgKzQxLDcgQEAgJHNoZWxsICR7 c3JjY29tfS9nZW50dmFscy5zaCAkdGFyZ2V0IHN5cwogIyBPQlNPTEVURSAk c2hlbGwgJHtzcmNjb219L2dlbnR2YWxzLnNoICR0YXJnZXQgc3lzICR7c3Jj cm9vdH0vJGRpciBcCiAjIE9CU09MRVRFIAkic3lzY2FsbC5oIiAnU1lTX1tf WzphbG51bTpdXSonICIke2NwcH0iCiAKLWRpcj1saWJnbG9zcyB0YXJnZXQ9 Y3IxNgorZGlyPWxpYmdsb3NzL2NyMTYvc3lzIHRhcmdldD1jcjE2CiAkc2hl bGwgJHtzcmNjb219L2dlbnR2YWxzLnNoICR0YXJnZXQgc3lzICR7c3Jjcm9v dH0vJGRpciBcCiAJInN5c2NhbGwuaCIgJ1NZU19bX1s6YWxudW06XV0qJyAi JHtjcHB9IgogCi0tLSBnZGJfc3JjLm9yaWcvc2ltL2NvbW1vbi9ubHR2YWxz LmRlZgkyMDExLTA1LTI2IDIzOjUwOjEzLjAwMDAwMDAwMCArMDUzMAorKysg Li9nZGJfc3JjL3NpbS9jb21tb24vbmx0dmFscy5kZWYJMjAxMi0wOC0xNyAx NTozNjozOS4wMDAwMDAwMDAgKzA1MzAKQEAgLTIxOCwzMCArMjE4LDM0IEBA CiAjaWZkZWYgc3lzX2RlZnMKIC8qIGZyb20gc3lzY2FsbC5oICovCiAvKiBi ZWdpbiBjcjE2IHN5cyB0YXJnZXQgbWFjcm9zICovCi0geyAiU1lTX2FyZ2Mi LCAyMiB9LAotIHsgIlNZU19hcmduIiwgMjQgfSwKLSB7ICJTWVNfYXJnbmxl biIsIDIzIH0sCi0geyAiU1lTX2FyZ3YiLCAxMyB9LAotIHsgIlNZU19hcmd2 bGVuIiwgMTIgfSwKLSB7ICJTWVNfY2hkaXIiLCAxNCB9LAotIHsgIlNZU19j aG1vZCIsIDE2IH0sCi0geyAiU1lTX2Nsb3NlIiwgMyB9LAotIHsgIlNZU19l eGl0IiwgMSB9LAotIHsgIlNZU19mc3RhdCIsIDEwIH0sCi0geyAiU1lTX2dl dHBpZCIsIDggfSwKLSB7ICJTWVNfZ2V0dGltZW9mZGF5IiwgMTkgfSwKLSB7 ICJTWVNfa2lsbCIsIDkgfSwKLSB7ICJTWVNfbGluayIsIDIxIH0sCi0geyAi U1lTX2xzZWVrIiwgNiB9LAotIHsgIlNZU19vcGVuIiwgMiB9LAotIHsgIlNZ U19yZWFkIiwgNCB9LAotIHsgIlNZU19yZWNvbmZpZyIsIDI1IH0sCi0geyAi U1lTX3N0YXQiLCAxNSB9LAotIHsgIlNZU190aW1lIiwgMTggfSwKLSB7ICJT WVNfdGltZXMiLCAyMCB9LAotIHsgIlNZU191bmxpbmsiLCA3IH0sCi0geyAi U1lTX3V0aW1lIiwgMTcgfSwKLSB7ICJTWVNfd3JpdGUiLCA1IH0sCisgeyAi U1lTX0FSRyIsIDI0IH0sCisgeyAiU1lTX2NoZGlyIiwgMTIgfSwKKyB7ICJT WVNfY2htb2QiLCAxNSB9LAorIHsgIlNZU19jaG93biIsIDE2IH0sCisgeyAi U1lTX2Nsb3NlIiwgMHg0MDIgfSwKKyB7ICJTWVNfY3JlYXRlIiwgOCB9LAor IHsgIlNZU19leGVjdiIsIDExIH0sCisgeyAiU1lTX2V4ZWN2ZSIsIDU5IH0s CisgeyAiU1lTX2V4aXQiLCAweDQxMCB9LAorIHsgIlNZU19mb3JrIiwgMiB9 LAorIHsgIlNZU19mc3RhdCIsIDIyIH0sCisgeyAiU1lTX2dldHBpZCIsIDIw IH0sCisgeyAiU1lTX2lzYXR0eSIsIDIxIH0sCisgeyAiU1lTX2tpbGwiLCA2 MCB9LAorIHsgIlNZU19saW5rIiwgOSB9LAorIHsgIlNZU19sc2VlayIsIDB4 NDA1IH0sCisgeyAiU1lTX21rbm9kIiwgMTQgfSwKKyB7ICJTWVNfb3BlbiIs IDB4NDAxIH0sCisgeyAiU1lTX3BpcGUiLCA0MiB9LAorIHsgIlNZU19yZWFk IiwgMHg0MDMgfSwKKyB7ICJTWVNfcmVuYW1lIiwgMHg0MDYgfSwKKyB7ICJT WVNfc3RhdCIsIDM4IH0sCisgeyAiU1lTX3RpbWUiLCAweDMwMCB9LAorIHsg IlNZU191bmxpbmsiLCAweDQwNyB9LAorIHsgIlNZU191dGltZSIsIDIwMSB9 LAorIHsgIlNZU193YWl0IiwgMjAyIH0sCisgeyAiU1lTX3dhaXQ0IiwgNyB9 LAorIHsgIlNZU193cml0ZSIsIDB4NDA0IH0sCiAvKiBlbmQgY3IxNiBzeXMg dGFyZ2V0IG1hY3JvcyAqLwogI2VuZGlmCiAjZW5kaWYKLS0tIGdkYl9zcmMu b3JpZy9zaW0vY3IxNi9jcjE2X3NpbS5oCTIwMTItMDEtMDQgMTM6NTg6MDcu MDAwMDAwMDAwICswNTMwCisrKyAuL2dkYl9zcmMvc2ltL2NyMTYvY3IxNl9z aW0uaAkyMDEyLTA4LTI0IDE3OjIyOjI0LjAwMDAwMDAwMCArMDUzMApAQCAt NDcyLDMgKzQ3Miw5IEBAIGV4dGVybiB2b2lkIHdyaXRlX2xvbmdsb25nIFBB UkFNUyAoKHVpbnQKICAgIFBTUiBpcyBtYXNrZWQgZm9yIHplcm8gYml0cy4g Ki8KIAogZXh0ZXJuIGNyZWdfdCBtb3ZlX3RvX2NyIChpbnQgY3IsIGNyZWdf dCBtYXNrLCBjcmVnX3QgdmFsLCBpbnQgcHN3X2h3X3ApOworCisjaWZuZGVm IFNJR1RSQVAKKyNkZWZpbmUgU0lHVFJBUCA1CisjZW5kaWYKKy8qIFNwZWNp YWwgcHVycG9zZSB0cmFwICAqLworI2RlZmluZSBUUkFQX0JSRUFLUE9JTlQg OAotLS0gZ2RiX3NyYy5vcmlnL3NpbS9jcjE2L2ludGVycC5jCTIwMTItMDYt MTggMDU6MDQ6MTcuMDAwMDAwMDAwICswNTMwCisrKyAuL2dkYl9zcmMvc2lt L2NyMTYvaW50ZXJwLmMJMjAxMi0wOC0xNyAxNTo0MTozNS4wMDAwMDAwMDAg KzA1MzAKQEAgLTExOTIsNyArMTE5MiwxMSBAQCBzaW1fcmVzdW1lIChTSU1f REVTQyBzZCwgaW50IHN0ZXAsIGludCBzCiAgICAgICBpYWRkciA9IGltZW1f YWRkciAoKHVpbnQzMilQQyk7CiAgICAgICBpZiAoaWFkZHIgPT0gU3RhdGUu bWVtLmZhdWx0KQogICAgICAgICB7CisjaWZkZWYgU0lHQlVTCiAgICAgICAg ICAgU3RhdGUuZXhjZXB0aW9uID0gU0lHQlVTOworI2Vsc2UKKyAgICAgICAg ICBTdGF0ZS5leGNlcHRpb24gPSBTSUdTRUdWOworI2VuZGlmCiAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIH0KICAKQEAgLTE1NDgsNiArMTU1MiwxMSBA QCBzaW1fc3RvcmVfcmVnaXN0ZXIgKHNkLCBybiwgbWVtb3J5LCBsZW5nCiAg IHJldHVybiBzaXplOwogfQogCitjaGFyICoqCitzaW1fY29tcGxldGVfY29t bWFuZCAoU0lNX0RFU0Mgc2QsIGNoYXIgKnRleHQsIGNoYXIgKndvcmQpCit7 CisgIHJldHVybiBOVUxMOworfQogCiB2b2lkCiBzaW1fZG9fY29tbWFuZCAo c2QsIGNtZCkKLS0tIGdkYl9zcmMub3JpZy9zaW0vY3IxNi9zaW1vcHMuYwky MDEyLTAxLTA0IDEzOjU4OjA3LjAwMDAwMDAwMCArMDUzMAorKysgLi9nZGJf c3JjL3NpbS9jcjE2L3NpbW9wcy5jCTIwMTItMDgtMjggMTc6NTc6NDkuMDAw MDAwMDAwICswNTMwCkBAIC01MDU5LDYgKzUwNTksOCBAQCBPUF8xNENfMTQg KCkKIHZvaWQKIE9QX0NfQyAoKQogeworICB1aW50MzIgdG1wOworICB1aW50 MTYgYTsKICAgdHJhY2VfaW5wdXQgKCJleGNwIiwgT1BfQ09OU1RBTlQ0LCBP UF9WT0lELCBPUF9WT0lEKTsKICAgc3dpdGNoIChPUFswXSkKICAgICB7CkBA IC01NDY1LDkgKzU0NjcsMjQgQEAgT1BfQ19DICgpCiAjZW5kaWYKIAkgICAg CiAJICBkZWZhdWx0OgotCSAgICBjcjE2X2NhbGxiYWNrLT5lcnJvciAoY3Ix Nl9jYWxsYmFjaywgIlVua25vd24gc3lzY2FsbCAlZCIsIEZVTkMpOworCSAg ICBhID0gT1BbMF07CisJICAgIHN3aXRjaChhKQorCSAgICB7CisJICAgICAg Y2FzZSAgVFJBUF9CUkVBS1BPSU5UOgorCQlTdGF0ZS5leGNlcHRpb24gPSBT SUdUUkFQOworCQl0bXAgPSAoUEMpOworCQlKTVAodG1wKTsKKwkJdHJhY2Vf b3V0cHV0X3ZvaWQgKCk7CisJCWJyZWFrOworCSAgICAgIGNhc2UgIFNJR1RS QVA6ICAvKiBzdXBlcnZpc29yIGNhbGwgPyAqLworCQlTdGF0ZS5leGNlcHRp b24gPSBTSUdfQ1IxNl9FWElUOworCQl0cmFjZV9vdXRwdXRfdm9pZCAoKTsK KwkJYnJlYWs7CisJICAgICAgZGVmYXVsdDoKKwkJY3IxNl9jYWxsYmFjay0+ ZXJyb3IgKGNyMTZfY2FsbGJhY2ssICJVbmtub3duIHN5c2NhbGwgJWQiLCBG VU5DKTsKKwkJYnJlYWs7CisJICAgIH0KIAkgIH0KLQogCWlmICgodWludDE2 KSByZXN1bHQgPT0gKHVpbnQxNikgLTEpCiAJICBSRVRFUlIgKGNyMTZfY2Fs bGJhY2stPmdldF9lcnJubyhjcjE2X2NhbGxiYWNrKSk7CiAJZWxzZQo= --_002_C6CA53A2A46BA7469348BDBD663AB65845B28084KCHJEXMB03kpitc_--