From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by sourceware.org (Postfix) with ESMTPS id 640D13870856 for ; Sat, 4 Jul 2020 06:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 640D13870856 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dxuuu.xyz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dxu@dxuuu.xyz Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 39E109A4; Sat, 4 Jul 2020 02:45:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 04 Jul 2020 02:45:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dxuuu.xyz; h= content-transfer-encoding:content-type:subject:from:to:date :message-id:in-reply-to; s=fm3; bh=DkrfuMWJnJEjn167HdJ6zlRfJ+hZ7 G0DPttlA+sSf0g=; b=IU3lRNj69cCRrXJWcb7tYGLDSMQNA+3aN0iwOaqu5HhI4 1ulH3J1o8jWn8U+sWejJyAVNoJWZJyNUE4omWXEdjiVUenRAaxyoc4+Uyt+zgcWq zjiFYc77TlRrS/Xp3LfJWBskO73lmWi/LyPM5QaJ9uScpccmTZDIJBu0EGLuiwYf RTqKo/HbyXPeWm8Gz6wNdYxmSto7/Q4RaL87fnWANSd8IPZ3b5nky6tr+IGcXSRm FHElDlb3J97zsm0fN6QQrQ8rLP0cGRfnvmEMRUzBEPt49YE2wXtqAJa01dG/a2L+ QvPOBzD8noTZYYcPTtzw9Z3gziipqbmkOn7gHs2rg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=DkrfuM WJnJEjn167HdJ6zlRfJ+hZ7G0DPttlA+sSf0g=; b=Zg1zeoyO0x28YWqjfc12tN IcChItG4q+kQL8pb03g79Dy7fH/ZslsNdp98ffKvQGA7D69yZdOTLaCgNZoNTmEY dxOtGNSd9LRyIQ6cjLs1pkJYzh4QIVvdSHW6irih+k15LMozLJuOXdBAwRlV/qNN ubJKxM8Zozcr/fSbUtFgfwtTapHz3gOs0dLNnQ8cwY82j4k8bXBFDcJhiORsfLWc VB0Lbeb1MlzHaGlvJS6M/bosRwIpWVpfpCF1LuOeKLuOf3IbHcOeuHLaquC5qSLv 4s2D7lhm7QWT/riYwsc1M4StVtgMXO+LoIMOdNcImoNKLf10i2dRBs9/ajEKlrzw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtdejgdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpefgtg fuhffvfffkjgesthhqredttddtjeenucfhrhhomhepfdffrghnihgvlhcuighufdcuoegu gihusegugihuuhhurdighiiiqeenucggtffrrghtthgvrhhnpeeuffeuffekgefgieelhf eihfeiffelhffgheeggeeiffefheduveevkeffkeejheenucfkphepjeefrdelfedrvdeg jedrudefgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegugihusegugihuuhhurdighiii X-ME-Proxy: Received: from localhost (c-73-93-247-134.hsd1.ca.comcast.net [73.93.247.134]) by mail.messagingengine.com (Postfix) with ESMTPA id 1A0D93060060; Sat, 4 Jul 2020 02:45:30 -0400 (EDT) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH] rust: Fix rust modules test From: "Daniel Xu" To: "Daniel Xu" , , Date: Fri, 03 Jul 2020 23:44:40 -0700 Message-Id: In-Reply-To: <20200704035953.849933-1-dxu@dxuuu.xyz> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FROM_SUSPICIOUS_NTLD, JMQ_SPF_NEUTRAL, KAM_INFOUSMEBIZ, PDS_OTHER_BAD_TLD, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2020 06:45:35 -0000 On Fri Jul 3, 2020 at 8:59 PM PDT, Daniel Xu wrote: > I noticed that the modules test was failing. Some choice use of `nm` > revealed `TWENTY_THREE` was not in the final binary. Fix by taking a > pointer to the global, forcing the linker to keep the symbol in. > > gdb/testsuite/ > * gdb.rust/modules.rs: Prevent linker from discarding test > symbol > > Signed-off-by: Daniel Xu > --- > Changes from V0: This should have been a "Changes from V1". And this patch should have veen a V2. Sorry. [...] Daniel