From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25978 invoked by alias); 10 Oct 2018 11:54:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25936 invoked by uid 89); 10 Oct 2018 11:54:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30043.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Oct 2018 11:54:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CP+c5Y8H3fbUsKEEkk9ZIp1/hHNIp4JDo2W92cqjZTc=; b=IljemwpR2anXt1w55QQzYTdZ3VhWa3Bwgr6K6p09HvinaRpBy9Omcbrag3LaEGaHgTSzQGymJwjEape/V5Zn5sGMJjIkKsfffP/Wq+z9AJBTEEZH8z7YL1KsKmcFh99QX3F9BXi5OCCrBZqHBqwusVOM8XJx8A4poCIo5imqk6w= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2581.eurprd08.prod.outlook.com (10.172.252.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.23; Wed, 10 Oct 2018 11:54:18 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7073:f11c:4e4:cb13]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7073:f11c:4e4:cb13%5]) with mapi id 15.20.1207.029; Wed, 10 Oct 2018 11:54:18 +0000 From: Alan Hayward To: Pedro Alves CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 1/2] Add lang_struct_return to _push_dummy_call Date: Wed, 10 Oct 2018 11:54:00 -0000 Message-ID: References: <20181001155255.14859-1-alan.hayward@arm.com> <20181001155255.14859-2-alan.hayward@arm.com> <5ce2656e-1ba6-bbab-48a6-7a12dea92a61@redhat.com> In-Reply-To: <5ce2656e-1ba6-bbab-48a6-7a12dea92a61@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <881056CAA621234CAD65AD9252B01D00@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00248.txt.bz2 DQoNCj4gT24gOSBPY3QgMjAxOCwgYXQgMTc6MTQsIFBlZHJvIEFsdmVzIDxw YWx2ZXNAcmVkaGF0LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAxMC8wMS8yMDE4 IDA0OjUyIFBNLCBBbGFuIEhheXdhcmQgd3JvdGU6DQo+PiBNYWtlIGNhbGxf ZnVuY3Rpb25fYnlfaGFuZF9kdW1teSBwYXNzIHRoaXMgZG93bi4NCj4+IA0K Pj4gMjAxOC0xMC0wMSAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJkQGFy bS5jb20+DQo+PiANCj4gDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL2FhcmNoNjQt dGRlcC5jIGIvZ2RiL2FhcmNoNjQtdGRlcC5jDQo+PiBpbmRleCAwMjNlOGVi NDUzLi41MDRiMDQwYzJlIDEwMDY0NA0KPj4gLS0tIGEvZ2RiL2FhcmNoNjQt dGRlcC5jDQo+PiArKysgYi9nZGIvYWFyY2g2NC10ZGVwLmMNCj4+IEBAIC0x NTEyLDggKzE1MTIsOCBAQCBwYXNzX2luX3ZfdmZwX2NhbmRpZGF0ZSAoc3Ry dWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVjdCByZWdjYWNoZSAqcmVnY2Fj aGUsDQo+PiBzdGF0aWMgQ09SRV9BRERSDQo+PiBhYXJjaDY0X3B1c2hfZHVt bXlfY2FsbCAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVjdCB2YWx1 ZSAqZnVuY3Rpb24sDQo+PiAJCQkgc3RydWN0IHJlZ2NhY2hlICpyZWdjYWNo ZSwgQ09SRV9BRERSIGJwX2FkZHIsDQo+PiAtCQkJIGludCBuYXJncywNCj4+ IC0JCQkgc3RydWN0IHZhbHVlICoqYXJncywgQ09SRV9BRERSIHNwLCBpbnQg c3RydWN0X3JldHVybiwNCj4+ICsJCQkgaW50IG5hcmdzLCBzdHJ1Y3QgdmFs dWUgKiphcmdzLCBDT1JFX0FERFIgc3AsDQo+PiArCQkJIGludCBzdHJ1Y3Rf cmV0dXJuLCBpbnQgbGFuZ19zdHJ1Y3RfcmV0dXJuX3VudXNlZCwNCj4gDQo+ IEhlcmUgdGhpcyBpcyBjYWxsZWQgImxhbmdfc3RydWN0X3JldHVybl91bnVz ZWQiLCBidXQgYWxsIHRoZSBvdGhlcg0KPiBjYXNlcyB3ZXJlIGp1c3QgImxh bmdfc3RydWN0X3JldHVybiIuDQo+IA0KPiBJIHN1cHBvc2UgaXQnZCBiZSBj bGVhcmVyIGlmICJzdHJ1Y3RfcmV0dXJuIiB3ZXJlIHJlbmFtZWQgdG8NCj4g ImFiaV9zdHJ1Y3RfcmV0dXJuIiwgYnV0IEkgZW1wYXRoaXplIHdpdGggbm90 IGhhdmluZw0KPiBjaGFuZ2VkIGl0IGluIHRoaXMgcGF0Y2jigKYNCj4gDQoN ClRoaXMgd2FzIGJlY2F1c2UgbGFuZ19zdHJ1Y3RfcmV0dXJuIGlzIGFscmVh ZHkgYSBsb2NhbCBwYXJhbWV0ZXIgd2l0aGluIGFhcmNoNjRfcHVzaF9kdW1t eV9jYWxsLg0KVGhlIG5leHQgcGF0Y2ggcmVuYW1lcyB0aGUgZnVuY3Rpb24g YXJnIGJhY2sgdG8gbGFuZ19zdHJ1Y3RfcmV0dXJuLg0KDQooSG93ZXZlciwg aWYgSSBkbyB0aGUgZW51bSBiZWxvdyBpdCBzaG91bGQgcmVtb3ZlIHRoYXQg aXNzdWUpLg0KDQo+PiAJCQkgQ09SRV9BRERSIHN0cnVjdF9hZGRyKQ0KPj4g ew0KPj4gICBpbnQgYXJnbnVtOw0KPiANCj4gDQo+PiAtLS0gYS9nZGIvZ2Ri YXJjaC5zaA0KPj4gKysrIGIvZ2RiL2dkYmFyY2guc2gNCj4+IEBAIC00ODUs NyArNDg1LDcgQEAgTTtzdHJ1Y3QgZnJhbWVfaWQ7ZHVtbXlfaWQ7c3RydWN0 IGZyYW1lX2luZm8gKnRoaXNfZnJhbWU7dGhpc19mcmFtZQ0KPj4gIyBkZXBy ZWNhdGVkX2ZwX3JlZ251bS4NCj4+IHY7aW50O2RlcHJlY2F0ZWRfZnBfcmVn bnVtOzs7LTE7LTE7OzANCj4+IA0KPj4gLU07Q09SRV9BRERSO3B1c2hfZHVt bXlfY2FsbDtzdHJ1Y3QgdmFsdWUgKmZ1bmN0aW9uLCBzdHJ1Y3QgcmVnY2Fj aGUgKnJlZ2NhY2hlLCBDT1JFX0FERFIgYnBfYWRkciwgaW50IG5hcmdzLCBz dHJ1Y3QgdmFsdWUgKiphcmdzLCBDT1JFX0FERFIgc3AsIGludCBzdHJ1Y3Rf cmV0dXJuLCBDT1JFX0FERFIgc3RydWN0X2FkZHI7ZnVuY3Rpb24sIHJlZ2Nh Y2hlLCBicF9hZGRyLCBuYXJncywgYXJncywgc3AsIHN0cnVjdF9yZXR1cm4s IHN0cnVjdF9hZGRyDQo+PiArTTtDT1JFX0FERFI7cHVzaF9kdW1teV9jYWxs O3N0cnVjdCB2YWx1ZSAqZnVuY3Rpb24sIHN0cnVjdCByZWdjYWNoZSAqcmVn Y2FjaGUsIENPUkVfQUREUiBicF9hZGRyLCBpbnQgbmFyZ3MsIHN0cnVjdCB2 YWx1ZSAqKmFyZ3MsIENPUkVfQUREUiBzcCwgaW50IHN0cnVjdF9yZXR1cm4s IGludCBsYW5nX3N0cnVjdF9yZXR1cm4sIENPUkVfQUREUiBzdHJ1Y3RfYWRk cjtmdW5jdGlvbiwgcmVnY2FjaGUsIGJwX2FkZHIsIG5hcmdzLCBhcmdzLCBz cCwgc3RydWN0X3JldHVybiwgbGFuZ19zdHJ1Y3RfcmV0dXJuLCBzdHJ1Y3Rf YWRkcg0KPj4gdjtpbnQ7Y2FsbF9kdW1teV9sb2NhdGlvbjs7OztBVF9FTlRS WV9QT0lOVDs7MA0KPj4gTTtDT1JFX0FERFI7cHVzaF9kdW1teV9jb2RlO0NP UkVfQUREUiBzcCwgQ09SRV9BRERSIGZ1bmFkZHIsIHN0cnVjdCB2YWx1ZSAq KmFyZ3MsIGludCBuYXJncywgc3RydWN0IHR5cGUgKnZhbHVlX3R5cGUsIENP UkVfQUREUiAqcmVhbF9wYywgQ09SRV9BRERSICpicF9hZGRyLCBzdHJ1Y3Qg cmVnY2FjaGUgKnJlZ2NhY2hlO3NwLCBmdW5hZGRyLCBhcmdzLCBuYXJncywg dmFsdWVfdHlwZSwgcmVhbF9wYywgYnBfYWRkciwgcmVnY2FjaGUNCj4+IA0K PiANCj4gTm8gZG9jdW1lbnRhdGlvbiwgbm8gZ29kZGllLiAgV2hhdCBkb2Vz IHRoZSBuZXcgcGFyYW1ldGVyDQo+IG1lYW4/ICANCj4gDQo+IEknZCB0aGlu ayB0aGF0IGEgYm9vbCBpbnN0ZWFkIG9mIGFuIGludCB3b3VsZCBiZSBiZXR0 ZXIuDQo+IE9yIGNsZWFyZXIgc3RpbGwsIGFuIGVudW0sIGxpa2U6DQo+IA0K PiBlbnVtIGNsYXNzIHJldHVybl9ob3cgeyBTVFJVQ1QsIE5PUk1BTCB9Ow0K PiANCj4gSWYgeW91IHdhbnQgdG8gZG8gYSBwcmVwYXJhdG9yeSBwYXRjaCBh ZGRpbmcgdGhlIGVudW0gYW5kDQo+IHJlbmFtaW5nICJzdHJ1Y3RfcmV0dXJu IiwgaXQnZCBiZSBhd2Vzb21lLCBJIHRoaW5rLg0KDQpJIGNvbnNpZGVyZWQg ZG9pbmcgdGhpcyBidXQgZGlkbuKAmXQgd2FudCB0byBhZGQgYSBnbG9iYWwg ZW51bSB0byBnZGJhcmNoLmgNCmZvciBqdXN0IGEgc2luZ2xlIHVzZS4gQWdy ZWVkIGl0IGlzIGNsZWFuZXIuIEnigJlsbCBmaXggaXQgdXAgZm9yIHYzLg0K DQoNCj4gDQo+IEJ1dCBJIHN1cHBvc2UgdGhhdCBnaXZlbiB0aGUgZXhpc3Rl bmNlIG9mIHRoZSAiaW50IHN0cnVjdF9yZXR1cm4iDQo+IHBhcmFtZXRlciwg SSBjYW4ndCByZWFsbHkgY29tcGxhaW4uICBXZSBjb3VsZCBhbHdheXMgYWRk IHN1Y2gNCj4gYW4gZW51bSBsYXRlciBvbiBhbmQgY2hhbmdlIGJvdGggcGFy YW1ldGVycyBhdCB0aGUgc2FtZSB0aW1lDQo+IHRocm91Z2hvdXQuICANCj4g DQo+IFNvIGZlZWwgZnJlZSB0byBsZWF2ZSBpdCBiZSBhcyBpcy4NCj4gDQo+ IFRoYW5rcywNCj4gUGVkcm8gQWx2ZXMNCg0K >From gdb-patches-return-151529-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 10 11:54:18 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 25160 invoked by alias); 10 Oct 2018 11:54:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25142 invoked by uid 89); 10 Oct 2018 11:54:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=gotten X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30084.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Oct 2018 11:54:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BI4tmI48wSk9TkWBRxaIybeU+kDTTYojPdg0GyWc7oI=; b=lFv4Vrh7GF/MSEFRgm+NlkRIhnlo8brh2VFD/+jDmTls1cY6NAY7AEG4zyXawBuDaXwWd7xyUEX5DijzfFk6g3iH9hpl9KPWrBke3a13R2BKj4drXnORCvWEaw3lGn4/7uG/cHqFMZsBhc14IxwMgUwedpAWjPKALQFPwL8P8PY= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2581.eurprd08.prod.outlook.com (10.172.252.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.23; Wed, 10 Oct 2018 11:54:09 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7073:f11c:4e4:cb13]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7073:f11c:4e4:cb13%5]) with mapi id 15.20.1207.029; Wed, 10 Oct 2018 11:54:09 +0000 From: Alan Hayward To: Pedro Alves CC: GDB Patches , nd Subject: Re: [PATCH v2 0/2] Aarch64: Fix segfault when casting dummy calls Date: Wed, 10 Oct 2018 11:54:00 -0000 Message-ID: References: <20181001155255.14859-1-alan.hayward@arm.com> <57873989-fc65-634f-c6f8-8c2a976e4f9f@redhat.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00247.txt.bz2 Content-length: 2904 DQoNCj4gT24gMTAgT2N0IDIwMTgsIGF0IDA5OjIzLCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMTAvMDkvMjAx OCAwNjo1MCBQTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gDQo+PiANCj4+ PiBPbiA5IE9jdCAyMDE4LCBhdCAxNzoxMCwgUGVkcm8gQWx2ZXMgPHBhbHZl c0ByZWRoYXQuY29tPiB3cm90ZToNCj4+PiANCj4+PiBPbiAxMC8wMS8yMDE4 IDA0OjUyIFBNLCBBbGFuIEhheXdhcmQgd3JvdGU6DQo+Pj4+IFRoaXMgaXMg YSByZXdvcmtpbmcgb2YgYSBwYXRjaCBJIHBvc3RlZCBpbiBNYXJjaC4NCj4+ Pj4gVjEgaGFkIGEgbG9uZyBkaXNjdXNzaW9uIHdoaWNoIHdhcyB0aGVuIHBh dXNlZCB0byB3YWl0IGZvcg0KPj4+PiBQZWRybydzIElGVU5DIHJld3JpdGUu DQo+Pj4+IA0KPj4+PiANCj4+Pj4gUHJldmVudCB0aGUgaW50IGNhc3QgaW4g dGhlIGZvbGxvd2luZyBjYXVzaW5nIGEgc2VnZmF1bHQgb24gYWFyY2g2NDoN Cj4+Pj4gKGdkYikgYiBmb28gaWYgKGludClzdHJjbXAobmFtZSwiYWJjIikg PT0gMA0KPj4+PiAoZ2RiKSBydW4NCj4+Pj4gDQo+Pj4+IA0KPj4+PiBUaGlz IGlzIGJlY2F1c2UgdG8gYWFyY2g2NF9wdXNoX2R1bW15X2NhbGwgZGV0ZXJt aW5lcyB0aGUgcmV0dXJuIHR5cGUNCj4+Pj4gb2YgdGhlIGZ1bmN0aW9uIGFu ZCB0aGVuIGRvZXMgbm90IGNoZWNrIGZvciBudWxsIHBvaW50ZXIuDQo+Pj4+ IA0KPj4+PiBBIG51bGwgcG9pbnRlciBmb3IgdGhlIHJldHVybiB0eXBlIG1l YW5zIGVpdGhlciAxKSB0aGUgY2FsbCBoYXMgYQ0KPj4+PiBjYXN0IG9yIDIp IGFuIGVycm9yIGhhcyBvY2N1cmVkLg0KPj4+IA0KPj4+IEknZCB0aGluayB0 aGF0ICIxKSB0aGUgY2FsbCBoYXMgYSBjYXN0IiBpcyBub3QgYWNjdXJhdGUu DQo+Pj4gSWYgdGhlIGNhbGxlZCBmdW5jdGlvbiBoYXMgZGVidWcgaW5mbywg dGhlbiBHREIgd2lsbCBrbm93DQo+Pj4gaXQncyByZXR1cm4gdHlwZS4gIFRo ZSBpc3N1ZSBpcyB0aGF0IHRoZSBjYWxsZWQgZnVuY3Rpb24gbWF5DQo+Pj4g bm90IGhhdmUgZGVidWcgaW5mb3JtYXRpb24sIGFuZCB0aGVuIEdEQiBkb2Vz IG5vdCBrbm93DQo+Pj4gaXRzIHJldHVybiB0eXBlIChzbyBpdHMgTlVMTCks IGFuZCB0aGVuIHRoZSBvbmx5IHdheSB0bw0KPj4+IGNhbGwgdGhlIGZ1bmN0 aW9uIGlzIHRvIGFkZCB0aGUgY2FzdC4gIFJpZ2h0Pw0KPj4+IA0KPj4gDQo+ PiBUaGF0IG1ha2VzIHNlbnNlLiBJ4oCZZCBhZGQgdGhhdCBpbiB0aGUgYWJv dmUgZXhhbXBsZSBJ4oCZbSBhYmxlIHRvIGRvIHRoZQ0KPj4gYnJlYWsgd2l0 aG91dCBhIGNhc3QgYW5kIGdkYiBkb2VzIG5vdCBzZWdmYXVsdCAtIHRoZSBy ZXR1cm4gdHlwZQ0KPj4gb2YgdGhlIGZ1bmN0aW9uIGNvbWVzIGJhY2sgYXMg YW4gaW50LiANCj4gDQo+IFBsZWFzZSBkb3VibGUgY2hlY2sgd2hldGhlciB0 aGUgcHJvcG9zZWQgdGVzdGNhc2UgY3Jhc2hlcyBHREIgd2l0aG91dA0KPiB0 aGUgZml4LiAgSSBzdXNwZWN0IG5vdCwgZHVlIHRvIHRoZSBsaWJyYXJ5IGJl aW5nIGNvbXBpbGVkIHdpdGgNCj4gZGVidWcgaW5mby4gIElmIGl0IGRvZXMg Y3Jhc2gsIHRoZW4gSSB0aGluayBJJ20gbWlzc2luZyBzb21ldGhpbmcuDQo+ IA0KDQpDaGVja2luZyB0aGlzIG9uIGxhdGVzdCBjbGVhbiBoZWFkOg0KDQpi IGNtcDMgaWYgKGludClzdHJjbXAod29yZCwic3R1ZmYiKSA9PSAwDQogLSBz ZWdmYXVsdA0KDQpiIGNtcDMgaWYgc3RyY21wKHdvcmQsInN0dWZmIikgPT0g MA0KIC0gd29ya3MuIEdkYiBjb21wbGFpbnMgdGhhdCBzdHJjbXAgaGFzIHVu a25vd24gcmV0dXJuIHR5cGUuDQoNCmIgYmFyIGlmIGNtcDMoInN0dWZmIikg PT0gMA0KIC0gd29ya3MuDQoNCmIgYmFyIGlmIChjaGFyKWNtcDMoInN0dWZm IikgPT0gMA0KIC0gd29ya3MuDQoNCkkgdGhpbmsgSeKAmXZlIGdvdHRlbiBh IGxpdHRsZSBtdWRkbGVkIHdoZW4gd3JpdGluZyBteSB0ZXN0LiBJIHNob3Vs ZCBpbnN0ZWFkDQpiZSBjb21waWxpbmcgdGhlIGxpYnJhcnkgd2l0aG91dCBk ZWJ1ZyBpbmZvLiBBbmQgdGhlbiBkbyBhIGNvbmRpdGlvbmFsDQpicmVhayB1 c2luZyBjbXAzIGluc3RlYWQgb2Ygc3RyY21wLiBJ4oCZbGwgcmV3b3JrIHRo aXMgaW4gYSB2My4NCg0KDQoNCg0KDQoNCg== >From gdb-patches-return-151531-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 10 12:58:05 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 118422 invoked by alias); 10 Oct 2018 12:58:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118401 invoked by uid 89); 10 Oct 2018 12:58:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Oct 2018 12:58:03 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1051830820D5 for ; Wed, 10 Oct 2018 12:58:02 +0000 (UTC) Received: from blade.nx (ovpn-117-250.ams2.redhat.com [10.36.117.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC7DD1001947 for ; Wed, 10 Oct 2018 12:58:01 +0000 (UTC) Received: from blade.com (localhost [127.0.0.1]) by blade.nx (Postfix) with ESMTP id DD6C480B0905 for ; Wed, 10 Oct 2018 13:58:00 +0100 (BST) From: Gary Benson To: gdb-patches@sourceware.org Subject: [PATCH 1/2] Fix resource leak found by Coverity Date: Wed, 10 Oct 2018 12:58:00 -0000 Message-Id: <1539176277-4500-2-git-send-email-gbenson@redhat.com> In-Reply-To: <1539176277-4500-1-git-send-email-gbenson@redhat.com> References: <1539176277-4500-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00249.txt.bz2 Content-length: 986 This commit fixes a resource leak found by Coverity, where cli_interp's constructor creates a new cli_ui_out, but there was no corresponding destructor to free it. gdb/ChangeLog: * cli/cli-interp.c (cli_interp::~cli_interp): New function. --- gdb/ChangeLog | 4 ++++ gdb/cli/cli-interp.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/gdb/cli/cli-interp.c b/gdb/cli/cli-interp.c index 2aa41d6..75d8093 100644 --- a/gdb/cli/cli-interp.c +++ b/gdb/cli/cli-interp.c @@ -44,6 +44,7 @@ class cli_interp final : public cli_interp_base { public: explicit cli_interp (const char *name); + ~cli_interp (); void init (bool top_level) override; void resume () override; @@ -62,6 +63,11 @@ cli_interp::cli_interp (const char *name) this->cli_uiout = cli_out_new (gdb_stdout); } +cli_interp::~cli_interp () +{ + delete cli_uiout; +} + /* Suppress notification struct. */ struct cli_suppress_notification cli_suppress_notification = { -- 1.8.3.1