From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60581 invoked by alias); 28 Jan 2020 17:06:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60572 invoked by uid 89); 28 Jan 2020 17:06:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Jan 2020 17:06:33 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2020 09:06:31 -0800 Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by FMSMGA003.fm.intel.com with ESMTP; 28 Jan 2020 09:06:30 -0800 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jan 2020 09:06:30 -0800 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX114.amr.corp.intel.com (10.22.240.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jan 2020 09:06:30 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jan 2020 09:06:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q4nx5gHX3H76tPRF0KEe8ElTVvoLXA5VPK+hYdJdUf7ahwKMZaehuR0TWAXDXpdFyom9qU3U6TXcXZ9rWgczUtwt4tz8I0C+zUgDSmMQChz66jAleQ7yvotnpDFbSSJA5jPMkEVOE/loupbxQGRp5xgG7z7ufKaCx6AGaJjC52Yt5+g6rYwF9wXxPEsi72deeOQ1hmObDduK8/UYoIP70gF21eRMHghhi91YqUi3cCJyIR9UO/2E9p+W1p+3Pl8agzsodlQVrEg03teR6w6f3y5gNvP0AHVL4eq2HwXBFHpOXZi2Cdrwjgc4JYIjmgzy6mY0FIosENw4kjED0xJP7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jb5TPsc+3w3sGkeoNciiRSRsIEEG5h15/e87ImS7nK0=; b=Y4q20xvpLYCJxYbsLlVgCjnUAXdDwyXjXQduLqzN7a1T6uwEewHt3jOPrzJ8uqKsaQCIt5wjAzLs6T4qmlt/MbWDdcXwnhWm94+dmKL3DeAybXeAgABDf0QgjhwdsAF1ruDN5Nzy0DGIsGYiFPRdudkKeJIyiuddIaMuyZRy42Xbu/BqktqgYZh5sYxMhfF2Nod8jqgF0sGQ609i6d+RP/qB7zecVq33h5eE41eUiLpRtO+Fnf3Knbi+oj4czsNKQL82ziWN4lShfPJXU0+rzpkjgCEA8oi9I0gaFThHeGYOyebaq1l49+TTF9Fa5xSsyhSfZcfoXVQbQ1Cg3ljmMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jb5TPsc+3w3sGkeoNciiRSRsIEEG5h15/e87ImS7nK0=; b=si4GIi5sP2+jsb3jPiaiH9mzH26bVKUjHhPWCQim5/YilegIgE3y6xg3HPZX/Cqq3zZ61CANYj4v6mPfRQruOhCZG07n/Ny9JiqFGTTO6pjSOEt2Q6sW+uQWHdmolhyDrY13i2aMK6zEwxWKiTQgerXhf8wpTlmKuEH7/t++rAQ= Received: from BYAPR11MB3030.namprd11.prod.outlook.com (20.177.225.91) by BYAPR11MB3190.namprd11.prod.outlook.com (20.177.184.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.26; Tue, 28 Jan 2020 17:06:29 +0000 Received: from BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::2c94:a4bd:2d9c:30b]) by BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::2c94:a4bd:2d9c:30b%6]) with mapi id 15.20.2665.026; Tue, 28 Jan 2020 17:06:29 +0000 From: "Aktemur, Tankut Baris" To: Simon Marchi , Lukas Durfina , "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/2] gdb: Fix a type of sentinel Date: Tue, 28 Jan 2020 17:13:00 -0000 Message-ID: References: <20200128142830.89282-1-ldurfina@tachyum.com> <20200128142830.89282-2-ldurfina@tachyum.com> <920e08c2-dfc3-bb13-21e7-90635341df77@simark.ca> In-Reply-To: <920e08c2-dfc3-bb13-21e7-90635341df77@simark.ca> authentication-results: spf=none (sender IP is ) smtp.mailfrom=tankut.baris.aktemur@intel.com; x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-messagedata: sij6zqWB6MvFSaZxoCbHZCzmVp/hGZfbRvF54JVTnGNs2vOGL1QlhsOwgm3xpUI7GRJrVay/AQsZdzZwbGss90EI1EZI4we08wc0t0MDGolS4ih9znQAqMFrvzl3z5AjZE6O3ItBfQhhZAgHNK3IKw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QtWKnk0CSyaAzC/QV15YE0brTO168XYdVOvHML90tQzq1F+bAAONcz4ps8bljdjU5AOmRVl+8Oi9YYTVPt/KHrlKRI/IfkJJ65hEfAGvj48= Return-Path: tankut.baris.aktemur@intel.com Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00907.txt.bz2 T24gVHVlc2RheSwgSmFudWFyeSAyOCwgMjAyMCA1OjQ0IFBNLCBTaW1vbiBN YXJjaGkgd3JvdGU6DQo+IE9uIDIwMjAtMDEtMjggOToyOCBhLm0uLCBMdWth cyBEdXJmaW5hIHdyb3RlOg0KPiA+IC0tLQ0KPiA+ICBnZGIvQ2hhbmdlTG9n IHwgNCArKysrDQo+ID4gIGdkYi9jaGFyc2V0LmMgfCAyICstDQo+ID4gIDIg ZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p DQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvZ2RiL0NoYW5nZUxvZyBiL2dkYi9D aGFuZ2VMb2cNCj4gPiBpbmRleCA4YjZkYTYyYmQ0Li4xZGQ4OWFlMmUwIDEw MDY0NA0KPiA+IC0tLSBhL2dkYi9DaGFuZ2VMb2cNCj4gPiArKysgYi9nZGIv Q2hhbmdlTG9nDQo+ID4gQEAgLTEsMyArMSw3IEBADQo+ID4gKzIwMjAtMDEt MjggTHVrYXMgRHVyZmluYSA8bGR1cmZpbmFAdGFjaHl1bS5jb20+DQo+ID4g Kw0KPiA+ICsJKiBjaGFyc2V0LmMgKGZpbmRfY2hhcnNldF9uYW1lcyk6IEZp eCBhIHR5cGUgb2Ygc2VudGluZWwuDQo+ID4gKw0KPiA+ICAyMDIwLTAxLTI2 ICBUb20gVHJvbWV5ICA8dG9tQHRyb21leS5jb20+DQo+ID4NCj4gPiAgCSog Y3RmcmVhZC5jIChzdHJ1Y3QgY3RmX2ZwX2luZm8pOiBSZWluZGVudC4NCj4g PiBkaWZmIC0tZ2l0IGEvZ2RiL2NoYXJzZXQuYyBiL2dkYi9jaGFyc2V0LmMN Cj4gPiBpbmRleCA1Y2ZkMmQ4MDMwLi5hYmY3OTVjZTZkIDEwMDY0NA0KPiA+ IC0tLSBhL2dkYi9jaGFyc2V0LmMNCj4gPiArKysgYi9nZGIvY2hhcnNldC5j DQo+ID4gQEAgLTgxOCw3ICs4MTgsNyBAQCBmaW5kX2NoYXJzZXRfbmFtZXMg KHZvaWQpDQo+ID4gICAgew0KPiA+ICAgICAgc3RkOjpzdHJpbmcgaWNvbnZf ZGlyID0gcmVsb2NhdGVfZ2RiX2RpcmVjdG9yeSAoSUNPTlZfQklOLA0KPiA+ ICAJCQkJCQkgICAgSUNPTlZfQklOX1JFTE9DQVRBQkxFKTsNCj4gPiAtICAg IGljb252X3Byb2dyYW0gPSBjb25jYXQgKGljb252X2Rpci5jX3N0cigpLCBT TEFTSF9TVFJJTkcsICJpY29udiIsIE5VTEwpOw0KPiA+ICsgICAgaWNvbnZf cHJvZ3JhbSA9IGNvbmNhdCAoaWNvbnZfZGlyLmNfc3RyKCksIFNMQVNIX1NU UklORywgImljb252IiwgKGNoYXIgKikgTlVMTCk7DQo+ID4gICAgfQ0KPiA+ ICAjZWxzZQ0KPiA+ICAgIGljb252X3Byb2dyYW0gPSB4c3RyZHVwICgiaWNv bnYiKTsNCj4gPiAtLQ0KPiA+IDIuMTcuMQ0KPiA+DQo+IA0KPiBIaSBMdWth cywNCj4gDQo+IFNhbWUgY29tbWVudCBhcyBwYXRjaCAxLzIuDQo+IA0KPiBJ ZiB0aGlzIGNoYW5nZSBmaXhlcyB0aGUgc2FtZSBwcm9ibGVtIGFzIHBhdGNo IDEvMiwgdGhlbiB5b3UgY2FuIHB1dA0KPiBib3RoIGNoYW5nZXMgaW4gdGhl IHNhbWUgcGF0Y2guDQo+IA0KPiBTaW1vbg0KDQpOb3cgdGhhdCB0aGUgbGlu ZSBpcyBiZWluZyB0b3VjaGVkLCBpdCBtaWdodCBhbHNvIGJlIGEgZ29vZCBp ZGVhIHRvIHJlcGxhY2UNCk5VTEwgd2l0aCBudWxscHRyLg0KDQotQmFyaXMN Cg0KDQpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVyZWQgQWRkcmVz czogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJnLCBHZXJtYW55 ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVsLmRlCk1hbmFnaW5n IERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2htaWQsIEdhcnkgS2Vyc2hh dwpDaGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2aXNvcnkgQm9hcmQ6IE5pY29s ZSBMYXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11bmljaApDb21tZXJjaWFsIFJl Z2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hlbiBIUkIgMTg2OTI4Cg== >From gdb-patches-return-163594-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jan 28 17:13:17 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 68905 invoked by alias); 28 Jan 2020 17:13:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 68896 invoked by uid 89); 28 Jan 2020 17:13:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=risky, HContent-Transfer-Encoding:8bit X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Jan 2020 17:13:15 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 61FEA1E5F7; Tue, 28 Jan 2020 12:13:13 -0500 (EST) Subject: Re: Propose we release GDB 9.1 next weekend (Feb 01-02) To: Hannes Domani , Gdb-patches References: <20200126114033.GA20733@adacore.com> <720913399.742914.1580230424544@mail.yahoo.com> From: Simon Marchi Message-ID: Date: Tue, 28 Jan 2020 17:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <720913399.742914.1580230424544@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2020-01/txt/msg00908.txt.bz2 Content-length: 1484 On 2020-01-28 11:53 a.m., Hannes Domani via gdb-patches wrote: > I just noticed that gdbserver is a bit broken for x86_64-mingw (and I think > it always was).> > Reason for it is this part in gdbserver/server.c: > >     document += string_printf >       ("  \n", >        dll.name.c_str (), (long) dll.base_addr); > > (long) is always 32bit on Windows, so the upper bits are cut off. Indeed. That code went through several refactors, but originally it was introduced by this 2007 commit: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=255e7678a93693bd4d16cc3246442a1b8e11064e which has this line: sprintf (p, "0x%lx", (long) dll->base_addr); So I think the bug has been there forever. > Fix seems simple: > >      document += string_printf > -      ("  \n", > -       dll.name.c_str (), (long) dll.base_addr); > +      ("  \n", > +       dll.name.c_str (), paddress (dll.base_addr)); > > I just tested it and this improves the debugging experience a lot. > > But I guess this is probably too late for the release. I don't think it so, we can always push fixes to the release branch. This one seems desirable and not risky at all, so I think it would be fine. Would you be willing to submit a complete patch for this? Simon