From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93619 invoked by alias); 17 Jan 2020 07:25:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93286 invoked by uid 89); 17 Jan 2020 07:24:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=Supervisory, supervisory X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2020 07:24:51 +0000 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2020 23:24:50 -0800 Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga005.jf.intel.com with ESMTP; 16 Jan 2020 23:24:49 -0800 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 23:24:49 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX123.amr.corp.intel.com (10.22.240.116) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 23:24:49 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 23:24:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVdjtuhtJv7vdoIdH3OrNGT1AtqQS7yOmjRy9ydhChJJvr4uRVVuklPXsNXmoz4xQc919Q8K/M4To50HXvsd2n/Y+zztACM+eD/jcSuqwFjcaMf1l3nAmEB9mFX5bpqMWWssPHhP2POZ8VgVdwUCCqH+a5OuR2GRLyQJBF3+IKuHvKp1l3KTUzMwH3Z8b7rEYcHz6QLrCOxyCKUGDwldKSA8kj6ZnRJl70vYvPpXlzOygzJSF6GYkaE6jZ4fr024rik6yMEkzQMYvDy03xgrJY1VdQzXFUX6qE97l6/VJAG4sBpstgjfVcn4tyCdmMpXVjyLJNQGbuflTQNGSrpPkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KY/kBERGKK+9iLUju+AarmW70Cy2Uw5bPAFJMzjBmnw=; b=l6sJIFsceWj768flQiyLifTYrFhHsonKxixekEwmbBgHDRya39GnH7N7Ezjq5p1qdg5JDlISt704lolcvVEarxC4UlSoNWQ/BzhYRP7uzM0cCTmx00xr4HSk4ZMzfPks50Wq4Jlc1y2Yp3eovdKtRt0f59i/oLERfv9AxWGrAjY9L5o0QV/dgnkSkmoY8ZSQQsu7PZclqxDoc8JfC5NB/2AKqqZ3YR5wPDmNdnVodigfZ3AL+h+TmiA6y2OtEDrpt8CxV1ic+7Khw1d13WFwL5gP9/eQFPB4nApf2kBkzVw69qPkhlePkqfbrBxItJGJleXyx33mzCek7DOHKbv6DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KY/kBERGKK+9iLUju+AarmW70Cy2Uw5bPAFJMzjBmnw=; b=nuCOEJrMoUBjX1hIMak8NYddYSB06Qz3cR21s8WfBrzoiF2i1hl9gcAHz0hNQP0vglhBPaskVcp4zjHcid4fBfDoS8tT+Kk/+fjwmJqiApLx3Gfpry52AGuz+eeVexbu0sjDVTQYiJwXJkB0taXq8IQqNajNy27taoEM73Hcggo= Received: from BYAPR11MB3030.namprd11.prod.outlook.com (20.177.225.91) by BYAPR11MB2615.namprd11.prod.outlook.com (52.135.225.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.21; Fri, 17 Jan 2020 07:24:47 +0000 Received: from BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::2c94:a4bd:2d9c:30b]) by BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::2c94:a4bd:2d9c:30b%6]) with mapi id 15.20.2623.015; Fri, 17 Jan 2020 07:24:47 +0000 From: "Aktemur, Tankut Baris" To: Simon Marchi , Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/4] gdb: remove use of iterate_over_inferiors in mi/mi-interp.c Date: Fri, 17 Jan 2020 07:52:00 -0000 Message-ID: References: <20200115191222.28208-1-simon.marchi@efficios.com> <20200115191222.28208-3-simon.marchi@efficios.com> <80e26b82-476e-f898-3b97-4d923c2eb6e7@simark.ca> In-Reply-To: <80e26b82-476e-f898-3b97-4d923c2eb6e7@simark.ca> authentication-results: spf=none (sender IP is ) smtp.mailfrom=tankut.baris.aktemur@intel.com; x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /H8tGCliRbaKNbQUCFIVbnW9H2tkAdsyYyLkApBe4TQwdAr0LZXWNhQSNMS5HRULfmuZzdVRS0bnH+OOcXqFgDIjSePIj3RhvCh1OUE9YAM= Return-Path: tankut.baris.aktemur@intel.com Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00501.txt.bz2 T24gVGh1cnNkYXksIEphbnVhcnkgMTYsIDIwMjAgNDoyNCBQTSwgU2ltb24g TWFyY2hpIHdyb3RlOg0KPiBPbiAyMDIwLTAxLTE2IDQ6MDEgYS5tLiwgQWt0 ZW11ciwgVGFua3V0IEJhcmlzIHdyb3RlOg0KPiA+PiBAQCAtMTQwLDggKzEz OCwyMiBAQCBtaV9pbnRlcnA6OmluaXQgKGJvb2wgdG9wX2xldmVsKQ0KPiA+ PiAgICAgICAgLyogVGhlIGluaXRpYWwgaW5mZXJpb3IgaXMgY3JlYXRlZCBi ZWZvcmUgdGhpcyBmdW5jdGlvbiBpcw0KPiA+PiAgCSBjYWxsZWQsIHNvIHdl IG5lZWQgdG8gcmVwb3J0IGl0IGV4cGxpY2l0bHkuICBVc2UgaXRlcmF0aW9u IGluDQo+ID4+ICAJIGNhc2UgZnV0dXJlIHZlcnNpb24gb2YgR0RCIGNyZWF0 ZXMgbW9yZSB0aGFuIG9uZSBpbmZlcmlvcg0KPiA+PiAtCSB1cC1mcm9udC4g ICovDQo+ID4+IC0gICAgICBpdGVyYXRlX292ZXJfaW5mZXJpb3JzIChyZXBv cnRfaW5pdGlhbF9pbmZlcmlvciwgbWkpOw0KPiA+PiArCSB1cC1mcm9udC4N Cj4gPj4gKw0KPiA+PiArICAgICAgICAgVGhpcyBmdW5jdGlvbiBpcyBjYWxs ZWQgZnJvbSBtaV9pbnRlcnByZXRlcl9pbml0LCBhbmQgc2luY2UNCj4gPg0K PiA+IFRoZXJlIGlzIGFuIDgtc3BhY2VzL3RhYiBpc3N1ZSBhYm92ZS4gIEFu ZCBhbHNvLCB0aGUgY29tbWVudCBwaWVjZSAiVGhpcw0KPiA+IGZ1bmN0aW9u IGlzIGNhbGxlZCBmcm9tIG1pX2ludGVycHJldGVyX2luaXQsIGFuZCIgc2Vl bXMgb2Jzb2xldGUgbm93Lg0KPiANCj4gVGhhbmtzIGZvciBzcG90dGluZyB0 aGVzZS4NCj4gDQo+IFRoYXQgbWFkZSBtZSByZWFsaXplIHRoZXJlIGFyZSBt YW55IGlzc3VlcyB3aXRoIHRoYXQgY29tbWVudC4NCj4gDQo+IC0gVGhlIHBh cnQgYWJvdXQgbm90IGJlaW5nIGFibGUgdG8gdXNlIG1pX2luZmVyaW9yX2Fk ZGVkIGJlY2F1c2UgdG9wX2xldmVsX2ludGVycHJldGVyX2RhdGENCj4gICBp cyBub3Qgc2V0IGlzIHN0YWxlLiAgVGhhdCB3YXMgdHJ1ZSBiZWZvcmUgdGhl IGludGVycHMgd2VyZSBtYWRlIGludG8gQysrIGNsYXNzZXMuICBCYWNrDQo+ ICAgdGhlbiwgdGhlIG1pX2ludGVycHJldGVyX2luaXQgZnVuY3Rpb24gd291 bGQgcmV0dXJuIHRoZSBwb2ludGVyIHRvIGJlIHVzZWQgYXMgaW50ZXJwcmV0 ZXINCj4gICBkYXRhLCB3aGljaCB0aGUgY2FsbGVyICh0aGUgaW50ZXJwX3Nl dCBmdW5jdGlvbikgd291bGQgYXNzaWduIHRvIGludGVycC0+ZGF0YS4gIFNv IGl0IHdhcw0KPiAgIGluZGVlZCBub3QgcG9zc2libGUgdG8gY2FsbCBtaV9p bmZlcmlvcl9hZGRlZCwgYmVjYXVzZSBpdCByZXF1aXJlZCBpbnRlcnAtPmRh dGEgdG8gYmUgc2V0Lg0KPiANCj4gLSBJdCBpcyBzdGlsbCBub3QgcG9zc2li bGUgdG9kYXkgdG8gdXNlIG1pX2luZmVyaW9yX2FkZGVkLCBiZWNhdXNlIGl0 IGl0ZXJhdGVzIG92ZXIgYWxsIE1JIFVJcw0KPiAgIGFuZCB0byBwcmludCB0 aGUgZXZlbnQgb24gYWxsIG9mIHRoZW0uICBTbyBpZiB5b3UgZG86DQo+IA0K PiAgIDEuIFN0YXJ0IEdEQiB3aXRoIGAtaSBtaWANCj4gICAyLiBBZGQgc29t ZSBpbmZlcmlvcnMNCj4gICAzLiBDcmVhdGUgYSBuZXcgTUkgVUksIHdpdGgg YG5ldy11aSBtaSAvZGV2L3B0cy9YYA0KPiANCj4gICBXaGVuIGluaXRpYWxp emluZyB0aGUgbmV3IE1JIFVJLCBpdCB3aWxsIHByaW50IHRoZSBpbmZlcmlv ci1hZGRlZCBldmVudHMgb24gYm90aCBNSSBVSXMuDQo+IA0KPiAtIEl0IGlz IG5lY2Vzc2FyeSB0byB1c2UgaXRlcmF0aW9uLCBub3Qgb25seSBpbiBjYXNl IEdEQiBjcmVhdGVzIG1vcmUgdGhhbiBvbmUgaW5mZXJpb3INCj4gICB1cCBm cm9udCwgYnV0IGFsc28gYmVjYXVzZSB0aGVyZSBtaWdodCBiZSBtdWx0aXBs ZSBpbmZlcmlvcnMgd2hlbiBpbml0aWFsaXppbmcgYSBzZWNvbmRhcnkNCj4g ICBNSSBVSSwgYXMgc2hvd24gYWJvdmUuDQo+IA0KPiBJIGRvbid0IGtub3cg aWYgaXQgaXMgYnkgZGVzaWduLCB0aGF0IHRoZSA9aW5mZXJpb3ItYWRkZWQg ZXZlbnRzIGFyZSBzZW50IHRvIGEgbmV3IE1JIFVJIGFkZGVkDQo+IHdpdGgg bmV3LXVpLCBidXQgaW4gYW55IGNhc2UgSSBkb24ndCB3YW50IHRvIGNoYW5n ZSB0aGUgYmVoYXZpb3Igd2l0aCB0aGlzIHBhdGNoLg0KPiANCj4gQWxzbywg d2hlbiB0ZXN0aW5nIHRoaXMsIEkgcmVhbGl6ZWQgaXQgd2FzIHdyb25nIHRv IHB1dCB0aGUgZ2RiX2ZsdXNoIG91dCBvZiB0aGUgbG9vcC4gIEl0J3Mgbm90 DQo+IGEgc2ltcGxlIGZsdXNoIGFzIGluICJtYWtlIHN1cmUgdGhlIGRhdGEg aXMgYWxsIHNlbnQgdG8gdGhlIHVuZGVybHlpbmcgZGV2aWNlIiwgaXQncyBh bHNvIHdoYXQNCj4gYWRkcyB0aGUgZmluYWwgXG4hICBTbyB3aXRoIHRoZSBn ZGJfZmx1c2ggb3V0c2lkZSB0aGUgbG9vcCwgYWxsIHRoZSBldmVudHMgd2Vy ZSBwcmludGVkIG9uIHRoZSBzYW1lDQo+IGxpbmUuICBJJ3ZlIHB1dCB0aGUg dGVybWluYWwgc2V0dGluZyBjYWxscyBhbmQgdGhlIGdkYl9mbHVzaCBiYWNr IGludG8gdGhlIGxvb3AsIHRvIG1pbmltaXplIHRoZQ0KPiBjaGFuZ2VzLg0K PiANCj4gVGhlIHBhdGNoIHdvdWxkIG5vdyBsb29rIGxpa2UgdGhpczoNCg0K VGhhbmsgeW91IGZvciB0aGUgZGV0YWlsZWQgZXhwbGFuYXRpb24uICBJIHRo aW5rIHRoZSByZXZpc2VkIHBhdGNoIGlzIHZlcnkgY2xlYXIuDQoNCi1CYXJp cw0KDQo+IA0KPiBGcm9tIGNiODQ1YTRmMjhkMTc2MWZlYjQ2MzkxNGMxM2Iw YTQ1Yzk3ZDk5NzQgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxDQo+IEZyb206 IFNpbW9uIE1hcmNoaSA8c2ltb24ubWFyY2hpQGVmZmljaW9zLmNvbT4NCj4g RGF0ZTogV2VkLCAxNSBKYW4gMjAyMCAxNDoxMjoyMCAtMDUwMA0KPiBTdWJq ZWN0OiBbUEFUQ0hdIGdkYjogcmVtb3ZlIHVzZSBvZiBpdGVyYXRlX292ZXJf aW5mZXJpb3JzIGluIG1pL21pLWludGVycC5jDQo+IA0KPiBSZXBsYWNlIGl0 IHdpdGggYSByYW5nZS1iYXNlZCBmb3IuICBJJ3ZlIHVwZGF0ZWQgdGhlIGNv bW1lbnQgaW4NCj4gbWlfaW50ZXJwOjppbml0LCB3aGljaCB3YXMgYSBiaXQg c3RhbGUuDQo+IA0KPiBnZGIvQ2hhbmdlTG9nOg0KPiANCj4gCSogbWkvbWkt aW50ZXJwLmMgKHJlcG9ydF9pbml0aWFsX2luZmVyaW9yKTogUmVtb3ZlLg0K PiAJKG1pX2ludGVycDo6aW5pdCk6IFVzZSByYW5nZS1iYXNlZCBmb3IgdG8g aXRlcmF0ZSBvdmVyIGluZmVyaW9ycy4NCj4gLS0tDQo+ICBnZGIvbWkvbWkt aW50ZXJwLmMgfCA0OSArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEgaW5zZXJ0 aW9ucygrKSwgMjggZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEv Z2RiL21pL21pLWludGVycC5jIGIvZ2RiL21pL21pLWludGVycC5jDQo+IGlu ZGV4IDJhYzRjMTE5OTYxYy4uZTc3MDkzY2ZhMjgyIDEwMDY0NA0KPiAtLS0g YS9nZGIvbWkvbWktaW50ZXJwLmMNCj4gKysrIGIvZ2RiL21pL21pLWludGVy cC5jDQo+IEBAIC05MSw4ICs5MSw2IEBAIHN0YXRpYyB2b2lkIG1pX21lbW9y eV9jaGFuZ2VkIChzdHJ1Y3QgaW5mZXJpb3IgKmluZiwgQ09SRV9BRERSIG1l bWFkZHIsDQo+ICAJCQkgICAgICAgc3NpemVfdCBsZW4sIGNvbnN0IGJmZF9i eXRlICpteWFkZHIpOw0KPiAgc3RhdGljIHZvaWQgbWlfb25fc3luY19leGVj dXRpb25fZG9uZSAodm9pZCk7DQo+IA0KPiAtc3RhdGljIGludCByZXBvcnRf aW5pdGlhbF9pbmZlcmlvciAoc3RydWN0IGluZmVyaW9yICppbmYsIHZvaWQg KmNsb3N1cmUpOw0KPiAtDQo+ICAvKiBEaXNwbGF5IHRoZSBNSSBwcm9tcHQu ICAqLw0KPiANCj4gIHN0YXRpYyB2b2lkDQo+IEBAIC0xMzcsMTIgKzEzNSwy NyBAQCBtaV9pbnRlcnA6OmluaXQgKGJvb2wgdG9wX2xldmVsKQ0KPiANCj4g ICAgaWYgKHRvcF9sZXZlbCkNCj4gICAgICB7DQo+IC0gICAgICAvKiBUaGUg aW5pdGlhbCBpbmZlcmlvciBpcyBjcmVhdGVkIGJlZm9yZSB0aGlzIGZ1bmN0 aW9uIGlzDQo+IC0JIGNhbGxlZCwgc28gd2UgbmVlZCB0byByZXBvcnQgaXQg ZXhwbGljaXRseS4gIFVzZSBpdGVyYXRpb24gaW4NCj4gLQkgY2FzZSBmdXR1 cmUgdmVyc2lvbiBvZiBHREIgY3JlYXRlcyBtb3JlIHRoYW4gb25lIGluZmVy aW9yDQo+IC0JIHVwLWZyb250LiAgKi8NCj4gLSAgICAgIGl0ZXJhdGVfb3Zl cl9pbmZlcmlvcnMgKHJlcG9ydF9pbml0aWFsX2luZmVyaW9yLCBtaSk7DQo+ IC0gICAgfQ0KPiArICAgICAgLyogVGhlIGluaXRpYWwgaW5mZXJpb3IgaXMg Y3JlYXRlZCBiZWZvcmUgdGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQsIHNvIHdl DQo+ICsJIG5lZWQgdG8gcmVwb3J0IGl0IGV4cGxpY2l0bHkgd2hlbiBpbml0 aWFsaXppbmcgdGhlIHRvcC1sZXZlbCBNSQ0KPiArCSBpbnRlcnByZXRlci4N Cj4gKw0KPiArCSBUaGlzIGlzIGFsc28gY2FsbGVkIHdoZW4gYWRkaXRpb25h bCBNSSBpbnRlcnByZXRlcnMgYXJlIGFkZGVkICh1c2luZw0KPiArCSB0aGUg bmV3LXVpIGNvbW1hbmQpLCB3aGVuIG11bHRpcGxlIGluZmVyaW9ycyBwb3Nz aWJseSBleGlzdCwgc28gd2UgbmVlZA0KPiArCSB0byB1c2UgaXRlcmF0aW9u IHRvIHJlcG9ydCBhbGwgdGhlIGluZmVyaW9ycy4gIG1pX2luZmVyaW9yX2Fk ZGVkIGNhbid0DQo+ICsJIGJlIHVzZWQsIGJlY2F1c2UgaXQgd291bGQgcHJp bnQgdGhlIGV2ZW50IG9uIGFsbCB0aGUgb3RoZXIgTUkgVUlzLiAgKi8NCj4g Kw0KPiArICAgICAgZm9yIChpbmZlcmlvciAqaW5mIDogYWxsX2luZmVyaW9y cyAoKSkNCj4gKwl7DQo+ICsJICB0YXJnZXRfdGVybWluYWw6OnNjb3BlZF9y ZXN0b3JlX3Rlcm1pbmFsX3N0YXRlIHRlcm1fc3RhdGU7DQo+ICsJICB0YXJn ZXRfdGVybWluYWw6Om91cnNfZm9yX291dHB1dCAoKTsNCj4gKw0KPiArCSAg ZnByaW50Zl91bmZpbHRlcmVkIChtaS0+ZXZlbnRfY2hhbm5lbCwNCj4gKwkJ CSAgICAgICJ0aHJlYWQtZ3JvdXAtYWRkZWQsaWQ9XCJpJWRcIiIsDQo+ICsJ CQkgICAgICBpbmYtPm51bSk7DQo+ICsNCj4gKwkgIGdkYl9mbHVzaCAobWkt PmV2ZW50X2NoYW5uZWwpOw0KPiArCX0NCj4gKyAgfQ0KPiAgfQ0KPiANCj4g IHZvaWQNCj4gQEAgLTEyNTMsMjYgKzEyNjYsNiBAQCBtaV91c2VyX3NlbGVj dGVkX2NvbnRleHRfY2hhbmdlZCAodXNlcl9zZWxlY3RlZF93aGF0IHNlbGVj dGlvbikNCj4gICAgICB9DQo+ICB9DQo+IA0KPiAtc3RhdGljIGludA0KPiAt cmVwb3J0X2luaXRpYWxfaW5mZXJpb3IgKHN0cnVjdCBpbmZlcmlvciAqaW5m LCB2b2lkICpjbG9zdXJlKQ0KPiAtew0KPiAtICAvKiBUaGlzIGZ1bmN0aW9u IGlzIGNhbGxlZCBmcm9tIG1pX2ludGVycHJldGVyX2luaXQsIGFuZCBzaW5j ZQ0KPiAtICAgICBtaV9pbmZlcmlvcl9hZGRlZCBhc3N1bWVzIHRoYXQgaW5m ZXJpb3IgaXMgZnVsbHkgaW5pdGlhbGl6ZWQNCj4gLSAgICAgYW5kIHRvcF9s ZXZlbF9pbnRlcnByZXRlcl9kYXRhIGlzIHNldCwgd2UgY2Fubm90IGNhbGwN Cj4gLSAgICAgaXQgaGVyZS4gICovDQo+IC0gIHN0cnVjdCBtaV9pbnRlcnAg Km1pID0gKHN0cnVjdCBtaV9pbnRlcnAgKikgY2xvc3VyZTsNCj4gLQ0KPiAt ICB0YXJnZXRfdGVybWluYWw6OnNjb3BlZF9yZXN0b3JlX3Rlcm1pbmFsX3N0 YXRlIHRlcm1fc3RhdGU7DQo+IC0gIHRhcmdldF90ZXJtaW5hbDo6b3Vyc19m b3Jfb3V0cHV0ICgpOw0KPiAtDQo+IC0gIGZwcmludGZfdW5maWx0ZXJlZCAo bWktPmV2ZW50X2NoYW5uZWwsDQo+IC0JCSAgICAgICJ0aHJlYWQtZ3JvdXAt YWRkZWQsaWQ9XCJpJWRcIiIsDQo+IC0JCSAgICAgIGluZi0+bnVtKTsNCj4g LSAgZ2RiX2ZsdXNoIChtaS0+ZXZlbnRfY2hhbm5lbCk7DQo+IC0NCj4gLSAg cmV0dXJuIDA7DQo+IC19DQo+IC0NCj4gIHVpX291dCAqDQo+ICBtaV9pbnRl cnA6OmludGVycF91aV9vdXQgKCkNCj4gIHsNCj4gLS0NCj4gMi4yNC4xDQo+ IA0KDQpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVyZWQgQWRkcmVz czogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJnLCBHZXJtYW55 ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVsLmRlCk1hbmFnaW5n IERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2htaWQsIEdhcnkgS2Vyc2hh dwpDaGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2aXNvcnkgQm9hcmQ6IE5pY29s ZSBMYXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11bmljaApDb21tZXJjaWFsIFJl Z2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hlbiBIUkIgMTg2OTI4Cg== >From gdb-patches-return-163188-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Jan 17 07:52:53 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 13885 invoked by alias); 17 Jan 2020 07:52:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 13877 invoked by uid 89); 17 Jan 2020 07:52:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jan 2020 07:52:42 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1isMQp-0003ZJ-Vi; Fri, 17 Jan 2020 02:52:40 -0500 Received: from [176.228.60.248] (port=4599 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1isMQo-0000ke-Bn; Fri, 17 Jan 2020 02:52:39 -0500 Date: Fri, 17 Jan 2020 07:57:00 -0000 Message-Id: <83eevy34fv.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: tromey@adacore.com, gdb-patches@sourceware.org In-reply-to: (message from Pedro Alves on Thu, 16 Jan 2020 20:37:28 +0000) Subject: Re: [PATCH 2/3] Consistently use BFD's time References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00502.txt.bz2 Content-length: 493 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Thu, 16 Jan 2020 20:37:28 +0000 > > #define COPY(FIELD) statbuf->FIELD = st.FIELD > COPY (st_dev); > // ... copy over all relevant fields ... > #undef COPY Copying fields will work, but it would need some care. For example, the Gnulib replacement of 'struct stat' redefines st_size and st_mtime to wider data types, so copying from the Gnulib definition to the system definition might overflow. Thanks.