From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34837 invoked by alias); 15 Jan 2020 14:30:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5169 invoked by uid 89); 15 Jan 2020 14:30:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=directors, dw_at_deleted, DW_AT_deleted, Directors X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2020 14:30:24 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 06:30:09 -0800 Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga001.fm.intel.com with ESMTP; 15 Jan 2020 06:30:09 -0800 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jan 2020 06:30:09 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX112.amr.corp.intel.com (10.22.240.13) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jan 2020 06:30:08 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jan 2020 06:30:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OtUiTFTW+RBX2r0d0e8rpV/pQRg6rn8+ANp+4HBbqUTyr90cF3/kPZZPoI69+A2sSX7PXfV3DMuguV74/b3m1u0tgjOUZ5EpKy1p+S0aqFPnXmy5ZPM4qHLRksCI80UAnXe3nzEn311h2KO1N7yve9VzeHm28cgDOTUR3eT1s1jyi7OOY4w2LaVvtvflJXsdDH0QVNIbVKJE1gp7Tgg1cbZoSo0q/QDTa1NW3bAeBJrUjH3BF/V+HBRjZB1iVbMQGm5N0XJE6YMIckULuNALMNmLnyT3Uy9J+Bv+GfjaE9H3V8dbmbV2wS5aou7mQsJgKxWtxoJ4cOO/e5Udi9/AJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vmcgbLhqbbFDFGCRc0u3/F5+rJ9gcyu4vzJ1C9j4Fc=; b=BhueXg6OwKc8RkjotzcXDByr/S2BlzMIRoUs8iQ3gkmZmqKuXS1vyx45r4fq2EhbVcCzN+Zp4OISMhu/36/WrTkXDjKj3PUCqOQt36fiNzChqnpHsdGtm3oyuOenc1FysQjbdNYF0oUIQftlNqvOjaIXAFyZhk443hldL96agNs+ftCUXKry9eR4O0ZtIMxFbVuzSgo4bRM2ibYrVeUYHqx93W/W1Hl+Upxp09PQ1M8sX1CPUPsYizJwtO/Wg95nMwaEN8VrVEP8WNZsxr63xBYMutV0cXAk40bywppwKdrhu8dO6TBMyuxhos4lT28Y0KBXH9jFsUMnMjOSAawVTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vmcgbLhqbbFDFGCRc0u3/F5+rJ9gcyu4vzJ1C9j4Fc=; b=dHqFbTbHQnE1CwAwTcwKvzCs4HlR68Uagl8CARZzLHuLSMc0O7R3+8qhA0VfXP+VB9q7tpAzeX5HJsEOfbuPdRsgm+GLhEQdV4wbR01BqfWZeO6yZsaoT3FjhbmM+fjpwKUOWSxvfYHdUz10ijFZLXqwtKpn/RfBV0hdlgWj9P0= Received: from BYAPR11MB3030.namprd11.prod.outlook.com (20.177.225.91) by BYAPR11MB3637.namprd11.prod.outlook.com (20.178.237.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Wed, 15 Jan 2020 14:30:07 +0000 Received: from BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::2c94:a4bd:2d9c:30b]) by BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::2c94:a4bd:2d9c:30b%6]) with mapi id 15.20.2623.015; Wed, 15 Jan 2020 14:30:07 +0000 From: "Aktemur, Tankut Baris" To: Luis Machado , "tromey@sourceware.org" , "gdb-patches@sourceware.org" Subject: RE: [review v3] testsuite, cp: increase the coverage of testing pass-by-ref arguments Date: Wed, 15 Jan 2020 14:41:00 -0000 Message-ID: References: <20191214095325.3864520AF6@gnutoolchain-gerrit.osci.io> <80c8502f-a350-6a2b-0b72-bbc903f53bc3@linaro.org> <0dd26985-5952-d010-135f-a92aba6f9a05@linaro.org> In-Reply-To: <0dd26985-5952-d010-135f-a92aba6f9a05@linaro.org> authentication-results: spf=none (sender IP is ) smtp.mailfrom=tankut.baris.aktemur@intel.com; x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DCoWe1uuqhHjExEk/PNNY4t0rLAhGuJ7kPzcPNEoeK0acMmlfOApUPhZDx4NsIH1yUS2a5XYkPIlJWNOKgrHK55XjrHJFWNuLlyAXqQp6rM= Return-Path: tankut.baris.aktemur@intel.com Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00419.txt.bz2 T24gVHVlc2RheSwgSmFudWFyeSAxNCwgMjAyMCAyOjEzIFBNLCBMdWlzIE1h Y2hhZG8gd3JvdGU6DQo+IA0KPiBPbiAxLzE0LzIwIDk6NTIgQU0sIEFrdGVt dXIsIFRhbmt1dCBCYXJpcyB3cm90ZToNCj4gPg0KPiA+IEkndmUgaW52ZXN0 aWdhdGVkIEdDQyBhbmQgQ2xhbmcgZm9yIHRoaXMuICBHQ0Mgc3RhcnRlZCBl bWl0dGluZyBEV19BVF9kZWxldGVkIGFuZA0KPiA+IERXX0FUX2RlZmF1bHRl ZCB3aXRoIHZlcnNpb24gNy4gIENsYW5nIGRvZXMgbm90IGVtaXQgdGhlc2Ug YXR0cmlidXRlczsgaG93ZXZlciwgaXQNCj4gPiBoYXMgYmVlbiBlbWl0dGlu ZyBEV19BVF9jYWxsaW5nX2NvbnZlbnRpb24gc3RhcnRpbmcgd2l0aCB2ZXJz aW9uIDcuICBUaGlzDQo+ID4gYXR0cmlidXRlIGhlbHBzIHRoZSBkZWJ1Z2dl ciBtYWtlIHRoZSByaWdodCBkZWNpc2lvbiBpbiBzb21lIGNhc2VzLg0KPiA+ DQo+ID4gQmFzZWQgb24gdGhpcywgSSB0aGluayB0aGUgdGVzdCBjYXNlcyBo YXZlIHRvIGJlIGZpbHRlcmVkIGluIGEgc29tZXdoYXQNCj4gPiBmaW5lLWdy YW51bGFyIG1hbm5lci4gIFRoZXJlZm9yZSBJIHRob3VnaHQgSSBjb3VsZCBz YXZlIHlvdSBmcm9tIHRoZSBidXJkZW4gb2YNCj4gPiBoYXZpbmcgdG8gZ28g dGhyb3VnaCB0aGUgY29kZS1nZW5lcmF0aW5nIHRlc3QgZGVmaW5pdGlvbi4g IEJlbG93IGlzIGEgcGF0Y2ggcHJvcG9zYWwuDQo+ID4NCj4gPiAtQmFyaXMN Cj4gDQo+IFRoYW5rcyEgSSd2ZSBjaGVja2VkIHRoaXMgb24gbXkgYm94IHdp dGggYW4gb2xkZXIgR0NDIGFuZCBpIHNlZSB0aGUNCj4gWEZBSUwncyBub3cu IFNvIGl0IGxvb2tzIGdvb2QgdG8gbWUuDQo+IA0KPiBTbWFsbCBuaXQgYmVs b3cuLi4NCj4gDQoNClRoYW5rIHlvdS4gIEknbGwgZml4IHRoYXQgYW5kIHdh aXQgZm9yIGFuIG9mZmljaWFsIGFwcHJvdmFsLg0KDQotQmFyaXMNCg0KPiA+ ICsjIEdDQyB2ZXJzaW9uIDw9IDYgYW5kIENsYW5nIGRvIG5vdCBlbWl0IERX X0FUX2RlZmF1bHRlZCBhbmQgRFdfQVRfZGVsZXRlZA0KPiA+ICtzZXQgaXNf Z2NjXzZfb3Jfb2xkZXIgW3Rlc3RfY29tcGlsZXJfaW5mbyB7Z2NjLVswLTZd LSp9XQ0KPiA+ICtzZXQgaXNfY2xhbmcgW3Rlc3RfY29tcGlsZXJfaW5mbyB7 Y2xhbmctKn1dDQo+ID4gKw0KPiA+ICAgc2V0IGJwX2xvY2F0aW9uIFtnZGJf Z2V0X2xpbmVfbnVtYmVyICJzdG9wIGhlcmUiXQ0KPiA+ICAgZ2RiX2JyZWFr cG9pbnQgJGJwX2xvY2F0aW9uDQo+ID4gICBnZGJfY29udGludWVfdG9fYnJl YWtwb2ludCAiZW5kIG9mIG1haW4iICIuKnJldHVybiAuKjsiDQo+IA0KPiBJ dCBzZWVtcyB0byBiZSBhIG1peGVkIGJhZywgYnV0IGkgc2VlIG1vcmUgZXhh bXBsZXMgb2YgaGF2aW5nIGEgcGVyaW9kDQo+IGFmdGVyIHRoZSBzZW50ZW5j ZSB0aGFuIG5vdCBoYXZpbmcgaXQuIE11bHRpcGxlIGNhc2VzIG9mIHRoaXMg b24gdGhlIHBhdGNoLg0KPiANCkludGVsIERldXRzY2hsYW5kIEdtYkgKUmVn aXN0ZXJlZCBBZGRyZXNzOiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBOZXVi aWJlcmcsIEdlcm1hbnkKVGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cuaW50 ZWwuZGUKTWFuYWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNjaG1p ZCwgR2FyeSBLZXJzaGF3CkNoYWlycGVyc29uIG9mIHRoZSBTdXBlcnZpc29y eSBCb2FyZDogTmljb2xlIExhdQpSZWdpc3RlcmVkIE9mZmljZTogTXVuaWNo CkNvbW1lcmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0IE11ZW5jaGVuIEhS QiAxODY5MjgK >From gdb-patches-return-163106-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jan 15 14:41:49 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 62310 invoked by alias); 15 Jan 2020 14:41:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 62286 invoked by uid 89); 15 Jan 2020 14:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=foreign X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2020 14:41:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579099303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPwgRnrI5/0Ps3MVG1qVZofMSZAPKLBV37Xi2AJ8V5w=; b=hKRLET1K3Ev3/m2ildN0GkwVOod8SlQ1FyidFXUTASgdQnJADxjEiqthZ2c1y8sV8dxZDY HOa7TULL13goWmpsDLIiHO1RiTQubJl5nykDkyoAJYeDsKoUMrsPFYSl1VdbJxeEzg7RzC 1PhfpMnhe0dT61KxQkQA3LHMr4SHE1I= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-OxRdXnAqMdC2gF90dlnD2g-1; Wed, 15 Jan 2020 09:41:41 -0500 Received: by mail-wm1-f71.google.com with SMTP id h130so18828wme.7 for ; Wed, 15 Jan 2020 06:41:41 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id e8sm24930942wrt.7.2020.01.15.06.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2020 06:41:39 -0800 (PST) Subject: Re: [PATCH v2 0/6] Move gdbsupport to top level To: Tom Tromey , gdb-patches@sourceware.org References: <20200109005807.7314-1-tom@tromey.com> From: Pedro Alves Message-ID: <8a8de6a9-37b8-cad3-c818-be903037fe48@redhat.com> Date: Wed, 15 Jan 2020 14:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00420.txt.bz2 Content-length: 4230 On 1/15/20 2:09 PM, Pedro Alves wrote: > So it seems like the issue is that that '#include ' picks up > bfd's config.h instead of gnulib's by mistake. I guess that this problem doesn't trigger in the gdb dir because there we generate config.h under that exact name so gnulib's libc-config.h ends up picking gdb's config.h instead of gnulib.c and that ends up harmless. In gdbsupport, the config.h file is really named support-config.h, so that '#include ' in libc-config.h doesn't pick it like it would if it had the conventional config.h name. gnulib's config.h is generated under build/gnulib/ directly, so adding that to the include path fixes it for me. Don't know what I think of gnulib headers including . Maybe we should rename gdb's config.h to gdb-config.h too. >From e212b0a4e5d332ddcc4ea12ce51481a3bf90ef34 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 15 Jan 2020 14:12:43 +0000 Subject: [PATCH] Fix gdbsupport build I'm seeing this on F27 (a clean build from scratch): ~~~~~~~~~~~~~~~~~~~~~~~~~~~ make[3]: Entering directory '/home/pedro/brno/pedro/gdb/binutils-gdb/build/gdbsupport' CC gdb_tilde_expand.o In file included from /home/pedro/gdb/binutils-gdb/src/gdbsupport/../gnulib/import/libc-config.h:33:0, from ../gnulib/import/glob.h:544, from /home/pedro/gdb/binutils-gdb/src/gdbsupport/gdb_tilde_expand.c:22: ../bfd/config.h:7:4: error: #error config.h must be #included before system headers # error config.h must be #included before system headers ^~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ libc-config.h, where it includes config.h, says: ~~~~~~~~~~~~~~~~~~~~~~~~~~~ /* This is intended to be a good-enough substitute for glibc system macros like those defined in , so that Gnulib code shared with glibc can do this as the first #include: #ifndef _LIBC # include #endif When compiled as part of glibc this is a no-op; when compiled as part of Gnulib this includes Gnulib's and defines macros that glibc library code would normally assume. */ #include ~~~~~~~~~~~~~~~~~~~~~~~~~~~ The issue is that that '#include ' picks up bfd's config.h instead of gnulib's. I guess that this problem doesn't trigger in the gdb dir because there we generate config.h under that exact name so gnulib's libc-config.h ends up picking gdb's config.h instead of gnulib.c and that ends up harmless. In gdbsupport, the config.h file is really named support-config.h, so that '#include ' in libc-config.h doesn't pick it like it would if it had the conventional config.h name. gnulib's config.h is generated under build/gnulib/ directly, so adding that to the include path fixes it for me. gdbsupport/ChangeLog: yyyy-mm-dd Pedro Alves * Makefile.am (AM_CPPFLAGS): Add -I../gnulib. * Makefile.in: Regenerate. --- gdbsupport/Makefile.am | 2 +- gdbsupport/Makefile.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am index 1a001a00817..fdf376b2e12 100644 --- a/gdbsupport/Makefile.am +++ b/gdbsupport/Makefile.am @@ -21,7 +21,7 @@ AUTOMAKE_OPTIONS = no-dist foreign ACLOCAL_AMFLAGS = -I . -I ../config AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \ - -I../gnulib/import -I$(srcdir)/../gnulib/import \ + -I../gnulib -I../gnulib/import -I$(srcdir)/../gnulib/import \ -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd override CC := $(CXX) diff --git a/gdbsupport/Makefile.in b/gdbsupport/Makefile.in index 5723ae5e97e..c3e6b744ec0 100644 --- a/gdbsupport/Makefile.in +++ b/gdbsupport/Makefile.in @@ -347,7 +347,7 @@ top_srcdir = @top_srcdir@ AUTOMAKE_OPTIONS = no-dist foreign ACLOCAL_AMFLAGS = -I . -I ../config AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \ - -I../gnulib/import -I$(srcdir)/../gnulib/import \ + -I../gnulib -I../gnulib/import -I$(srcdir)/../gnulib/import \ -I.. -I$(srcdir)/.. $(INCINTL) -I../bfd -I$(srcdir)/../bfd noinst_LIBRARIES = libgdbsupport.a base-commit: aad09917e04b33da463f1703aab8d057cfe3f54e -- 2.14.5