From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114043 invoked by alias); 8 Nov 2019 08:08:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114031 invoked by uid 89); 8 Nov 2019 08:08:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.1 spammy=tel, Tel, office X-HELO: mga07.intel.com Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 08:08:22 +0000 Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2019 00:08:19 -0800 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 08 Nov 2019 00:08:18 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 00:08:18 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 00:08:17 -0800 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.54) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 Nov 2019 00:08:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZpwVOW257uSPssWfn6PR/myZ6eDKiEV6YVVQcJug5yNkSSoqMQDh9kStGzo/yGlSWCfLml2iK2KGkYkUc4mtG27c5PiEg+LD/Vz57mSV6xwXr6sHKKaSubi80ttgpIuWVarVF183kB4n90kqgzrgizfwMQxTg/ea4QgZZAXvpY+3IaKSK2NAkAS+253SPpsKCC/FV4zFluuBslku+bi0tekoq3fZY4hRqelkd175IlsfrLJ6tF1hOSZoQ+UqS08gJQYJ3e3fQgDuIc1/Kk0QJon+O9WD+QehhI0DIb1HRo8VqQFzAuHi3P0JWSOXATnYQoX9QGURfGYJ27GwXE0Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+SUnJXJNfRrQQfrA0tP3oyLdzRethTagH1PFrrz3w9g=; b=eWebhvyByOppi+Wl1VY4zKsExd9XIANew9WBhCR+aEne/KCHL+VcGYlkuP6ZgvQmfkAG4iVhVP5ODn0eXaFNu48oMyqenn6cFqK4a8oin5ZV8sJUfGRvx6vweFg2pdViI3RNZtOnenVfcFwhOtkDeFl9Xi9wa8EW2mD+k7rwpXEt7zuQtxFOoSboRGbCcJxmnYdzB5rHn80kCkFoTaSWfMbCYvvJYFcnYml5/YzxuQd9lDUUiGD/yY71JfHvvQ3H1lsn8qVhNNWtzhoVtH7ErN4iX1U+sxiD32sjEASTdGO/uRxJS3pHRNmu+r8S6L2x6Qt7w4PIoVns/k6XCOD4nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+SUnJXJNfRrQQfrA0tP3oyLdzRethTagH1PFrrz3w9g=; b=Q7EhrlfbXTs+cB/vd3vn/xMUIlxkQL6O93qXyNCh4tXhTtDg3fYH7nqHmNj857LiMQoVI4LQD/V9cDedbtgvo9kJTv1kjCHAMTl05K5FCNxiOV/LsSJGlWOn+TqbBzkTg9BfBbtPBFaLeFccTt1y6/18PlBdqytAYYxlLz1S6ic= Received: from BYAPR11MB3030.namprd11.prod.outlook.com (20.177.225.91) by BYAPR11MB3573.namprd11.prod.outlook.com (20.178.239.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Fri, 8 Nov 2019 08:08:16 +0000 Received: from BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::58bc:32f3:b748:811]) by BYAPR11MB3030.namprd11.prod.outlook.com ([fe80::58bc:32f3:b748:811%7]) with mapi id 15.20.2408.024; Fri, 8 Nov 2019 08:08:16 +0000 From: "Aktemur, Tankut Baris" To: Tom Tromey , "Tankut Baris Aktemur (Code Review)" CC: "gdb-patches@sourceware.org" , "gnutoolchain-gerrit@osci.io" , Tom Tromey Subject: RE: [review] testsuite, cp: increase the coverage of testing pass-by-ref arguments Date: Fri, 08 Nov 2019 08:08:00 -0000 Message-ID: References: <20191031131928.55CE220AF6@gnutoolchain-gerrit.osci.io> <87tv7n39r8.fsf@tromey.com> In-Reply-To: <87tv7n39r8.fsf@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=tankut.baris.aktemur@intel.com; x-ms-exchange-purlcount: 1 x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c39ZjoKty06isSt1JA9a6goRea0QC3qLYFpfwhwRUtf1Hr5nYyiitLEkvGnbMuwI+7XneNvShAxGZGmIErs45JI3wTPfR/tEMBDwpKGOFKU= Return-Path: tankut.baris.aktemur@intel.com Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00222.txt.bz2 KiBPbiBGcmlkYXksIE5vdmVtYmVyIDEsIDIwMTkgNDoxOSBQTSwgVG9tIFRy b21leSB3cm90ZToNCj4gPj4+Pj4gIlRhbmt1dCIgPT0gVGFua3V0IEJhcmlz IEFrdGVtdXIgKENvZGUgUmV2aWV3KSA8Z2Vycml0QGdudXRvb2xjaGFpbi1n ZXJyaXQub3NjaS5pbz4gd3JpdGVzOg0KPiANCj4gVGFua3V0PiBGb3IgdGhl IGxhdHRlciB0d28sIHRoZSBtYWluIHJlYXNvbiBmb3IgZmFpbHVyZXMgaXMg dGhhdCB0aGUgY29tcGlsZXINCj4gVGFua3V0PiBkb2VzIG5vdCBlbWl0IHRo ZSBEV19BVF9kZWZhdWx0ZWQgYW5kIERXX0FUX2RlbGV0ZWQgYXR0cmlidXRl cy4gIFRoZXJlDQo+IFRhbmt1dD4gYXJlIG1vcmUgcGFzc2VzIHdpdGggY2xh bmcgYmVjYXVzZSBpdCBlbWl0cyBEV19BVF9jYWxsaW5nX2NvbnZlbnRpb24s DQo+IFRhbmt1dD4gd2hpY2ggZ2NjIGRvZXMgbm90LCBhbmQgdGhlIHBhdGNo IEkgc2VudCBmYXZvcnMgY29tcGlsZXIncyBoaW50IGlmIGl0DQo+IFRhbmt1 dD4gZGV0ZWN0cyBhIGNvbmZsaWN0IGJldHdlZW4gdGhlIERXX0FUX2NhbGxp bmdfY29udmVudGlvbiBhbmQgdGhlDQo+IFRhbmt1dD4gaW5mZXJyZWQgcmVz dWx0Lg0KPiANCj4gQ291bGQgeW91IGZpbGUgYSBHQ0MgYnVnIHJlcG9ydCBm b3IgdGhpcz8NCj4gDQo+IFRvbQ0KDQpZZXMuICBGaWxlZCBoZXJlOg0KaHR0 cHM6Ly9nY2MuZ251Lm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9OTI0 MTgNCg0KSSdsbCBwdXQgdGhpcyBsaW5rIGluIHRoZSBwYXRjaCwgdG9vLg0K DQotQmFyaXMNCg0KSW50ZWwgRGV1dHNjaGxhbmQgR21iSApSZWdpc3RlcmVk IEFkZHJlc3M6IEFtIENhbXBlb24gMTAtMTIsIDg1NTc5IE5ldWJpYmVyZywg R2VybWFueQpUZWw6ICs0OSA4OSA5OSA4ODUzLTAsIHd3dy5pbnRlbC5kZQpN YW5hZ2luZyBEaXJlY3RvcnM6IENocmlzdGluIEVpc2Vuc2NobWlkLCBHYXJ5 IEtlcnNoYXcKQ2hhaXJwZXJzb24gb2YgdGhlIFN1cGVydmlzb3J5IEJvYXJk OiBOaWNvbGUgTGF1ClJlZ2lzdGVyZWQgT2ZmaWNlOiBNdW5pY2gKQ29tbWVy Y2lhbCBSZWdpc3RlcjogQW10c2dlcmljaHQgTXVlbmNoZW4gSFJCIDE4Njky OAo= >From gdb-patches-return-160625-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Nov 08 10:06:30 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 43542 invoked by alias); 8 Nov 2019 10:06:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 43531 invoked by uid 89); 8 Nov 2019 10:06:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Nov 2019 10:06:23 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iT19q-0006aG-0h; Fri, 08 Nov 2019 05:06:22 -0500 Received: from [176.228.60.248] (port=1879 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iT19d-0002i0-P8; Fri, 08 Nov 2019 05:06:11 -0500 Date: Fri, 08 Nov 2019 10:06:00 -0000 Message-Id: <83r22id6ns.fsf@gnu.org> From: Eli Zaretskii To: andrew.burgess@embecosm.com, gdb-patches@sourceware.org In-reply-to: <20191108005038.25D4B25B28@gnutoolchain-gerrit.osci.io> Subject: Re: [review v3] gdb/mi: Add -max-results parameter to some -symbol-info-* commands References: <20191108005038.25D4B25B28@gnutoolchain-gerrit.osci.io> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00223.txt.bz2 Content-length: 2613 > Date: Thu, 7 Nov 2019 19:50:32 -0500 > From: "Andrew Burgess (Code Review)" > > Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/269 > ...................................................................... > > gdb/mi: Add -max-results parameter to some -symbol-info-* commands > > Adds a new parameter -max-results to -symbol-info-functions, > -symbol-info-variables, -symbol-info-types, and -symbol-info-modules. > This parameter limits the number of results returned. > > This change still leaves -symbol-info-module-functions and > -symbol-info-module-variables always returning all results, fixing > these commands is slightly harder. > > There's currently no mechanism for the user of these commands to know > if the result list has been truncated if you get back the maximum > number of results, so if there are exactly 10 functions and you call > '-symbol-info-functions --max-results 10' the reply would appear no > different than if you had 20 functions and called with a max of 10. > Right now, if you get back the maximum then you should assume that > there might be more results available. > > gdb/ChangeLog: > > * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and > add it into the search spec. > (mi_info_functions_or_variables): Parse -max-results flag and pass > it to mi_symbol_info. > (mi_cmd_symbol_info_modules): Likewise. > (mi_cmd_symbol_info_types): Likewise. > * symtab.c (symbol_search::compare_search_syms): Update header > comment. > (global_symbol_searcher::is_suitable_msymbol): New function. > (global_symbol_searcher::expand_symtabs): New function. > (global_symbol_searcher::add_matching_symbols): New function. > (global_symbol_searcher::add_matching_msymbols): New function. > (global_symbol_searcher::search_symbols): Move most of the content > into the new functions above, and call them as needed. > * symtab.h: Add 'set' include. > (global_symbol_searcher) : New member > variable. > (global_symbol_searcher) : New member function. > (global_symbol_searcher) : New member > function. > (global_symbol_searcher) : New member > function. > (global_symbol_searcher) : New member > function. > > gdb/doc/ChangeLog: > > * doc/gdb.texinfo (GDB/MI Symbol Query): Add documentation of > -max-results to some -symbol-info-* commands. > > gdb/testsuite/ChangeLog: > > * gdb.mi/mi-sym-info.exp: Add tests for -max-results parameter. OK for the documentation part. Thanks.