[review v2] testsuite, cp: increase the coverage of testing pass-by-ref arguments

Tom Tromey (Code Review)
2019-12-13T21:38:04Z

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/142
......................................................................

Patch Set 2:

(1 comment)

Thanks for the patch.
I think it needs another modification, see below.

| --- gdb/testsuite/gdb.cp/pass-by-ref.exp
| +++ gdb/testsuite/gdb.cp/pass-by-ref.exp
| @@ -24,4 +343,18 @@ foreach state $all_combinations {
| + append stmts [generate_stmts "Derived" $state]
| +
| + append classes [generate_container_class $state]
| + append stmts [generate_stmts "Container" $state "cbv_container"]
| +}
| +
| +# Generate the program code and compile
| +set program [generate_program $classes $stmts]
| +set testfolder [file dirname $testfile]
| +gdb_produce_source ${srcdir}/${subdir}/$srcfile $program

PS2, Line 352:

I think the generated source should not be put into the source
directory; nor should it be part of the patch (or checked in).
Instead it can be built in test case's output directory.

| +
| +set options {debug c++ additional_flags=-std=c++11}
| +if {[prepare_for_testing "failed to prepare" $testfile $srcfile $options]} {
| return -1
| }
|
| -if ![runto_main] then {
| +if {![runto_main]} {
| + untested "failed to run to main"

--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie8ab1f260c6ad5ee4eb34b2c1597ce24af04abb6
Gerrit-Change-Number: 142
Gerrit-PatchSet: 2
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-CC: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 13 Dec 2019 21:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment